From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D60684319A; Wed, 18 Oct 2023 14:44:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7995402CD; Wed, 18 Oct 2023 14:44:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 30E4540261 for ; Wed, 18 Oct 2023 14:44:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697633065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nh/pV7tqKHNw1eey7MRsvhzTsL+Cnv3TEDp3rz2Zfsw=; b=VwhdDQsb1BP72OuqUnwHKRIL53+j3gsxrOfYjKZjm3Xmh2DuRY071Z0eFgmrKVcPLTvA4T 39TijslKloRszPjLwu5UDjqr1Kmkw/2AFJOTIZAKbMpydNch3VF1fkp/+6W/eIVPcUXeT/ FMyTrM3MCYgRHJCADFi+ccWm+fm3lgM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-7zY3n45VPKWcByCzPqZ6HA-1; Wed, 18 Oct 2023 08:44:24 -0400 X-MC-Unique: 7zY3n45VPKWcByCzPqZ6HA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b6ff15946fso64400011fa.2 for ; Wed, 18 Oct 2023 05:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697633063; x=1698237863; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nh/pV7tqKHNw1eey7MRsvhzTsL+Cnv3TEDp3rz2Zfsw=; b=kg8MapVKxLTiVaXMJN8nCJqps/9yV13vgruQJTLi3p5etWiSR3yfGNdHhf3Zp7rNTq sQb5pRXaOciOMNv3wZb8HhsDJmPse8SM/lQYqNr/V4xFSb0rjDMrqu/LnH8fEFrs/Aam X0CPKp29HO7lYjOvX6TIp1ZaGYop+d36rUM6QKTWD7VsFskXM3jUj6P7CD/zICuRWMYp 9SKJwb69BUpyQFqrftr07eq+nOO9fy8W5QXxh7CSuvHceF4eYMLmrBWrVU9JI5Nc7Hv2 NV5Sl+nXFqulvlkuCJTyFDDIScaeJAjOXM46EJH2Q5WMjxWM+kRlKZPCanUUa7Y341od w8KQ== X-Gm-Message-State: AOJu0YyF0K1AgdSUMP33kfmVEz8jOWLj5Fh3D8f3q6zuD5FQnoYRpmcx uPMV5QV0G8ERj9YT7j5tFI824kXnJ1EwPH+iVXJj9XtBdzb0ZRUi2GaitKQvqybsLCtAod3jRX4 wnm40ysotPWnLqewAGD4= X-Received: by 2002:a2e:a794:0:b0:2c5:1542:57e4 with SMTP id c20-20020a2ea794000000b002c5154257e4mr5728950ljf.31.1697633062967; Wed, 18 Oct 2023 05:44:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHc0tdFp2Qgaf07bXudiEm4mLaDu8DYmlKR+ZnFd9ErJMgyFwjtAj49yRQbupyECQ3dpKcjcrU/TnEJVxt188Y= X-Received: by 2002:a2e:a794:0:b0:2c5:1542:57e4 with SMTP id c20-20020a2ea794000000b002c5154257e4mr5728933ljf.31.1697633062593; Wed, 18 Oct 2023 05:44:22 -0700 (PDT) MIME-Version: 1.0 References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231018122558.126686-1-bruce.richardson@intel.com> <20231018122558.126686-2-bruce.richardson@intel.com> In-Reply-To: <20231018122558.126686-2-bruce.richardson@intel.com> From: David Marchand Date: Wed, 18 Oct 2023 14:44:11 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] event/skeleton: set driver name string To: Bruce Richardson , Jerin Jacob Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 18, 2023 at 2:26=E2=80=AFPM Bruce Richardson wrote: > > When calling rte_eventdev_info_get() the driver name string field should > be populated. > > Fixes: bbbb929da5e6 ("event/skeleton: add skeleton eventdev driver") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson event/dpaa2 seems affected too. Can rte_eventdev_info_get() fill this based on the driver attached to the device, like ethdev does? Something like untested: diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 95373bbaad..37ccc0dc77 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.c @@ -104,6 +104,7 @@ rte_event_dev_info_get(uint8_t dev_id, struct rte_event_dev_info *dev_info) dev_info->dequeue_timeout_ns =3D dev->data->dev_conf.dequeue_timeou= t_ns; dev_info->dev =3D dev->dev; + dev_info->driver_name =3D dev->dev->driver->name; rte_eventdev_trace_info_get(dev_id, dev_info, dev_info->dev); --=20 David Marchand