DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ci: add 32-bit travis builds
@ 2019-11-19 15:15 Bruce Richardson
  2019-11-19 16:06 ` Aaron Conole
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2019-11-19 15:15 UTC (permalink / raw)
  To: Aaron Conole, Michael Santana; +Cc: dev, Bruce Richardson

Add a travis job to build for 32-bit on 64-bit systems to catch additional
build errors, for example, incorrect use of printf specifiers with uint64_t
types.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .ci/linux-build.sh |  5 +++++
 .travis.yml        | 10 ++++++++++
 2 files changed, 15 insertions(+)

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 6075c440c..c570ba24e 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -23,6 +23,11 @@ if [ "$BUILD_DOCS" = "1" ]; then
     OPTS="$OPTS -Denable_docs=true"
 fi
 
+if [ "$BUILD_32BIT" = "1" ]; then
+    OPTS="$OPTS -Dc_args=-m32 -Dc_link_args=-m32"
+    export PKG_CONFIG_LIBDIR="/usr/lib32/pkgconfig"
+fi
+
 OPTS="$OPTS --default-library=$DEF_LIB"
 meson build --werror -Dexamples=all $OPTS
 ninja -C build
diff --git a/.travis.yml b/.travis.yml
index 3d6ef2959..7b9fc6898 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -23,6 +23,10 @@ extra_packages: &extra_packages
   - *required_packages
   - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4]
 
+build_32b_packages: &build_32b_packages
+  - *required_packages
+  - [gcc-multilib]
+
 doc_packages: &doc_packages
   - [doxygen, graphviz, python3-sphinx]
 
@@ -37,6 +41,12 @@ env:
 
 matrix:
   include:
+  - env: DEF_LIB="static" BUILD_32BIT=1
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *build_32b_packages
   - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1
     compiler: gcc
     addons:
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ci: add 32-bit travis builds
  2019-11-19 15:15 [dpdk-dev] [PATCH] ci: add 32-bit travis builds Bruce Richardson
@ 2019-11-19 16:06 ` Aaron Conole
  2019-11-19 21:38   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Aaron Conole @ 2019-11-19 16:06 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: Michael Santana, dev

Bruce Richardson <bruce.richardson@intel.com> writes:

> Add a travis job to build for 32-bit on 64-bit systems to catch additional
> build errors, for example, incorrect use of printf specifiers with uint64_t
> types.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

Nice!

Acked-by: Aaron Conole <aconole@redhat.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ci: add 32-bit travis builds
  2019-11-19 16:06 ` Aaron Conole
@ 2019-11-19 21:38   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2019-11-19 21:38 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: Michael Santana, Aaron Conole, dev

On Tue, Nov 19, 2019 at 5:06 PM Aaron Conole <aconole@redhat.com> wrote:
>
> Bruce Richardson <bruce.richardson@intel.com> writes:
>
> > Add a travis job to build for 32-bit on 64-bit systems to catch additional
> > build errors, for example, incorrect use of printf specifiers with uint64_t
> > types.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Aaron Conole <aconole@redhat.com>

Applied, thanks.



--
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-19 21:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 15:15 [dpdk-dev] [PATCH] ci: add 32-bit travis builds Bruce Richardson
2019-11-19 16:06 ` Aaron Conole
2019-11-19 21:38   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).