From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33BF8A0C41; Fri, 16 Apr 2021 09:00:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 084B8141B12; Fri, 16 Apr 2021 09:00:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1EA2B40140 for ; Fri, 16 Apr 2021 09:00:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618556428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LABOcXsMN2Z7l01hu7/0SC7+CJmT6BENfLi1WsUelfw=; b=ST967jQuJZ1tocGAK3Afgk1X5xqGBGWetZzJUppXa5ZIGUDrpgLglljQLpGHHkGPRf8Y9I uKODy4RtBdKa3PPb0U73eHWYGKbKjHVkoOgd1ocTx6PTwWEyiaVBPFqtltlrLGKQvqJnVO IDX6peInLr7t2xDqfCcIBzve3yyelqE= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-R_dBthTwM969wN7JEak0aw-1; Fri, 16 Apr 2021 03:00:26 -0400 X-MC-Unique: R_dBthTwM969wN7JEak0aw-1 Received: by mail-vk1-f200.google.com with SMTP id s186-20020a1f5ec30000b02901cfa330b3f9so2218291vkb.5 for ; Fri, 16 Apr 2021 00:00:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LABOcXsMN2Z7l01hu7/0SC7+CJmT6BENfLi1WsUelfw=; b=L8ktDMQN0sevjQo7Tr+6r5iK2VSF1RWPtsFQlexbV+OunoVmNaKsaVdV9flIpZjmTh tULLNGWdkx6/ZS2PXpOOxWivtzqZMv/n2Ic3n5VRrTeODJbLd/sABdpIzC5pqJsTq5oR jYjXJEyBGHfCvbCnbJMSzSqh90jOnqVTJurKD1eeXccVhnneqCNSvG3W1jFlwg1bDmzT HFiFq5Ppz0Cc1DPOgLYaDZaAqcsUWz5JGpwNO0hiaGbZiEFakrM0+sl7dIkWUfPaFpFQ QM6VhA4cvM4v1btsY5hSGALTE/e4PR4ap38SaTjrmwm+THCGARwgVeNQJR2zzdPvIqrA 0x3g== X-Gm-Message-State: AOAM53087gjszLVzJQ0m6jV6Dz5wPETSSwdS/r9KAbxxpQL6qADeugiV ga5fPpSRYeK//VZceZPWLhT4C+vcbSJXtmBBihmu2Y0YbNdiAvqZ9tY6aJd7s+2+1YqlzzJ2mDR 9p6QDUpzzWZsUfgBF+bQ= X-Received: by 2002:a1f:2a09:: with SMTP id q9mr5570118vkq.17.1618556425807; Fri, 16 Apr 2021 00:00:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0irETMI5sWhJn6aHzDqSH9oATgrcuBiE2Lj262MI+Rm7rcXgPLmtu1ExBQDsakoPGalw9Hp2Y5npRL79UHfc= X-Received: by 2002:a1f:2a09:: with SMTP id q9mr5570067vkq.17.1618556425121; Fri, 16 Apr 2021 00:00:25 -0700 (PDT) MIME-Version: 1.0 References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1618283653-16510-1-git-send-email-xuemingl@nvidia.com> <1618283653-16510-2-git-send-email-xuemingl@nvidia.com> In-Reply-To: <1618283653-16510-2-git-send-email-xuemingl@nvidia.com> From: David Marchand Date: Fri, 16 Apr 2021 09:00:13 +0200 Message-ID: To: Aaron Conole , dpdklab Cc: Thomas Monjalon , Gaetan Rivet , dev , "Xueming(Steven) Li" , Asaf Penso , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Gaetan Rivet , Anatoly Burakov , Ray Kinsella , Neil Horman , Ferruh Yigit , Andrew Rybchenko , Dodji Seketeli , ci@dpdk.org Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: > diff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h > index 296f19324f..134b44a887 100644 > --- a/lib/librte_eal/include/rte_devargs.h > +++ b/lib/librte_eal/include/rte_devargs.h > @@ -60,16 +60,16 @@ struct rte_devargs { > /** Name of the device. */ > char name[RTE_DEV_NAME_MAX_LEN]; > RTE_STD_C11 > - union { > - /** Arguments string as given by user or "" for no argument. */ > - char *args; > + union { /**< driver-related part of device string. */ > + const char *args; /**< legacy name. */ > const char *drv_str; > }; > struct rte_bus *bus; /**< bus handle. */ > struct rte_class *cls; /**< class handle. */ > const char *bus_str; /**< bus-related part of device string. */ > const char *cls_str; /**< class-related part of device string. */ > - const char *data; /**< Device string storage. */ > + char *data; > + /**< Raw string including bus, class and driver arguments. */ > }; > > /** - Flagging this patch for info and its impact on UNH jobs. This change is fine, but older libabigail versions could not deal with such changes (anonymous union, changes of const fields). This results in an ABI check failure in the UNH x86 job on Ubuntu 18.04 (and for some people not using recent libabigail). I can see the ARM job passes fine, so I suppose it is using a more recent libabigail (running Ubuntu 20.04 maybe?). We either need to disable this x86 job or update its libabigail package (maybe aligning with what we have for public CI which is libabigail 1.8 manually compiled). - For the longer term, what do you think of using/extending the .ci/ scripts for use by UNH jobs? -- David Marchand