From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0D9A4A059F;
Fri, 10 Apr 2020 14:12:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B24DF1D381;
Fri, 10 Apr 2020 14:12:44 +0200 (CEST)
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 25EAD1D179
for <dev@dpdk.org>; Fri, 10 Apr 2020 14:12:43 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1586520762;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=tAGIvqPaoZgF0Q9mNAd9WY0ehZs7Cu04XqDK3l5CpZU=;
b=YXldRHef37xNYI1XeCQUjDWnnLY38ow+gp8fGcRLpopPTOv609DFPabEgJBI5g1rqMr0Zz
OVf76/jf98X/WpFU4X75jyqZ9wHpxjKkZYtNv5g+5AYGNNqhgEawa8LwFmKyQit3zyRKPq
CUsd8vCFRyfNfa0k2KmgAuTbiWLYcAI=
Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com
[209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-398-o3euVQ_-OC-PYzfCjyYsYw-1; Fri, 10 Apr 2020 08:12:38 -0400
X-MC-Unique: o3euVQ_-OC-PYzfCjyYsYw-1
Received: by mail-vk1-f198.google.com with SMTP id d205so811185vke.8
for <dev@dpdk.org>; Fri, 10 Apr 2020 05:12:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=iP4kU95UT0WE6QK0FskDv+qhi6qSl5YWigAOJ4M4twA=;
b=d8tcINi5wNY8rLgAEZy9W5XDh1wF/YNdRS9xiuGMLJ6Z6r/yc96jo/eRoJ9GxZ/Lsc
fJKR1YLIWxzHcKc+ifTA5BWLmwoiSZp5suSNM5BktN6B5UeBN4XkIe+EKTsR4xZ2OUHG
SVy8oJ6q7RFqI3/Mw3gIEf33BWFVfNAVg/6NCtQhKtBLuZn6TX5giHxFIS6VCwCckyHl
c/ijTQhEIQgM1KG3akLfIODIED1+kGvcbfEddou2R/c5rB230+mGzEk9rBZT5jw+xlem
VCH1qFV1jgVpcDwHW0fvRthb3OWPztgbxnXgyLlLB8Uk/T/7Ibm3/QlS47tClx66a1oQ
dicQ==
X-Gm-Message-State: AGi0PuYlTDeY7wFv7SnWuodlWxAvbh/fCZAbUtDikiQ+Iou6rIXRqRIf
5V2WAXN1sx45bs9XdjK3cLzk4kWaEL5ONxajenjKgGGOzJxKwD+InVucAro2kuXJKHZkw27WPtN
/sGt7BQDtmQtsA8oocLs=
X-Received: by 2002:a1f:1255:: with SMTP id 82mr3069984vks.80.1586520758073;
Fri, 10 Apr 2020 05:12:38 -0700 (PDT)
X-Google-Smtp-Source: APiQypKQ5Sk7w4aZEsOPI6lWVURnGNfaMgrgtKPznyumNlbkP3BXt/GgrO+M0AU91OKvIuLkDkg9vRF0nHJ0wie4FNY=
X-Received: by 2002:a1f:1255:: with SMTP id 82mr3069964vks.80.1586520757725;
Fri, 10 Apr 2020 05:12:37 -0700 (PDT)
MIME-Version: 1.0
References: <20200403141921.10275-1-pbhagavatula@marvell.com>
<20200410090314.691-1-pbhagavatula@marvell.com>
In-Reply-To: <20200410090314.691-1-pbhagavatula@marvell.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 10 Apr 2020 14:12:26 +0200
Message-ID: <CAJFAV8y8p987iM=PST0JOsGkfXFhcUXN6DSvtMqnBXDZ++hXdw@mail.gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Neil Horman <nhorman@tuxdriver.com>, dev <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH v4] build: enable allow experimental API flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Apr 10, 2020 at 11:04 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and
> meson.build instead enable ALLOW_EXPERIMENTAL_API flag across app, lib an=
d
> drivers.
> This changes reduces the clutter across the project while still maintaini=
ng
> the functionality of ALLOW_EXPERIMENTAL_API i.e. warning external
> applications about experimental API usage.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Little conflict on app/test-fib/Makefile that git-am handles fine (but
Intel CI had trouble with).
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 351d29cb6..013e86715 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -393,7 +393,7 @@ dpdk_test =3D executable('dpdk-test',
> test_sources,
> link_whole: link_libs,
> dependencies: test_dep_objs,
> - c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],
> + c_args: [cflags, default_cflags],
> install_rpath: driver_install_path,
> install: true)
>
That would pass the flags twice.
I will fix when applying as:
+ c_args: cflags,
> diff --git a/drivers/mempool/octeontx2/Makefile b/drivers/mempool/octeont=
x2/Makefile
> index 337babf66..6af7b5432 100644
> --- a/drivers/mempool/octeontx2/Makefile
> +++ b/drivers/mempool/octeontx2/Makefile
> @@ -32,7 +30,7 @@ EXPORT_MAP :=3D rte_mempool_octeontx2_version.map
> #
> SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) +=3D \
> otx2_mempool_ops.c \
> - otx2_mempool.c \
> + otx2_mempool.c \
> otx2_mempool_irq.c \
> otx2_mempool_debug.c
>
> diff --git a/drivers/net/hinic/base/meson.build b/drivers/net/hinic/base/=
meson.build
> index 6cf947f84..0695994ba 100644
> --- a/drivers/net/hinic/base/meson.build
> +++ b/drivers/net/hinic/base/meson.build
> @@ -12,7 +12,7 @@ sources =3D [
> 'hinic_pmd_niccfg.c',
> 'hinic_pmd_nicio.c',
> 'hinic_pmd_wq.c',
> - 'hinic_pmd_mbox.c',
> + 'hinic_pmd_mbox.c',
> ]
>
> extra_flags =3D []
> diff --git a/drivers/net/hinic/meson.build b/drivers/net/hinic/meson.buil=
d
> index bc7e24639..34ec4af66 100644
> --- a/drivers/net/hinic/meson.build
> +++ b/drivers/net/hinic/meson.build
> @@ -8,7 +8,7 @@ sources =3D files(
> 'hinic_pmd_ethdev.c',
> 'hinic_pmd_rx.c',
> 'hinic_pmd_tx.c',
> - 'hinic_pmd_flow.c',
> + 'hinic_pmd_flow.c',
> )
>
> includes +=3D include_directories('base')
> diff --git a/lib/librte_gso/meson.build b/lib/librte_gso/meson.build
> index ad8dd8583..af3a63381 100644
> --- a/lib/librte_gso/meson.build
> +++ b/lib/librte_gso/meson.build
> @@ -2,6 +2,6 @@
> # Copyright(c) 2017 Intel Corporation
>
> sources =3D files('gso_common.c', 'gso_tcp4.c', 'gso_udp4.c',
> - 'gso_tunnel_tcp4.c', 'rte_gso.c')
> + 'gso_tunnel_tcp4.c', 'rte_gso.c')
> headers =3D files('rte_gso.h')
> deps +=3D ['ethdev']
Whitespace damage, will remove those hunks when applying.
Reviewed-by: David Marchand <david.marchand@redhat.com>
Thanks.
--=20
David Marchand