From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D161CA32A3 for ; Fri, 25 Oct 2019 15:14:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82C3E1C1C9; Fri, 25 Oct 2019 15:14:33 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 443CD1C1C6 for ; Fri, 25 Oct 2019 15:14:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572009271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kvtT+TJhHxKSjiWAsyJ2XgKaV+JWUO4/+O7ITWLt8wE=; b=MQvQmGXNRuaWiPEBfvKse2kAZxm20AqW0kx/H9yhv+rdCwWRrJSC7gpxZcpPGGha/QL+Q0 gTgCXwEzz24n/jJ0AzbqF36fbhIoiif8oqUvAvrwzvnytalwbKZddTa9l0AHcA/Oq/0wvF Vv7mKUfFs8vGk656Zv2X5Ch7kjfMJIM= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-amhbOSd1Mpy2YDEoX-sUBQ-1; Fri, 25 Oct 2019 09:14:28 -0400 Received: by mail-vk1-f197.google.com with SMTP id i20so780064vkk.21 for ; Fri, 25 Oct 2019 06:14:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kvtT+TJhHxKSjiWAsyJ2XgKaV+JWUO4/+O7ITWLt8wE=; b=Wf23IeTXox616oqsqAem4k30SUEeoQKXCOHJ9WpYMBHNvWanNChYnxm4KsMveUekiM eznAGcczojoZXu9+LTVkW9QZVp12lBsFgDaFVWgIFhKOfOJ1mYirVeocfWKEKQG2d2JX R6hegKaEjhvzlFKgXZMzXFWxNC6S7VSPPhkmjNge5VgYt3W1S18qfvf8545DJssqWA3Z tBXb/ml1oupYQklKPqldcgIO/0s5Qvty7VcJl/7HEJNsUaHx3oIJmHTjsqdQJC0fFeFv WdeUm4hifxCrlepol/sEEqrxcPWdTCO76Q6TJEm3UvrdFDHNwOVH+9MD/G0G7xha/0xD Ma4Q== X-Gm-Message-State: APjAAAXgM1HbPXees0AWXxil+9gQp0fK+XUVd3rDK1RNJCVB4jKvwqVC JBo4zzWlTItKOchZaY0fYNE9zd777M5DlcJdfqsIt0xdAkvmCj5x//v+Pp+mq+seIuGWqKNPNMK doO/cj0VaMOvGU0ODEE4= X-Received: by 2002:a1f:4b05:: with SMTP id y5mr1935987vka.12.1572009267621; Fri, 25 Oct 2019 06:14:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzv6SYTkop3/OTCNhy+Sy3ui6LNOXxe/NX3dcUEglDB/Ke9KimEjvKpGPkC54aSmVbVsjR5ylBNndGOaDhbsWk= X-Received: by 2002:a1f:4b05:: with SMTP id y5mr1935954vka.12.1572009267183; Fri, 25 Oct 2019 06:14:27 -0700 (PDT) MIME-Version: 1.0 References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com> <1571799298-18873-1-git-send-email-joyce.kong@arm.com> In-Reply-To: <1571799298-18873-1-git-send-email-joyce.kong@arm.com> From: David Marchand Date: Fri, 25 Oct 2019 15:14:16 +0200 Message-ID: To: Joyce Kong Cc: dev , nd , Thomas Monjalon , Jerin Jacob Kollanukkaran , Stephen Hemminger , mb@smartsharesystems.com, Honnappa Nagarahalli , Gavin Hu , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou X-MC-Unique: amhbOSd1Mpy2YDEoX-sUBQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation APIs in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 23, 2019 at 4:55 AM Joyce Kong wrote: > > There are a lot functions of bit operations scattered in PMDs, > consolidate them into a common API family and applied in different > PMDs to reduce code duplication. > > v2: > 1. Add doxygen comments for the rte bit operation API(suggested by Step= hen Hemminger). > 2. Add test cases for common rte bit operation API(suggested by Stephen= Hemminger). > 3. Change the header file to rte_io_bitops.h and the operation to rte_i= o_set_bit()etc., > as the API uses barriers inside and the barriers are only needed for= IO operations > (suggested by Jerin Jacob). > 4. Use an well defined uint_NN_t type(suggested by Morten Br=C3=B8rup). Thanks for working on this. This series is a cleanup and worth looking at, yet it came rather late. Discussion and enhancement can still continue, but it will be deferred to 2= 0.02. -- David Marchand