From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB4BBA034F; Wed, 13 May 2020 10:58:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AFEF1D179; Wed, 13 May 2020 10:58:31 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 5F0DE1D171 for ; Wed, 13 May 2020 10:58:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589360309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jfyFm0onV/SYk/MD2S5OJpVwEl0FKtNMyYeRCaEq3ZI=; b=h1sxquucI3Boa1YAZ+novpjY8nQArj3lYsU2OmExt3C3cozzw9fqUhalGPSHUChFkuflNm /ylPHpC4fE074xL4QoI+Y9AE0vT/SrVu1ErsgnJ48pjiN/uuCMmmaix3jMo18+CPaC5mWY g59AoH6wdKg5d8nhVolEvPC1waYdTY0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-PUd1sj4KPkmBWv3HdY4CkQ-1; Wed, 13 May 2020 04:58:25 -0400 X-MC-Unique: PUd1sj4KPkmBWv3HdY4CkQ-1 Received: by mail-ua1-f72.google.com with SMTP id a2so7054960uas.17 for ; Wed, 13 May 2020 01:58:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jfyFm0onV/SYk/MD2S5OJpVwEl0FKtNMyYeRCaEq3ZI=; b=l4lNX8WOwvRB2gN14NAfGHrq5E0mTKH13zjR80pfEismctf6OssRXktb1MNfIh5097 l97721cngx2+yiYTQiZSxn1ICqnRqxQGvhuCga3orPXqTgRQYjjDhY22N/Zsl3Oqo6a4 wmj5l63O1iaIRwy0CK9V+Gd2Hh2Hts7Xrif1H36x11fb5o1PkIUrHWUyqi/HZcVjKms/ MvacCFA9jUMj4O8DF5f0vjmypSwGdw36PR/hpDRQvGg1yZ+aVa5rGUOydibOX4p66rkN tLg6pBjwXQWOxw4lld1Wc9d106YZs62rBboam53gs/0TpjXRcyLuJsCvo6k5N4Hf6lw0 PX8g== X-Gm-Message-State: AGi0PuYx8mCppAvmVaUERitOO7VAI19GN7mIlqWPegNBoy28y+cP2MPl VSn5ocO9u2kOPK7M/xSUncGmJyK3KQbVJZkyF1M+UOGJwvTtvK4UISDxEn8tiXa5GGPLVfTAZeA KgM5FoxphfBiDtxe/85I= X-Received: by 2002:ab0:5586:: with SMTP id v6mr18506627uaa.87.1589360304492; Wed, 13 May 2020 01:58:24 -0700 (PDT) X-Google-Smtp-Source: APiQypLBAcyjPI1csTqmlWWrP7gifsaa2MPNjqxI6zhWe4OnW+ldru6j8TWbNdgWHJ4BUpQDEHrv3SBtlnKWPw8IgTs= X-Received: by 2002:ab0:5586:: with SMTP id v6mr18506615uaa.87.1589360304191; Wed, 13 May 2020 01:58:24 -0700 (PDT) MIME-Version: 1.0 References: <20200511100059.5035-1-pbhagavatula@marvell.com> <20200513010456.2863-1-pbhagavatula@marvell.com> In-Reply-To: <20200513010456.2863-1-pbhagavatula@marvell.com> From: David Marchand Date: Wed, 13 May 2020 10:58:13 +0200 Message-ID: To: Pavan Nikhilesh , Ray Kinsella Cc: Jerin Jacob Kollanukkaran , Andrzej Ostruszka , Neil Horman , Nithin Dabilpuram , Anoob Joseph , Thomas Monjalon , dev , Dodji Seketeli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] common/octeontx2: move internal symbols to INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 13, 2020 at 3:05 AM wrote: > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index c9ee73cb3..dfe346db4 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -48,3 +48,7 @@ > changed_enumerators = RTE_CRYPTO_AEAD_LIST_END > [suppress_variable] > name = rte_crypto_aead_algorithm_strings > + > +; Ignore moving internal OCTEONTX2 stable functions to INTERNAL tag > +[suppress_file] > + soname_regexp = librte_common_octeontx2.* This syntax will work with libabigail (current master and 1.7), but not with older versions like the 1.6 we use in Travis: https://travis-ci.com/github/david-marchand/dpdk/jobs/333080901#L2387 mlx common drivers were handled with the file_name_regexp syntax. https://git.dpdk.org/next/dpdk-next-net-mlx/diff/devtools/libabigail.abignore?id=196ca2dfc05df7685b86aba8cdd657b4aa401ffa Rather than bump to 1.7 in Travis, my preference goes to using a single syntax for those exceptions. Ray, opinion? -- David Marchand