From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8976142606; Thu, 21 Sep 2023 14:52:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21387402D2; Thu, 21 Sep 2023 14:52:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BFF07402C5 for ; Thu, 21 Sep 2023 14:52:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695300771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Br+CHE5z6TM7HTOm/yK3OEfFANwEX1mUV/OgnOmzyGs=; b=WqOZxtTbpP/pS/gp5U9MopSaluKgPvqGxRslDxGZjJhLJDySRBw9yAkfufKEBJDR/Cb9hM JaS8hOQvnHps+ii6CpVc48GcWRRYdX557X2aeX0K8rQlVcr2bZX90H2Wv72RhZ7Lfj754Q Ds6knzBXzTZCQ6Wojtv634/2ph5Exf8= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-MpufWGeBMSGJ-r2DmpfzUA-1; Thu, 21 Sep 2023 08:52:47 -0400 X-MC-Unique: MpufWGeBMSGJ-r2DmpfzUA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c030cea151so11782271fa.0 for ; Thu, 21 Sep 2023 05:52:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695300766; x=1695905566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Br+CHE5z6TM7HTOm/yK3OEfFANwEX1mUV/OgnOmzyGs=; b=rE+nI/dUtiMNLMLcyZ/udSE91rgG+Fw8M2k9XjhydzfCNcFKTcqLT2UaMAZgcnrqv8 cFz25uHTvRC6FMQTgHqV+aDCgWgnw153DwHP7Bfcl5yEfK8Nu9S/yjU2tG7pLNVRUpPX tTh4vwsjm+yFFHK28bk0z5xXb4OQ4ytIIuBcKmQ1NRfOdHqI8S8p8kePxGwgs2dLIi6i fsoSodpMlEGCoHp9Q7/yIkH0P2U/WKoSFxsVYfADh6JwfHqAd61rpLKhSRaXrtGJ9UiV 3gGtAFg21zQg//O/htiDi9rNPw6kGsU6tIy3LNk3/4rRY3bN4O7z5aMggr62QT6cGb36 LUjw== X-Gm-Message-State: AOJu0YwIpIDc6uzt/aZ5qGOLqA6B2U4Q4svn9ro5EBQnX/lI7vxAUfn5 mL8rCYNcUWqbxh2DgxzmPShuyL229TPiADUjqdWPhIml6OQPb+CsjXwp0WAlnON5lthxWRyvJdD YEvVPlCEO66FQ7CkG5+s= X-Received: by 2002:a2e:301a:0:b0:2bc:bcc6:d4ad with SMTP id w26-20020a2e301a000000b002bcbcc6d4admr4811274ljw.21.1695300766368; Thu, 21 Sep 2023 05:52:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSW7wPuVb7OZVpdhlCbRwf3+gRHVnbqUFAmGI5ZLqJRKZ+ErOe0VCehcNrEEu9LpSxtYY6E3vtkUlzwbgOcCU= X-Received: by 2002:a2e:301a:0:b0:2bc:bcc6:d4ad with SMTP id w26-20020a2e301a000000b002bcbcc6d4admr4811259ljw.21.1695300765995; Thu, 21 Sep 2023 05:52:45 -0700 (PDT) MIME-Version: 1.0 References: <20230830155927.3566-1-syalavarthi@marvell.com> <20230830155927.3566-3-syalavarthi@marvell.com> In-Reply-To: From: David Marchand Date: Thu, 21 Sep 2023 14:52:34 +0200 Message-ID: Subject: Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read To: Jerin Jacob , Srikanth Yalavarthi Cc: Prince Takkar , dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 21, 2023 at 2:08=E2=80=AFPM Jerin Jacob = wrote: > > On Wed, Aug 30, 2023 at 9:40=E2=80=AFPM Srikanth Yalavarthi > wrote: > > > > Dropped use of rte_firmware_read API to read ML firmware > > binary. When DPDK is built with libarchive aaupport, the > > the RTE API assumes the binary file as a compressed The rte_firmware API supports both xz-compressed and uncompressed files. Otherwise, it would break loading net/ice on systems where /lib/firmware content is uncompressed (which is still the case in some Linux distributions). To convince myself, I wrote a quick tool ("./archive" below) that outputs in hexa the content of a file, with the same libarchive calls. With a xz-compressed file: $ hexdump -C /lib/firmware/intel/ice/ddp/ice.pkg.xz | head -1 00000000 fd 37 7a 58 5a 00 00 01 69 22 de 36 02 00 21 01 |.7zXZ...i".6..= !.| $ ./archive /lib/firmware/intel/ice/ddp/ice.pkg.xz | head -1 00000000: 01 00 00 00 05 00 00 00 1C 00 00 00 70 00 00 00 | ............p..= . Uncompressing this file, and passing it to the same tool: $ hexdump -C ice.pkg | head 00000000 01 00 00 00 05 00 00 00 1c 00 00 00 70 00 00 00 |............p.= ..| $ ./archive ice.pkg | head 00000000: 01 00 00 00 05 00 00 00 1C 00 00 00 70 00 00 00 | ............p..= . For the record, I am using: $ rpm -q libarchive libarchive-3.6.1-3.fc37.x86_64 > > archive. This causes the ML firmware binary to be parsed > > incorrectly. > > + @David Marchand rte_firmware_read() author for his opinions /lib/firmware/mlip-fw.bin does not seem to be something packaged in Fedora, and I found no trace in linux-firmware repo, so I can't reproduce your issue. Please add some debug and give more details about the issue you are facing. --=20 David Marchand