DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, "Xia, Chenbo" <chenbo.xia@intel.com>,
	Jiayu Hu <jiayu.hu@intel.com>,
	 "Wang, YuanX" <yuanx.wang@intel.com>,
	"Ma, WenwuX" <wenwux.ma@intel.com>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [RFC 00/14] vhost: clean-up and simplify async implementation
Date: Fri, 8 Oct 2021 14:36:04 +0200
Message-ID: <CAJFAV8y9winQcgbV=iofQTfsU=HQMuQ=kDik_wYO53a00CnJxA@mail.gmail.com> (raw)
In-Reply-To: <20211007220013.355530-1-maxime.coquelin@redhat.com>

On Fri, Oct 8, 2021 at 12:13 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This series aims at cleaning and simplifying the async
> enqueue path. I think it makes the code easier to
> understand, and is necessary before integrating new
> changes.
>
> I may have more reworks to propose in next revisions,

There is some consolidation that could be done in split/packed
sync/async rx helpers too.
Is this what you have in mind?


> but I wanted to share my current status early so that
> you have time to review/test it.
>
> It is only compile-tested, as I don't have HW with IOAT
> support to test it.
>
> Maxime Coquelin (14):
>   vhost: move async data in a dedicated structure
>   vhost: hide inflight async structure
>   vhost: simplify async IO vectors
>   vhost: simplify async IO vectors iterators
>   vhost: remove async batch threshold
>   vhost: introduce specific iovec structure
>   vhost: remove useless fields in async iterator struct
>   vhost: improve IO vector logic
>   vhost: remove notion of async descriptor
>   vhost: simplify async enqueue completion
>   vhost: simplify getting the first in-flight index
>   vhost: prepare async for mbuf to desc refactoring
>   vhost: prepare sync for mbuf to desc refactoring
>   vhost: merge sync and async mbuf to desc filling
>
>  examples/vhost/ioat.c       |  30 +-
>  examples/vhost/ioat.h       |   2 +-
>  lib/vhost/rte_vhost_async.h |  42 +--
>  lib/vhost/vhost.c           | 129 +++----
>  lib/vhost/vhost.h           |  67 ++--
>  lib/vhost/vhost_user.c      |   4 +-
>  lib/vhost/virtio_net.c      | 697 ++++++++++++++----------------------
>  7 files changed, 379 insertions(+), 592 deletions(-)

Just had a quick look.
Nice to shrink vq memory footprint again.
And less code is always better.

+1 from me.


-- 
David Marchand


  parent reply	other threads:[~2021-10-08 12:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 21:59 Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 01/14] vhost: move async data in a dedicated structure Maxime Coquelin
2021-10-14  3:24   ` Hu, Jiayu
2021-10-14  8:54     ` Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 02/14] vhost: hide inflight async structure Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 03/14] vhost: simplify async IO vectors Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 04/14] vhost: simplify async IO vectors iterators Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 05/14] vhost: remove async batch threshold Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 06/14] vhost: introduce specific iovec structure Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 07/14] vhost: remove useless fields in async iterator struct Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 08/14] vhost: improve IO vector logic Maxime Coquelin
2021-10-12  6:05   ` Hu, Jiayu
2021-10-12  8:34     ` Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 09/14] vhost: remove notion of async descriptor Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 10/14] vhost: simplify async enqueue completion Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 11/14] vhost: simplify getting the first in-flight index Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 12/14] vhost: prepare async for mbuf to desc refactoring Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 13/14] vhost: prepare sync " Maxime Coquelin
2021-10-07 22:00 ` [dpdk-dev] [RFC 14/14] vhost: merge sync and async mbuf to desc filling Maxime Coquelin
2021-10-08 12:36 ` David Marchand [this message]
2021-10-12  6:24 ` [dpdk-dev] [RFC 00/14] vhost: clean-up and simplify async implementation Hu, Jiayu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8y9winQcgbV=iofQTfsU=HQMuQ=kDik_wYO53a00CnJxA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=wenwux.ma@intel.com \
    --cc=yuanx.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git