From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 883A2A034F; Fri, 8 Oct 2021 14:36:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EDDA410DB; Fri, 8 Oct 2021 14:36:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 892F340F35 for ; Fri, 8 Oct 2021 14:36:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633696580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+7NHxr7LaXtsTF6q8ZPlZmIUpw87mLK8Tzu1h8OZM6I=; b=duO1LWtvvVsOqRpI48ZehzK20fLWGXdmRwoHY9+Nt6GGyc5Z6xWHCclDk3T1VzDdFVZRa3 UW/ioC6ELTYH8IIVTfHtLCL9pgd+boEDi+xwicb0DnZLv7cMrB95F1ooIrbK3klExSqIPt OOuPjOLhGv2U1Mgg0/ujhF1g0oqrIMU= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-iKfrXtp-MFaEFaL_hsIslw-1; Fri, 08 Oct 2021 08:36:17 -0400 X-MC-Unique: iKfrXtp-MFaEFaL_hsIslw-1 Received: by mail-lf1-f70.google.com with SMTP id h27-20020a0565123c9b00b003fca9e11144so6959323lfv.19 for ; Fri, 08 Oct 2021 05:36:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+7NHxr7LaXtsTF6q8ZPlZmIUpw87mLK8Tzu1h8OZM6I=; b=iw8ReUusPdfuvJO+XezahpOQDZ6GOCbliTZM05JJ7Q+KqhXOFj9W+Gji02/jhfDGti MtK1CW+J8GoPuvv3ZXOawol6aHnOQpJWquJchyVJLlLMD+KGc3KPdRtHlBiC2DhusXI0 UOwsOkZUlf2XEERkqMKJW8wZwbaIPj4N9ijp//QgSD1p+gcUX+ldJLwAyqOBIa3l+mQ1 S/CwO7JUbCSOENay+HOmjiYbYaePAHb3PgVKVEmqB29bJycz0hkDs0Q2EhCF29FAmUZR 8YkNT4lhRQeuTRKrSvheML59NMfGbycXlXODW9/gpSeUz1uq25L+lB7tDQDAaqVZZLh4 hleQ== X-Gm-Message-State: AOAM533kTkq/m6ZUzLc23OCqBNq+rLP5fh5b0EjGpq2IgQt5CTGBjQZW uDFAHkMhLyeCarc+XLa/Mgh+CV2JmZrDqiJ/LBNnEYsIwDhZ61ifRGG9Zw3ZFrb6pZ0pQ1tAdRS ZqUbWVxbUHjiQROxa5p4= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr3257298ljv.46.1633696575519; Fri, 08 Oct 2021 05:36:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7sJiunRdY7TBXmGypkgpUjf8GlxhA58EkptDRUMDWKqBzova0IHQXu9NVmhbf3thdkKpLrnU1S1Zgtit9tfc= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr3257273ljv.46.1633696575231; Fri, 08 Oct 2021 05:36:15 -0700 (PDT) MIME-Version: 1.0 References: <20211007220013.355530-1-maxime.coquelin@redhat.com> In-Reply-To: <20211007220013.355530-1-maxime.coquelin@redhat.com> From: David Marchand Date: Fri, 8 Oct 2021 14:36:04 +0200 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Jiayu Hu , "Wang, YuanX" , "Ma, WenwuX" , Bruce Richardson , "Mcnamara, John" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC 00/14] vhost: clean-up and simplify async implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 8, 2021 at 12:13 AM Maxime Coquelin wrote: > > This series aims at cleaning and simplifying the async > enqueue path. I think it makes the code easier to > understand, and is necessary before integrating new > changes. > > I may have more reworks to propose in next revisions, There is some consolidation that could be done in split/packed sync/async rx helpers too. Is this what you have in mind? > but I wanted to share my current status early so that > you have time to review/test it. > > It is only compile-tested, as I don't have HW with IOAT > support to test it. > > Maxime Coquelin (14): > vhost: move async data in a dedicated structure > vhost: hide inflight async structure > vhost: simplify async IO vectors > vhost: simplify async IO vectors iterators > vhost: remove async batch threshold > vhost: introduce specific iovec structure > vhost: remove useless fields in async iterator struct > vhost: improve IO vector logic > vhost: remove notion of async descriptor > vhost: simplify async enqueue completion > vhost: simplify getting the first in-flight index > vhost: prepare async for mbuf to desc refactoring > vhost: prepare sync for mbuf to desc refactoring > vhost: merge sync and async mbuf to desc filling > > examples/vhost/ioat.c | 30 +- > examples/vhost/ioat.h | 2 +- > lib/vhost/rte_vhost_async.h | 42 +-- > lib/vhost/vhost.c | 129 +++---- > lib/vhost/vhost.h | 67 ++-- > lib/vhost/vhost_user.c | 4 +- > lib/vhost/virtio_net.c | 697 ++++++++++++++---------------------- > 7 files changed, 379 insertions(+), 592 deletions(-) Just had a quick look. Nice to shrink vq memory footprint again. And less code is always better. +1 from me. -- David Marchand