From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8162C45B3A; Mon, 14 Oct 2024 19:01:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD9594065A; Mon, 14 Oct 2024 19:01:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DF60E402DE for ; Mon, 14 Oct 2024 19:01:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728925296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L2HE0j3TbH0mo9h5gpWVMay/QrHrb63wBb3+26OCYpc=; b=XhphzPwslsoPqTNB/kU/aN0mR/H+Q+kHjVKCVLJOTEBeAPQwVMPpnLWSAtzepDJN2l0X2t V5+DYsMWAP2JF5bnxBCs44XngO7eVqcCN557aJglDdhXtdhs6wXOX3taN/Yga/rB83oVjC xujAEqqx1kBZL2vPRZFOxBRIZeiyl+8= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-8_lhd9GQOIO_-dAzFk5TQg-1; Mon, 14 Oct 2024 13:01:35 -0400 X-MC-Unique: 8_lhd9GQOIO_-dAzFk5TQg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53691cd5a20so4111386e87.3 for ; Mon, 14 Oct 2024 10:01:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728925294; x=1729530094; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L2HE0j3TbH0mo9h5gpWVMay/QrHrb63wBb3+26OCYpc=; b=INyLAHx0zIbWtJY7ZJZnRv1FJ2/qOJ0nw6WnANzORm1ZtYbbpXjJYkCKOTa7B67nVg R2cykA/wekOBwGKKzVBEf4tlFFIBmN1IdJWuVqEznTIT1X4CeLzcYh0fK882+fGBNujF 3MpJnMU3yoCCuTmuPAD3XatvpVVMpMBMxlS3vraHQtNH9M2/VzzW+chPgbDpFcj8aYYW aoXe3rmhbCbbcM1yflAgi/EXNc75SlKOmaBNqyd/a/jmNib03f5GdXjVEwhueCjsdfEr l04+Zie8uoV6zJeZcvnJy6SpQD0ju1rsLxXhVDWSTrKVUw5L727VZSvQkXwLQv7opFqg DMEQ== X-Gm-Message-State: AOJu0YzkhkVIyTVlLPWMxAT13A16AwvsGTKAlu8wzwGuYcu2tvgmpp/W rVrxef0nb6MFZt+N7MkLufDUIqN4/yk03+ZFXD12VudgaArxa+YXrN3NFbeX6Neo+ai635sjhTV kA8DVrLR91wLaf4oYoW4YXxM7AHaxn5duZAVJUA6hNqNFCjT9as0bQyd7By1scAqhJpey3LJlXj 0Btq3rd57WPHcPy+k= X-Received: by 2002:a05:6512:3510:b0:539:e67e:7dcb with SMTP id 2adb3069b0e04-539e67e7e63mr2740722e87.23.1728925293731; Mon, 14 Oct 2024 10:01:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEN+bwFocJmrhIsIZyawZ+fCrnEU3NSxHQ6voanELa0P6CDkrkZNHiP3Z5uLPWi3CWFlODJdAuggmZBN7Ey6p4= X-Received: by 2002:a05:6512:3510:b0:539:e67e:7dcb with SMTP id 2adb3069b0e04-539e67e7e63mr2740708e87.23.1728925293252; Mon, 14 Oct 2024 10:01:33 -0700 (PDT) MIME-Version: 1.0 References: <20240906170436.1324677-1-vladimir.medvedkin@intel.com> In-Reply-To: <20240906170436.1324677-1-vladimir.medvedkin@intel.com> From: David Marchand Date: Mon, 14 Oct 2024 19:01:22 +0200 Message-ID: Subject: Re: [PATCH] fib: fix vector lookup To: Vladimir Medvedkin Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 6, 2024 at 7:04=E2=80=AFPM Vladimir Medvedkin wrote: > > Vector lookup uses gather instructions which loads data in 4byte chunks. > This could lead to out of bounds access at the end of the tbl24 in case > of 1 or 2 byte entries if e.g. lookup is attempted for 255.255.255.255 > in IPv4 case. > This patch fixes potential out of bound access by gather instruction > allocating an extra 4 byte in the end of the tbl24. > > Fixes: 7dc7868b200d ("fib: add DIR24-8 dataplane algorithm") > Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6") > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Applied, thanks. --=20 David Marchand