From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3996543DF6; Thu, 4 Apr 2024 09:09:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B578B40268; Thu, 4 Apr 2024 09:09:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9D4184025D for ; Thu, 4 Apr 2024 09:09:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712214597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f5c/CjUrzwLH5rVYI88rKFLypWd6CqM2gKG3NCOJ3t0=; b=KSnxNXB05akLPyHVnz3YzL8m4oO4CQDyL96Elj/ltruFxR2IxmuMhoo0MErEP3GF+qo273 e6ZLXvWjLtlwS4HhKYg19BPElD7KijX6+89OTylI81jgedQ+ppfzQwT9zprpwQwcT+gAKR r4E8Upu4UyWmXFNA9l04AMUG/dPPzzg= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-B6uO49euPhKZYrB8xt-3VA-1; Thu, 04 Apr 2024 03:09:54 -0400 X-MC-Unique: B6uO49euPhKZYrB8xt-3VA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-516c5810897so628863e87.1 for ; Thu, 04 Apr 2024 00:09:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712214593; x=1712819393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f5c/CjUrzwLH5rVYI88rKFLypWd6CqM2gKG3NCOJ3t0=; b=v5PRKT/w94+4TeZMP5XVclXKds7Wcjygx1Bm1A9cUB7UBxw4QCKfdZga7rXlStgWaC nGFHHAG8QJnH4X+g9u+/92MFJ0HXU8PGW5hWHrLSMeiB51n9brrSkXx1NH+qdn251MRY vFv1HVrnO0rtEv/TBftfwwTUkPi/EqYS2WUmeC4Cp+gkHhyMe+yKNo44vcF2bGPtwm9V LPD5S6a0cgGMxK1Np2yTjM6oE+le/TI9ZHvFm+/ELZ1MzE8G5Q4KOorryXJ0Apcw4dkc vuy8sSxkuGVWWPlFjtI3MYs3a7mpK8XzjH1ifglR21Isyazakd8nG07gi65tyeT0NBjB +49Q== X-Forwarded-Encrypted: i=1; AJvYcCUhaJ1ULEQES53bRui8MB0PJ49E982a99rWwSFxM6y3+JR8XP+JJ+s3E6q8mtY+U+6RwwBI3/lcfxJwbu4= X-Gm-Message-State: AOJu0YzpA1HO5p8coGzJVc1SKdiNytundjZUy1U1NA+HCD/2A53yEGUk W78d4NbdXgz/jGUT4vToui56B7MF5FO/sE1IO/LCOzHxAaXTR4ST5OqIAYtzz0Fgv87eD23Y3J+ ZwWJPWxXRGOISXfBf/aedupch85SXZtliHDwxrTMwcWekDM5gkLn6vBKCG9TOAxN09RECvkXvhB T3wuDPokKXzbn5ufs= X-Received: by 2002:ac2:484f:0:b0:513:ca65:8c58 with SMTP id 15-20020ac2484f000000b00513ca658c58mr1109544lfy.43.1712214593000; Thu, 04 Apr 2024 00:09:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEf3vrnH81HpblSxfmugNYv1zsCp7XkpyvsdmNb2PT9IY3pYh9ZNzpY4T0JbAVev24p5x8zLea9F7d0YIiHouM= X-Received: by 2002:ac2:484f:0:b0:513:ca65:8c58 with SMTP id 15-20020ac2484f000000b00513ca658c58mr1109535lfy.43.1712214592641; Thu, 04 Apr 2024 00:09:52 -0700 (PDT) MIME-Version: 1.0 References: <20240326235909.25276-1-mpazdan@arista.com> <20240403134026.7037-1-mpazdan@arista.com> <20240403164937.GA14169@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240403164937.GA14169@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Thu, 4 Apr 2024 09:09:40 +0200 Message-ID: Subject: Re: [PATCH] lib: add get/set link settings interface To: Tyler Retzlaff , Marek Pazdan Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, Marek, On Wed, Apr 3, 2024 at 6:49=E2=80=AFPM Tyler Retzlaff wrote: > > On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote: > > There are link settings parameters available from PMD drivers level > > which are currently not exposed to the user via consistent interface. > > When interface is available for system level those information can > > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ > > ETHTOOL_GLINKSETTINGS). There are use cases where > > physical interface is passthrough to dpdk driver and is not available > > from system level. Information provided by ioctl carries information > > useful for link auto negotiation settings among others. > > > > Signed-off-by: Marek Pazdan > > --- > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > > index 147257d6a2..66aad925d0 100644 > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -335,7 +335,7 @@ struct rte_eth_stats { > > __extension__ > > struct __rte_aligned(8) rte_eth_link { /**< aligned for atomic64 read/= write */ > > uint32_t link_speed; /**< RTE_ETH_SPEED_NUM_ */ > > - uint16_t link_duplex : 1; /**< RTE_ETH_LINK_[HALF/FULL]_DUPLEX = */ > > + uint16_t link_duplex : 2; /**< RTE_ETH_LINK_[HALF/FULL/UNKNOWN]= _DUPLEX */ > > uint16_t link_autoneg : 1; /**< RTE_ETH_LINK_[AUTONEG/FIXED] */ > > uint16_t link_status : 1; /**< RTE_ETH_LINK_[DOWN/UP] */ > > }; > > this breaks the abi. David does libabigail pick this up i wonder? > Yes, the CI flagged it. Looking at the UNH report (in patchwork): http://mails.dpdk.org/archives/test-report/2024-April/631222.html 1 function with some indirect sub-type change: [C] 'function int rte_eth_link_get(uint16_t, rte_eth_link*)' at rte_ethdev.c:2972:1 has some indirect sub-type changes: parameter 2 of type 'rte_eth_link*' has sub-type changes: in pointed to type 'struct rte_eth_link' at rte_ethdev.h:336:1: type size hasn't changed 2 data member changes: 'uint16_t link_autoneg' offset changed from 33 to 34 (in bits) (by +1 bits) 'uint16_t link_status' offset changed from 34 to 35 (in bits) (by +1 bits) Error: ABI issue reported for abidiff --suppr /home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI at 3/dpdk/devtools/libabigail.abignore --no-added-syms --headers-dir1 reference/usr/local/include --headers-dir2 build_install/usr/local/include reference/usr/local/lib/x86_64-linux-gnu/librte_ethdev.so.24.0 build_install/usr/local/lib/x86_64-linux-gnu/librte_ethdev.so.24.2 ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue). GHA would have caught it too, but the documentation generation failed before reaching the ABI check. http://mails.dpdk.org/archives/test-report/2024-April/631086.html --=20 David Marchand