From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 027CFA0547; Wed, 19 May 2021 11:59:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1A4640041; Wed, 19 May 2021 11:59:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 42FFB4003F for ; Wed, 19 May 2021 11:59:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621418356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0YCpksEyFV8ydqvCLQgzqUvsoH0m/RykoUyBxAFePl8=; b=HJ4Jv4hYsAttjV1EoDGVlbko8N4LXMrWTBritExDH94awYpx0EZ7zakDnoedoPONJ0MfCu nLZGlSjOfJs9S6VT/vksjp+EI9UMfUU4myhNW/qPwCtsRlhjsKq2qmaOZpPD4XbsEeGdcF fawsbFOfZiIOQNurhEY1Mvnlmq1DoHs= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541-EHO6t_BjMzu-7WwfjQT_AQ-1; Wed, 19 May 2021 05:59:14 -0400 X-MC-Unique: EHO6t_BjMzu-7WwfjQT_AQ-1 Received: by mail-ua1-f69.google.com with SMTP id z43-20020a9f372e0000b029020dcb32d820so5486907uad.2 for ; Wed, 19 May 2021 02:59:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0YCpksEyFV8ydqvCLQgzqUvsoH0m/RykoUyBxAFePl8=; b=VAno7xFIi+A1BF8CG7XTdM6Bka/CN+uS1M8S42iJ+hHTH9IbCY6qZw7Ii7mTelAjC+ tLcjZGV7AatTvZ+/tFfMgCRd+0nek0qTlo4jHp8g+PwVaUr2g4p4jnO1EzvjU8E8iqa7 WM30/Du5ih298DKOhDBkNkjXvNOA5Ct4IqcdUSy2BP+tGuQxrODr944shgW+nHpGIFKb DgQJE/iT6z14xAagepDRuZGe2wS+BuTPAbeC0kissjsfdo7Y/UaDeOFRwZIRXg6KHYI9 3us+1gr0y5kjmEr2cRXq2gidloC/t3RxTq61RMZxmyzQlhVo0B9bhKAzSoTi4XqwD/g/ SDpA== X-Gm-Message-State: AOAM532m74IY+aE8Xdpcs+6x31Y4uT9N2j79JXx06LXcEi5lnaCgfig+ LMEmdfGJ7C9Dg8xHeNgsuXHDgssOCwuh2Gt/kCSqwpO0qzcp+zA9TgCViNJ7HcQCbyiYkIEuh63 VPtLzXjXaPaMynbpoXB4= X-Received: by 2002:ab0:42a7:: with SMTP id j36mr14150975uaj.87.1621418354470; Wed, 19 May 2021 02:59:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOxFtKCKqLwdegkxEUaz0Ni+qZwcxXxiU23eHZImJJsvfpE/F5W3E+HjhNSXmzqJguRXT6nP0aA8fCXqoTFG0= X-Received: by 2002:ab0:42a7:: with SMTP id j36mr14150966uaj.87.1621418354263; Wed, 19 May 2021 02:59:14 -0700 (PDT) MIME-Version: 1.0 References: <1621099654-25535-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: David Marchand Date: Wed, 19 May 2021 11:59:02 +0200 Message-ID: To: "McDaniel, Timothy" Cc: dev , "Carrillo, Erik G" , "Van Haaren, Harry" , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: fix guide for DLB v2.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 17, 2021 at 3:48 PM McDaniel, Timothy wrote: > > > @@ -387,4 +366,17 @@ Class of service can be specified in the devargs, as > > follows > > > > > > .. code-block:: console > > > > > > - --vdev=dlb2_event,cos=<0..4> > > > + --allow ea:00.0,cos=<0..4> > > > + > > > +Use X86 Vector Instructions > > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > + > > > +DLB supports using x86 vector instructions to optimize the data path. > > > + > > > +The default mode of operation is to use scalar instructions, but > > > +the use of vector instructions can be enabled in the devargs, as > > > +follows > > > + > > > + .. code-block:: console > > > + > > > + --allow ea:00.0,vector_opts_enabled= > > > > This option does not exist. > > All I see is: > > drivers/event/dlb2/dlb2_priv.h:#define DLB2_VECTOR_OPTS_DISAB_ARG > > "vector_opts_disable" > > > > The option name changed with patch 93235/16973 "[1/1] event/dlb2: fix vector based dequeue", which > is currently out for review. That patch fixed a couple of recently discovered issues in the vector path, so to be safe > we changed the default from running with the vector dequeue optimizations to running with the scalar dequeue > implementation. I see Thomas had comments on this patch that changes the option (among other things). The documentation update for this option should go at the same time it is introduced/renamed. > > > What of --force-max-simd-bitwidth ? > > The intent of the " vector_opts_enabled" switch is to allow experimentally enabled the vector based > implementation, not to indicate whether those instructions are supported or not on the target platform. The commit 000a7b8e7582 ("event/dlb2: optimize dequeue operation") already had the issue: the event/dlb2 driver ignores the global knob on activating vector stuff. -- David Marchand