From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C911143AAD; Tue, 13 Feb 2024 11:42:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A04C14029C; Tue, 13 Feb 2024 11:42:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7DE194027B for ; Tue, 13 Feb 2024 11:42:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707820924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gNVxxVLBS8jDTQhoxdpSk0Hff4yH/QTlcJMHZnKKd1I=; b=HdljxuUp69P9/MatiMekf3cLAeYTxZ0OYPAfZLmvuLO/I4FhraPS10tQSbHFAKEky7Y/yX HucmAgtL3AXqLuG6F1+hHNEMwj9tcW6pec6wR7/f1hkf5n5wRBxwZ4D6VkxXvJlxGKyw4s QRERJWLMhOY0r/bh8A7dwrhxesk9d9Q= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-yeg36ReQNt-V4nkzAk8pvQ-1; Tue, 13 Feb 2024 05:42:00 -0500 X-MC-Unique: yeg36ReQNt-V4nkzAk8pvQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-51162d43c64so2358485e87.1 for ; Tue, 13 Feb 2024 02:42:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707820919; x=1708425719; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gNVxxVLBS8jDTQhoxdpSk0Hff4yH/QTlcJMHZnKKd1I=; b=MDX4RFwoZf9INCfg5kgU/TuhGo11c/JqYoofYtTLBqFNfBUCK3KnRF6ug5ofWPz0md tUBGBJlkGp/yjoftH3eoIxr2ybHlL5zhq+LQihQJMgO2yswKOMPgYyAs5MT8HbdBPmpx 9soTkIITu75RunyjLnd8agHlFO2TlQwcEq2dAYR8sv/NetCqaooVXQhUnTCUfWQc6RUe 4U6HMeY6flfSEUgEhqpedDv8x6YdFvgo/EwH62BbFmGms0cMABtT8+71dqo5ZlufLft+ EdwfnLlsMBqGb6SXRLop5KpZhQz2a0B/2u+AsJzNAV/yWeiz+56WoVd7c1ioEOuFI1TB PYbQ== X-Gm-Message-State: AOJu0Yx0051DURaSbTZbcv/H3Cl1nvbSqYRtKct9KfdVs/qrd89n0zOR inh3PpArL6wj+F4B4AF0dOqwldTuD6heWrZXW1VroNNm1yjbnXPPJhaciJWTfaLgHXvhKURoXCd HSjGGsUpQOY41ixaktbvk00++/yC1BDcrKVtXKH3jZH/nek8nCtMcR1famAQe8Wi0kOz4Y2pHjz mUSriic42f4fIVmc8= X-Received: by 2002:a05:6512:3a8b:b0:511:6e10:b80e with SMTP id q11-20020a0565123a8b00b005116e10b80emr7556388lfu.33.1707820919107; Tue, 13 Feb 2024 02:41:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHPsCpJeHIfuRsXOXNghvZmvKPRZDGgmjStlZiXCNDkutG9Fzb/K1l4H1A+NU+tPYbzP8PJsdI7zUHNECcbhs0= X-Received: by 2002:a05:6512:3a8b:b0:511:6e10:b80e with SMTP id q11-20020a0565123a8b00b005116e10b80emr7556374lfu.33.1707820918759; Tue, 13 Feb 2024 02:41:58 -0800 (PST) MIME-Version: 1.0 References: <1706660329-1752-1-git-send-email-roretzla@linux.microsoft.com> <20240212175603.GA1977@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240212175603.GA1977@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Tue, 13 Feb 2024 11:41:46 +0100 Message-ID: Subject: Re: [PATCH] eal: remove unnecessary use of statement expression To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 12, 2024 at 6:56=E2=80=AFPM Tyler Retzlaff wrote: > > ping > > could relevant maintainers take a look? This change comes from the old commit 5f2c68a710e1 ("lib: work around braced-groups within expressions"). I suspect this change breaks application compiling with pedantic, without setting a C standard >=3D C11. --=20 David Marchand