From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A451CA0542; Mon, 5 Dec 2022 11:24:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4329542B8E; Mon, 5 Dec 2022 11:24:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1470B40F18 for ; Mon, 5 Dec 2022 11:23:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670235838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zgvWn60qKCMe1CpNoVp8d9ypgTQWBTcEQbCPv6rtyL4=; b=JFH12aDfhaQCBD0gWKAkZtKmWWCpW7VSO42ulKLZZKNoGGU5qfJNCBbfWonZpadAfJqBpr qibkfWj/NTWzL0CvCSgwrMTcqJu6hGJEP9BH79OEAahtkTxSXexEOjCa3XWfNFpqEnnqlE 1ZQiGsKnKdR942XNdqGtSdXheXETqHw= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-108-n60_sqMHPPSUW1fPn8V64w-1; Mon, 05 Dec 2022 05:23:56 -0500 X-MC-Unique: n60_sqMHPPSUW1fPn8V64w-1 Received: by mail-pl1-f200.google.com with SMTP id x18-20020a170902ec9200b00189d3797fc5so2798600plg.12 for ; Mon, 05 Dec 2022 02:23:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zgvWn60qKCMe1CpNoVp8d9ypgTQWBTcEQbCPv6rtyL4=; b=gzghL2QcR8+WHEO/JsUPtyjLHyf3/OzZsoWemx+fFa0fG0VHRFQXuTDmRWWf9vM4Y+ 5wg82d57hg432VEArtvSD4hu50v1CMX22jRP9sC2HYWswv9Y++K2xTJUvM49IYzLWZ7R GsisNRWCu/MBTeqwbgOq+M9GSqTSzy6WirCGV/SnB3Gs7V7Yolvy3C2rVTbboXRQBNJm fP4pKE9zDO8P9JvnRgtZRv1MejbbyslaCpeAdI3ptyMQj6VJ+AA/vZFgSmv+PFGvt7qC paVlGemhcHCDgKyDS32DoXkzweTiQ9FZNIDqqcpcbjz1pigYc+vUoRLWL0lmqnwkSdwS l79A== X-Gm-Message-State: ANoB5pnicl26veTE5p0m88C1KvqBv7yM/PjReDskH07HdaET8qEMwLoI zB2VqiJ14bb/wv3A9naV9uiQ2TXs+rnTAj4CDrAcq9mkXd+MRk2tMyvZWRgtwcHuKuvRy6vBKPi nXY2VDf/sK7LqWbP0SE8= X-Received: by 2002:a62:f94c:0:b0:56e:174e:efdf with SMTP id g12-20020a62f94c000000b0056e174eefdfmr83723077pfm.29.1670235835795; Mon, 05 Dec 2022 02:23:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf6dl5ZIq68EDcMPE2uJitzObJsg0k2hqfyRco3/SAwEmWyoW96eUOQ50FHnkxHYtHsV30GR0nxC7xwgVeqmlhg= X-Received: by 2002:a62:f94c:0:b0:56e:174e:efdf with SMTP id g12-20020a62f94c000000b0056e174eefdfmr83723042pfm.29.1670235835507; Mon, 05 Dec 2022 02:23:55 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> <20221202110945.519708-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 5 Dec 2022 11:23:43 +0100 Message-ID: Subject: Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted To: David Marchand , ci@dpdk.org, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ajit Khaparde , Qi Zhang , Jerin Jacob Kollanukkaran , Raslan Darawsheh , Maxime Coquelin , "Xia, Chenbo" , Akhil Goyal , Luca Boccassi , Kevin Traynor , Christian Ehrhardt , "Xueming(Steven) Li" Cc: dev@dpdk.org, stable@dpdk.org, Bruce Richardson , Michael Santana , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 2, 2022 at 2:39 PM Aaron Conole wrote: > > David Marchand writes: > > > ld exports any global symbol by default if no version script is passed. > > As a consequence, the incriminated change let any public symbol leak > > out of the driver shared libraries. > > > > Hide again those symbols by providing a default map file which > > unexports any global symbol using a local: * catch-all statement. > > > > The checks are skipped for this default map file as it is intentionnally > > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > > maps")) and there is nothing else to check in this map. > > > > This change impacts the exported symbols, hence, bump the version in the > > ABI check to the v22.11.1 from the 22.11 LTS branch. > > > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > > Cc: stable@dpdk.org > > > > Reported-by: Luca Boccassi > > Signed-off-by: David Marchand > > Tested-by: Ferruh Yigit > > Reviewed-by: Bruce Richardson > Acked-by: Aaron Conole Series applied. Please, maintainers and CI teams, when you enable ABI checks in the main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 tag as a reference. Thanks. -- David Marchand