From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 818E6A0C52; Mon, 25 Oct 2021 13:09:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1ACAC40E32; Mon, 25 Oct 2021 13:09:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 215CF407FF for ; Mon, 25 Oct 2021 13:09:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635160195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gpSZ7Xn2MpfUmvLz3AjUmsUd+plt50McfD3xDGRv6S8=; b=diyaMTLkr5aX28xWpDPVvJzS117tiv5Lj3tE8Ppv94y8jq/BZaYoI7CCVRnvUFB82e/ZK5 a4r7XZGbuC1mJbnl69fkx2CQlPyNAXd6iI1eo+GcpPZV2NSAq+3FVM5TFoJ9NK8Y2gIh6p tO5VX6sOQxBL35VFvNodrvyLPoC0Mjc= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-rp3qtFOOOFOiUjDI6iO1yg-1; Mon, 25 Oct 2021 07:09:54 -0400 X-MC-Unique: rp3qtFOOOFOiUjDI6iO1yg-1 Received: by mail-lj1-f198.google.com with SMTP id s5-20020a2e98c5000000b002112895b3f6so2568649ljj.21 for ; Mon, 25 Oct 2021 04:09:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gpSZ7Xn2MpfUmvLz3AjUmsUd+plt50McfD3xDGRv6S8=; b=JAXXRoHsZ7uJ5JQz6Trxwu63djinkx503kdX5KDzSFDMYXU63mhIyvv55LuCmRnHYr i8CI/vKoDAA7ohqq0plD/sPyu6n7eR3KX7b4NuLHOWML5XqtSCQasn9DsYhJ0P61G41G ZJjJ6AV7cM/P9PhhMSF6WBZVaINnp5p9N0RVijKUw+GfHp022e65E8dYFQrWMTIHlhpG 42XUDJxyd7D2wl9qseyJNpjYSfnoEykD27uy8aHDXPKs6i9hNj37dYSV1QLpfdlXKPjG eVO9O3RyrdlwMOV/e3T9Ux9MaEBk8lt21dG/Qb3IPUnrAoBBf4gJvOSHAGsR0RmoXbNO CV5w== X-Gm-Message-State: AOAM533+0T7chvR2tITb8hi0e0NWRVNkelNSRtneWZGSoemkbzucMDvx RkgeIz2HWc9IREzWI8f02qqWd7xHNnf0+fusTBRZDT1/Cd9Z3eu2h1agH0rjdYz+LiFdFArSqU9 Gp1jjXRsvMk/LRXEpnus= X-Received: by 2002:a2e:a54a:: with SMTP id e10mr18326540ljn.159.1635160192810; Mon, 25 Oct 2021 04:09:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoI4JCPIZaqHBgf5KgVKBYB660c+1jm/2IUw4DRNfEAclyJH2P/PruAwrAVAMeERuNRI7SYRbkFJbMkNPnY9g= X-Received: by 2002:a2e:a54a:: with SMTP id e10mr18326528ljn.159.1635160192607; Mon, 25 Oct 2021 04:09:52 -0700 (PDT) MIME-Version: 1.0 References: <20211022204934.132186-1-hkalra@marvell.com> <20211024200449.12024-1-david.marchand@redhat.com> <20211024200449.12024-5-david.marchand@redhat.com> <20211025134926.52a6925e@sovereign> In-Reply-To: <20211025134926.52a6925e@sovereign> From: David Marchand Date: Mon, 25 Oct 2021 13:09:41 +0200 Message-ID: To: Dmitry Kozlyuk Cc: Harman Kalra , dev , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 4/9] alarm: remove direct access to interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 25, 2021 at 12:49 PM Dmitry Kozlyuk wrote: > > diff --git a/lib/eal/freebsd/eal_alarm.c b/lib/eal/freebsd/eal_alarm.c > > index c38b2e04f8..1a8fcf24c5 100644 > > --- a/lib/eal/freebsd/eal_alarm.c > > +++ b/lib/eal/freebsd/eal_alarm.c > > @@ -32,7 +32,7 @@ > > > > struct alarm_entry { > > LIST_ENTRY(alarm_entry) next; > > - struct rte_intr_handle handle; > > + struct rte_intr_handle *handle; > > This field is never used and can be just removed. Indeed, removed. > > > struct timespec time; > > rte_eal_alarm_callback cb_fn; > > void *cb_arg; > [...] > -- David Marchand