From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1C65A034F; Fri, 8 Oct 2021 13:02:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AB6C410E1; Fri, 8 Oct 2021 13:02:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C11FF410DA for ; Fri, 8 Oct 2021 13:02:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633690923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qI7IgmRVfClZDfWDJaauVT65VJB54ezFD/RqTKWFHh4=; b=hD1+AYqqy5JtNyeuYCsZ0VXNAWyfY7ge0hY1tja+jFL2IgLVNKKh2fthGosrYzhMnzmp74 oa8b2KRczMT0KWd5oc80ngkjZ3joXZmwT9IzLfoMnY+95XoGn3bAdg5gIA03BRJXRPkb9i eomdoL6TGNG6K8LP58C28BJZnIx2v9U= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-TtznzKZiN9SQBS3W0gxmOw-1; Fri, 08 Oct 2021 07:02:02 -0400 X-MC-Unique: TtznzKZiN9SQBS3W0gxmOw-1 Received: by mail-lf1-f72.google.com with SMTP id x29-20020ac259dd000000b003f950c726e1so4667080lfn.14 for ; Fri, 08 Oct 2021 04:02:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qI7IgmRVfClZDfWDJaauVT65VJB54ezFD/RqTKWFHh4=; b=WJROKnQXjqqUJym9GZLc4OZ6He6P1bMYmJbvhuAIpxOvrhKMZuRLGYGp09LYTqMhQZ d1HkDet6o4NA13+IMggTESmf7YygpEyUiBHAKvFZj4uLRpCj/JqyPO2mV/HKy8y4I2fn cDlLRELiT0cFov9AETLauf2Dw6YUHRv57fsW+2N9lv8BipE094z7nGmZ3IJyRBNXfCy5 kYF3s0SoktwT+en6LbGoxmO3kBRA99aMGKWlRzSzhmH5/NjKu+J5qE58a71q2FV9igq6 SYqdInxLjI58cy5iuFhoh5Qq5PBImRsfRVPs094yIJRREfX4kDYcTpVGXqOxfty+HGh5 KB1g== X-Gm-Message-State: AOAM532w6yh006IhHRuej3whQnhOINKlDaxdwi3/K/xurBa3e/cp1oZY Y2sChw7XJEDMOYEitFKK4IIrKQUxpWJfrREqGEBQJXZ9AOExBXJPVHPDDei3VS9aFrFmdvjv1Nk wvwQYgvH/3a43BK0ASrM= X-Received: by 2002:a2e:8584:: with SMTP id b4mr2921707lji.477.1633690920669; Fri, 08 Oct 2021 04:02:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5x+ER6jAyGoYfuVPyUped2JT+SE8wlgee+q+vb3vxBEqgyf50eGVGVvkSukcdJLS0XJhfUNQSZDdo6gdHmQw= X-Received: by 2002:a2e:8584:: with SMTP id b4mr2921570lji.477.1633690919028; Fri, 08 Oct 2021 04:01:59 -0700 (PDT) MIME-Version: 1.0 References: <20210929123134.1465507-1-junfeng.guo@intel.com> <20211008104143.236289-1-junfeng.guo@intel.com> In-Reply-To: From: David Marchand Date: Fri, 8 Oct 2021 13:01:47 +0200 Message-ID: To: "Zhang, Qi Z" Cc: "Guo, Junfeng" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "Yigit, Ferruh" , "stable@dpdk.org" , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/iavf: fix QFI field bit check for GTPU EH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 8, 2021 at 8:09 AM Zhang, Qi Z wrote: > > -----Original Message----- > > From: Guo, Junfeng > > Sent: Friday, October 8, 2021 6:42 PM > > To: Zhang, Qi Z ; Wu, Jingjing ; > > Xing, Beilei > > Cc: dev@dpdk.org; Yigit, Ferruh ; Guo, Junfeng > > ; stable@dpdk.org > > Subject: [PATCH v3] net/iavf: fix QFI field bit check for GTPU EH > > > > If GTPU Extionsion header has no pdu_type setting, the parsed value of extension. > > gtp_psc_spec->hdr.type will be 0, which is same as IAVF_GTPU_EH_DWLINK. > > Thus, for this case, we should check gtp_psc_mask->hdr.type instead, to set > > QFI field bit of GTPU_EH first. > > > > Fixes: cd212c466992 ("net/iavf: fix QFI fields of GTPU UL/DL for flow director") This patch fixes a 3 weeks old patch that was itself fixing. Fixes: 78e8a87f6324 ("net/iavf: fix GTPU UL and DL support for flow director") I hope all tests are now fine. > > Cc: stable@dpdk.org > > > > Signed-off-by: Junfeng Guo > > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. -- David Marchand