* [dpdk-dev] [PATCH] devtools: silence meson install
@ 2020-03-17 16:25 David Marchand
2020-03-18 10:02 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2020-03-17 16:25 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon
Installing with ninja is quite verbose by default, hide ninja output under
TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE options.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/test-meson-builds.sh | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index c2d33b3b9f..c1ff2bb50a 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -104,8 +104,13 @@ compile () # <builddir>
install_target () # <builddir> <installdir>
{
rm -rf $2
- echo "DESTDIR=$2 $ninja_cmd -C $1 install"
- DESTDIR=$2 $ninja_cmd -C $1 install
+ if [ -n "$TEST_MESON_BUILD_VERY_VERBOSE$TEST_MESON_BUILD_VERBOSE" ]; then
+ echo "DESTDIR=$2 $ninja_cmd -C $1 install"
+ DESTDIR=$2 $ninja_cmd -C $1 install
+ else
+ echo "DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null"
+ DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null
+ fi
}
build () # <directory> <target compiler> <meson options>
--
2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: silence meson install
2020-03-17 16:25 [dpdk-dev] [PATCH] devtools: silence meson install David Marchand
@ 2020-03-18 10:02 ` Bruce Richardson
2020-03-23 10:58 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2020-03-18 10:02 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Thomas Monjalon
On Tue, Mar 17, 2020 at 05:25:21PM +0100, David Marchand wrote:
> Installing with ninja is quite verbose by default, hide ninja output under
> TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE options.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> devtools/test-meson-builds.sh | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index c2d33b3b9f..c1ff2bb50a 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -104,8 +104,13 @@ compile () # <builddir>
> install_target () # <builddir> <installdir>
> {
> rm -rf $2
> - echo "DESTDIR=$2 $ninja_cmd -C $1 install"
> - DESTDIR=$2 $ninja_cmd -C $1 install
> + if [ -n "$TEST_MESON_BUILD_VERY_VERBOSE$TEST_MESON_BUILD_VERBOSE" ]; then
> + echo "DESTDIR=$2 $ninja_cmd -C $1 install"
> + DESTDIR=$2 $ninja_cmd -C $1 install
> + else
> + echo "DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null"
> + DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null
> + fi
> }
>
> build () # <directory> <target compiler> <meson options>
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: silence meson install
2020-03-18 10:02 ` Bruce Richardson
@ 2020-03-23 10:58 ` Thomas Monjalon
2020-03-23 13:20 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2020-03-23 10:58 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Bruce Richardson
18/03/2020 11:02, Bruce Richardson:
> On Tue, Mar 17, 2020 at 05:25:21PM +0100, David Marchand wrote:
> > Installing with ninja is quite verbose by default, hide ninja output under
> > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE options.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: silence meson install
2020-03-23 10:58 ` Thomas Monjalon
@ 2020-03-23 13:20 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-03-23 13:20 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Bruce Richardson, Thomas Monjalon
On Mon, Mar 23, 2020 at 11:58 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 18/03/2020 11:02, Bruce Richardson:
> > On Tue, Mar 17, 2020 at 05:25:21PM +0100, David Marchand wrote:
> > > Installing with ninja is quite verbose by default, hide ninja output under
> > > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE options.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-23 13:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 16:25 [dpdk-dev] [PATCH] devtools: silence meson install David Marchand
2020-03-18 10:02 ` Bruce Richardson
2020-03-23 10:58 ` Thomas Monjalon
2020-03-23 13:20 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).