From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCEDC43686; Mon, 11 Dec 2023 13:37:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4A8F40608; Mon, 11 Dec 2023 13:37:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 17DC44026B for ; Mon, 11 Dec 2023 13:37:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702298219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0FQNpBJf246Sg07tIV2M7L0Br8YYEFd1tNDapLsUaxE=; b=G8ZN+V956fEwP8u/AXLtdaTnevAtg9qA/ohaG1msq/14dZUfC1qWkGMMnDto/X1hG2EiRZ ql/Ne8j4Op2ISqtVYI/s5okkRsDzr2uDxGY8hfcm5nFnAPvivCRD2+/SDxFbjzwywAF4vZ lGKiqVrOLoi/mhw6QRMauSG2a/14HNA= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-y5g8kQKvPyCS7bUiFDgzDQ-1; Mon, 11 Dec 2023 07:36:56 -0500 X-MC-Unique: y5g8kQKvPyCS7bUiFDgzDQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ca005e8de4so33899821fa.3 for ; Mon, 11 Dec 2023 04:36:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702298215; x=1702903015; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0FQNpBJf246Sg07tIV2M7L0Br8YYEFd1tNDapLsUaxE=; b=Us1pDhjjuOE8p0sn7YpZ05dIQOARnb0DBW3IAzVLCHHVsrQ0PvwelKbaptO0uNyjh9 v1BUVDfX6SfBk6MXVEl2kgEAmfg4lz89lAD83N+JTBvXBW2lp+HZ/Op4n2y0vW8bItbC CubD/rV+kodnuWaqvghilZ7TqPG5h7LFn3E/Q0RYDfS7Xk9XVih+QU2geF5cvci2yYce 9u8WYvfgqBw6VWoTAhtl3Vy2QVgUguFilt0Q6bz8Jnu/ct28d3oXDgSieum/B0EzQfAE PDEFcS+V697deBqOQafROXCHKcpjDqTT/GgMtfAn9ZOuRzpM8oMRPoQ/0G7buCfn/77L 19pA== X-Gm-Message-State: AOJu0Yxidws9MPkFnQxCv4GeWULulcEnKZ8ChGAp+20QwOF/NIUAFMZz 7Ukxl7FdaeUPhhVtSQOwyhczjRHN9bW7X2M2FiyEny7udVhoQvDZI0EJ3CTWwZHXWA4Aa9phSo8 KH/8dZr+dW4ke+riDX+I= X-Received: by 2002:a05:651c:1590:b0:2cc:21fc:35f0 with SMTP id h16-20020a05651c159000b002cc21fc35f0mr999277ljq.72.1702298214989; Mon, 11 Dec 2023 04:36:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZmjowC/To6ZeIYSnV56fwu+3qejE/b26e+LlDx6kmVb6o31HkIwH/RLQ5wloJqlDWT9BzwRzDhvZ9nicpSpY= X-Received: by 2002:a05:651c:1590:b0:2cc:21fc:35f0 with SMTP id h16-20020a05651c159000b002cc21fc35f0mr999262ljq.72.1702298214725; Mon, 11 Dec 2023 04:36:54 -0800 (PST) MIME-Version: 1.0 References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-14-david.marchand@redhat.com> <20231208091828.3ed4c465@hermes.local> In-Reply-To: <20231208091828.3ed4c465@hermes.local> From: David Marchand Date: Mon, 11 Dec 2023 13:36:42 +0100 Message-ID: Subject: Re: [RFC v2 13/14] lib: replace logging helpers To: Stephen Hemminger Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, mb@smartsharesystems.com, Konstantin Ananyev , Ruifeng Wang , Andrew Rybchenko , Ori Kam , Yipeng Wang , Sameh Gobriel , Reshma Pattan , Anatoly Burakov , David Hunt , Sivaprasad Tummala , Ciara Power , Maxime Coquelin , Chenbo Xia X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 8, 2023 at 6:18=E2=80=AFPM Stephen Hemminger wrote: > > On Fri, 8 Dec 2023 15:59:47 +0100 > David Marchand wrote: > > > diff --git a/lib/bpf/bpf_impl.h b/lib/bpf/bpf_impl.h > > index b483569071..30d83d2b40 100644 > > --- a/lib/bpf/bpf_impl.h > > +++ b/lib/bpf/bpf_impl.h > > @@ -27,9 +27,10 @@ int __rte_bpf_jit_x86(struct rte_bpf *bpf); > > int __rte_bpf_jit_arm64(struct rte_bpf *bpf); > > > > extern int rte_bpf_logtype; > > +#define RTE_LOGTYPE_BPF rte_bpf_logtype > > > > -#define RTE_BPF_LOG(lvl, fmt, args...) \ > > - rte_log(RTE_LOG_## lvl, rte_bpf_logtype, fmt, ##args) > > +#define BPF_LOG(lvl, fmt, args...) \ > > + RTE_LOG(lvl, BPF, fmt "\n", ##args) > > Not sure about this. There were some cases where bpf_XXX function > names clashed with those in libpcap. That is probably why the > RTE_BPF_LOG was chosen. > That would only impact DPDK compilation as it is an internal header, but I get your point. I put a note to update in a next revision. --=20 David Marchand