From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 43F302986 for ; Fri, 3 May 2019 09:24:47 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id h17so1160742vke.5 for ; Fri, 03 May 2019 00:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZbyCq1ST4BxXpS70yCi1EU5ZO6LvOoU4HxvQmY+wpYw=; b=R4zU3ZwdEErbKnVMS7f/A3rtjlfytXDS4F8PKrQl7h37HPa7yrxL4IhcL9n8I9KXm6 pexev6HO222RqeYur8M9WVDI7BKy9u1cTd0EzqQdPSvkUG8yArmf9MK3MIsridBh2UNI VQ+iJq5rBTrGLL64qz6ppTgfZjOZD9anFVsuIE6/Z5ikCrQAQx2IdPk4dDfof0TH7L2g eHqq+B//T94uJv67YJUE8nHnsb6bHYJMD9NkkaAOa+PbuLIptLklpNRM/fY/TdLep8ws j70WLEp8ZRn5OdN4OJfLRr13MhC3EH/UcWCJbRA89Np9i+IRhtn1vq2/cJE7/nhaT94e y0rg== X-Gm-Message-State: APjAAAUerKXM3idUkfI4GTPqxq93SNdzmLUqq6tWIRpYxDbKiPrvZDZr JDJMJLA6J10zQeMDAzLuUN2HggkVPqAe0ESbvKjbhw== X-Google-Smtp-Source: APXvYqyDnEuQqCUa9yHW+XLBltQngBFsEF6CtwX+B/c34slfAj7xUZEI5Y770LdurJ7kFLty57iwnm9GKfng61V4C9o= X-Received: by 2002:a1f:c009:: with SMTP id q9mr4530700vkf.85.1556868286714; Fri, 03 May 2019 00:24:46 -0700 (PDT) MIME-Version: 1.0 References: <20190408182510.16078-1-stephen@networkplumber.org> <20190410171603.8979-1-stephen@networkplumber.org> <20190410171603.8979-2-stephen@networkplumber.org> In-Reply-To: <20190410171603.8979-2-stephen@networkplumber.org> From: David Marchand Date: Fri, 3 May 2019 09:24:35 +0200 Message-ID: To: Stephen Hemminger Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: use unsigned int in rte_lcore.h functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 07:24:47 -0000 On Wed, Apr 10, 2019 at 7:16 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > Purely cosmetic change, use unsigned int instead of unsigned alone. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/include/rte_lcore.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_lcore.h > b/lib/librte_eal/common/include/rte_lcore.h > index dea17f500065..959ef9ece4b2 100644 > --- a/lib/librte_eal/common/include/rte_lcore.h > +++ b/lib/librte_eal/common/include/rte_lcore.h > @@ -137,7 +137,7 @@ rte_lcore_index(int lcore_id) > * @return > * the ID of current lcoreid's physical socket > */ > -unsigned rte_socket_id(void); > +unsigned int rte_socket_id(void); > > /** > * Return number of physical sockets detected on the system. > @@ -177,8 +177,8 @@ rte_socket_id_by_idx(unsigned int idx); > * @return > * the ID of lcoreid's physical socket > */ > -static inline unsigned > -rte_lcore_to_socket_id(unsigned lcore_id) > +static inline unsigned int > +rte_lcore_to_socket_id(unsigned int lcore_id) > { > return lcore_config[lcore_id].socket_id; > } > @@ -193,7 +193,7 @@ rte_lcore_to_socket_id(unsigned lcore_id) > * True if the given lcore is enabled; false otherwise. > */ > static inline int > -rte_lcore_is_enabled(unsigned lcore_id) > +rte_lcore_is_enabled(unsigned int lcore_id) > { > struct rte_config *cfg = rte_eal_get_configuration(); > if (lcore_id >= RTE_MAX_LCORE) > @@ -214,8 +214,8 @@ rte_lcore_is_enabled(unsigned lcore_id) > * @return > * The next lcore_id or RTE_MAX_LCORE if not found. > */ > -static inline unsigned > -rte_get_next_lcore(unsigned i, int skip_master, int wrap) > +static inline unsigned int > +rte_get_next_lcore(unsigned int i, int skip_master, int wrap) > { > i++; > if (wrap) > -- > 2.17.1 > > Reviewed-by: David Marchand -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B6C4BA0AC5 for ; Fri, 3 May 2019 09:24:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 038FD29D2; Fri, 3 May 2019 09:24:49 +0200 (CEST) Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 43F302986 for ; Fri, 3 May 2019 09:24:47 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id h17so1160742vke.5 for ; Fri, 03 May 2019 00:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZbyCq1ST4BxXpS70yCi1EU5ZO6LvOoU4HxvQmY+wpYw=; b=R4zU3ZwdEErbKnVMS7f/A3rtjlfytXDS4F8PKrQl7h37HPa7yrxL4IhcL9n8I9KXm6 pexev6HO222RqeYur8M9WVDI7BKy9u1cTd0EzqQdPSvkUG8yArmf9MK3MIsridBh2UNI VQ+iJq5rBTrGLL64qz6ppTgfZjOZD9anFVsuIE6/Z5ikCrQAQx2IdPk4dDfof0TH7L2g eHqq+B//T94uJv67YJUE8nHnsb6bHYJMD9NkkaAOa+PbuLIptLklpNRM/fY/TdLep8ws j70WLEp8ZRn5OdN4OJfLRr13MhC3EH/UcWCJbRA89Np9i+IRhtn1vq2/cJE7/nhaT94e y0rg== X-Gm-Message-State: APjAAAUerKXM3idUkfI4GTPqxq93SNdzmLUqq6tWIRpYxDbKiPrvZDZr JDJMJLA6J10zQeMDAzLuUN2HggkVPqAe0ESbvKjbhw== X-Google-Smtp-Source: APXvYqyDnEuQqCUa9yHW+XLBltQngBFsEF6CtwX+B/c34slfAj7xUZEI5Y770LdurJ7kFLty57iwnm9GKfng61V4C9o= X-Received: by 2002:a1f:c009:: with SMTP id q9mr4530700vkf.85.1556868286714; Fri, 03 May 2019 00:24:46 -0700 (PDT) MIME-Version: 1.0 References: <20190408182510.16078-1-stephen@networkplumber.org> <20190410171603.8979-1-stephen@networkplumber.org> <20190410171603.8979-2-stephen@networkplumber.org> In-Reply-To: <20190410171603.8979-2-stephen@networkplumber.org> From: David Marchand Date: Fri, 3 May 2019 09:24:35 +0200 Message-ID: To: Stephen Hemminger Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: use unsigned int in rte_lcore.h functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503072435.I0jFf_lf2X8tEgRdYAE9bahft6Qzk3WAYWIXka1BLj4@z> On Wed, Apr 10, 2019 at 7:16 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > Purely cosmetic change, use unsigned int instead of unsigned alone. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/include/rte_lcore.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_lcore.h > b/lib/librte_eal/common/include/rte_lcore.h > index dea17f500065..959ef9ece4b2 100644 > --- a/lib/librte_eal/common/include/rte_lcore.h > +++ b/lib/librte_eal/common/include/rte_lcore.h > @@ -137,7 +137,7 @@ rte_lcore_index(int lcore_id) > * @return > * the ID of current lcoreid's physical socket > */ > -unsigned rte_socket_id(void); > +unsigned int rte_socket_id(void); > > /** > * Return number of physical sockets detected on the system. > @@ -177,8 +177,8 @@ rte_socket_id_by_idx(unsigned int idx); > * @return > * the ID of lcoreid's physical socket > */ > -static inline unsigned > -rte_lcore_to_socket_id(unsigned lcore_id) > +static inline unsigned int > +rte_lcore_to_socket_id(unsigned int lcore_id) > { > return lcore_config[lcore_id].socket_id; > } > @@ -193,7 +193,7 @@ rte_lcore_to_socket_id(unsigned lcore_id) > * True if the given lcore is enabled; false otherwise. > */ > static inline int > -rte_lcore_is_enabled(unsigned lcore_id) > +rte_lcore_is_enabled(unsigned int lcore_id) > { > struct rte_config *cfg = rte_eal_get_configuration(); > if (lcore_id >= RTE_MAX_LCORE) > @@ -214,8 +214,8 @@ rte_lcore_is_enabled(unsigned lcore_id) > * @return > * The next lcore_id or RTE_MAX_LCORE if not found. > */ > -static inline unsigned > -rte_get_next_lcore(unsigned i, int skip_master, int wrap) > +static inline unsigned int > +rte_get_next_lcore(unsigned int i, int skip_master, int wrap) > { > i++; > if (wrap) > -- > 2.17.1 > > Reviewed-by: David Marchand -- David Marchand