From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64B67436CE; Tue, 12 Dec 2023 09:01:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA8DB42DEC; Tue, 12 Dec 2023 09:01:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E06CB42DCE for ; Tue, 12 Dec 2023 09:01:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702368095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GsiVWQOVS1FOipg5TyXURQC0ijgLDqUBJ1SlmFkh2w=; b=U5XNbMkV/un+iXWPIVt6Jox0yyHyy9uKF2CGtWlwwxGFA4gnhJz+BlcbRMplLRWVoiS+cs vuhnpoyXJCAVaNZchL0OdcxnuavAbwfc97WimZ3WRUYy9Z3YjDdOn7ZkWbO4CqUYpVO62y Rdi/E+wUfNxcY5tkivebHzdx/zhJKqI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-poNPRDB1OmmiLhndpEJrAg-1; Tue, 12 Dec 2023 03:01:32 -0500 X-MC-Unique: poNPRDB1OmmiLhndpEJrAg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ca30780a02so39706471fa.0 for ; Tue, 12 Dec 2023 00:01:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702368091; x=1702972891; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GsiVWQOVS1FOipg5TyXURQC0ijgLDqUBJ1SlmFkh2w=; b=n/rqy+ltT60AqYwS2r2AgB13nIug21o8eCSphxiq4rJxxuMg05U7UH1WrkHmYwcG59 EySGduJGn/+9chJo7gOCVPz5IOfUxv/7DMACGXMai2hiQVwhXlxcmEquEe43r+EJ6p0v 64zGF0dsR7XJu++q9opFnKgWRK4ydZRxC9ojWq3gCCHyrOKG5p8AwP0agBIpNv7vgB6p C99EWA/kB9yZrKuUKfqjl4AuOToSy87L0INOu/KZ0/exrY1nYa7ta2oeUtzqH4pkwyry af9LGVNIMFFz67GYSJrrGYQVXOtfegl9l9/kkPv8S3TIg/2QSd4WzlJ/TpF8twb2ZVgS 0khg== X-Gm-Message-State: AOJu0Yxo19H0Lm9POZ4kJo0V7pIHshOU+BtfynQdvElErFSSU8KrSliR p+zvjlcrdHiKSdfAwyhiSuPgF6KswA9f5WWvaIzTOAch7OWDiQSdQf8/SJU+67DFwX8TEH/Iafx Zub9UG7RRk0sr/1k1pIk= X-Received: by 2002:a2e:80d8:0:b0:2c9:fbb9:f1bb with SMTP id r24-20020a2e80d8000000b002c9fbb9f1bbmr1055075ljg.135.1702368091554; Tue, 12 Dec 2023 00:01:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWL1fEm5gaadvqrWuH97clkPg/JJhu6pesO5nDy8gn5haUVKDb25JrJlAQ0RaB0U+rdR4izCQUdI3hkjGzy8c= X-Received: by 2002:a2e:80d8:0:b0:2c9:fbb9:f1bb with SMTP id r24-20020a2e80d8000000b002c9fbb9f1bbmr1055070ljg.135.1702368091270; Tue, 12 Dec 2023 00:01:31 -0800 (PST) MIME-Version: 1.0 References: <20231211172437.61958-1-stephen@networkplumber.org> <20231211191931.GB16826@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20231211191931.GB16826@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Tue, 12 Dec 2023 09:01:19 +0100 Message-ID: Subject: Re: [PATCH 0/3] replace use of EAL logtype To: Tyler Retzlaff Cc: Stephen Hemminger , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 11, 2023 at 8:19=E2=80=AFPM Tyler Retzlaff wrote: > > On Mon, Dec 11, 2023 at 09:23:22AM -0800, Stephen Hemminger wrote: > > There are some places EAL logtype is being used in testpmd > > and examples where it should not be. Lets reserve EAL > > logtype to only be used by DPDK internals. > > > > Stephen Hemminger (3): > > testpmd: replace EAL logtype with fprintf > > examples/l2fwd-keepalive: don't use EAL logtype > > examples/vm_power_manager: do not use EAL logtype > > > > app/test-pmd/testpmd.c | 33 +++++++++++--------------------- > > examples/l2fwd-keepalive/shm.c | 21 +++++++------------- > > examples/vm_power_manager/main.c | 11 ++++------- > > are the log types under ALLOW_INTERNAL_API? if not should they be? and > if they are should examples be defining ALLOW_INTERNAL_API? ALLOW_INTERNAL_API and ALLOW_EXPERIMENTAL_API tags have a transitive aspect= . So it would prevent applications from calling inline helpers and macros with such logs in them. Like for example: lib/eal/include/rte_test.h: RTE_LOG(ERR, EAL, "Test assert %s line %d failed: " \ The EAL logtype is "easy" to fix, but others like ETHDEV are more tricky. --=20 David Marchand