[dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic

[dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic

[Joyce Kong]

In stack module, remove the duplicated header file rte_atomic.h
as it has been included in rte_spinlock.h/rte_pause.h

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test/test_stack.c | 1 -
 lib/stack/rte_stack.c | 1 -
 lib/stack/rte_stack.h | 1 -
 3 files changed, 3 deletions(-)

diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 00efb38e2a..bc38961433 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -4,7 +4,6 @@
 
 #include <string.h>
 
-#include <rte_atomic.h>
 #include <rte_lcore.h>
 #include <rte_malloc.h>
 #include <rte_random.h>
diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c
index f1cbb9803f..d3bfc57955 100644
--- a/lib/stack/rte_stack.c
+++ b/lib/stack/rte_stack.c
@@ -5,7 +5,6 @@
 #include <string.h>
 
 #include <rte_string_fns.h>
-#include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_errno.h>
diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h
index 27640f87b2..321f4cec1a 100644
--- a/lib/stack/rte_stack.h
+++ b/lib/stack/rte_stack.h
@@ -19,7 +19,6 @@
 extern "C" {
 #endif
 
-#include <rte_atomic.h>
 #include <rte_compat.h>
 #include <rte_debug.h>
 #include <rte_errno.h>
-- 
2.17.1

Re: [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic

[Olivier Matz]

Hi Joyce,

On Sun, Aug 22, 2021 at 10:20:34PM -0500, Joyce Kong wrote:
> In stack module, remove the duplicated header file rte_atomic.h
> as it has been included in rte_spinlock.h/rte_pause.h
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Sorry for the late feedback.

No objection about the patch itself, but I don't think the commit log
should say that rte_atomic.h is indirectly included by
rte_spinlock.h/rte_pause.h.

To me, it is not a good reason to remove an include. However, it looks
that no function from rte_atomic.h is used in these files, especially
since commit c51e67c2ee18 ("test/stack: remove thread synchronisation")
for the test app.

Thanks,
Olivier

[dpdk-dev] [PATCH v2] stack: remove duplicated include of atomic

[Dharmik Thakkar]

From: Joyce Kong <joyce.kong@arm.com>

In stack module, remove the header file rte_atomic.h
as it is not being used.

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
v2:
  Change commit message (Olivier)

---
 app/test/test_stack.c | 1 -
 lib/stack/rte_stack.c | 1 -
 lib/stack/rte_stack.h | 1 -
 3 files changed, 3 deletions(-)

diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 00efb38e2ab8..bc3896143334 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -4,7 +4,6 @@
 
 #include <string.h>
 
-#include <rte_atomic.h>
 #include <rte_lcore.h>
 #include <rte_malloc.h>
 #include <rte_random.h>
diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c
index 5e56cd9f0cd3..56bf2c8d6d3d 100644
--- a/lib/stack/rte_stack.c
+++ b/lib/stack/rte_stack.c
@@ -6,7 +6,6 @@
 #include <sys/queue.h>
 
 #include <rte_string_fns.h>
-#include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_errno.h>
diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h
index 27640f87b245..321f4cec1a10 100644
--- a/lib/stack/rte_stack.h
+++ b/lib/stack/rte_stack.h
@@ -19,7 +19,6 @@
 extern "C" {
 #endif
 
-#include <rte_atomic.h>
 #include <rte_compat.h>
 #include <rte_debug.h>
 #include <rte_errno.h>
-- 
2.25.1

Re: [dpdk-dev] [PATCH v2] stack: remove duplicated include of atomic

[Olivier Matz]

On Wed, Oct 13, 2021 at 03:48:12PM -0500, Dharmik Thakkar wrote:
> From: Joyce Kong <joyce.kong@arm.com>
> 
> In stack module, remove the header file rte_atomic.h
> as it is not being used.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks

Re: [dpdk-dev] [PATCH v2] stack: remove duplicated include of atomic

[David Marchand]

On Fri, Oct 15, 2021 at 2:59 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Wed, Oct 13, 2021 at 03:48:12PM -0500, Dharmik Thakkar wrote:
> > From: Joyce Kong <joyce.kong@arm.com>
> >
> > In stack module, remove the header file rte_atomic.h
> > as it is not being used.
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks.

-- 
David Marchand