From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 826FCA0A03; Mon, 18 Jan 2021 09:26:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71366140D38; Mon, 18 Jan 2021 09:26:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id F0026140D21 for ; Mon, 18 Jan 2021 09:26:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610958378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rbf71YY1ItR3jLqouuW+ZKcaYkd6cITeoeIBg58+unU=; b=G51JlQ6mj61O0qx6UPRfHa1ftG2r2Zh+Nm/aaI2Rlf8wGgbnshN/Gkv+EleGI07tBLZfIC I49y+NLb3IqiOf/+auBbPMideRNeA8JQATmyWrOXDDBaoBzdmGioTF8ebMxZrAG+Ufgj5I SJUnLTPT6pW87vgIM8nncnkfCSaAXd8= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-8i51myKuOZC7bBnvarJyFQ-1; Mon, 18 Jan 2021 03:26:15 -0500 X-MC-Unique: 8i51myKuOZC7bBnvarJyFQ-1 Received: by mail-vk1-f199.google.com with SMTP id y16so9041698vke.0 for ; Mon, 18 Jan 2021 00:26:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rbf71YY1ItR3jLqouuW+ZKcaYkd6cITeoeIBg58+unU=; b=cCF8DQe03K28/z7lZYKjoKEhw/R3Xhp7NNjQr1helkc5V8GN/KMzSWUzKneJp3nCkx FCXFSIP5yTPyl2VcFO/to8Q8PujtcxhvYOl0Ts3scs0juwtkHvkxkESUTnE3TTMcmE3B Vmhq3w1sBoFWKRmiWyfo2RsFPu3SktyypFbj5Q49Q5XrTMWlOOJVR8nm1YcE8UhvyvbW 4IPw670Lk3turbWA1cixV33ZP9/3dcfot7fj+cfw0YaMg8wwKQgh0DPfN61+5pk6Xcwr lKzbmZrwbYWuD9ks53izig29J68eOfgG522yWtnV7apb1GZ44EgbpHN4LplY9QQat/pc qHlg== X-Gm-Message-State: AOAM532qrFl8/pG4lJ/XarDwNqDqsbVbtUG7X8bl/7+RcEbOfP+mdpUv ALrnsdN4XlmdNET57EPlN5Z2euHOjzRmlcRs2urLzBHmbvaH6NCTND9Kr+Bx7sJEeEsJ6+/YLBm pfV0s3IGVCZucqMHmAmg= X-Received: by 2002:a05:6102:3136:: with SMTP id f22mr16133773vsh.17.1610958375276; Mon, 18 Jan 2021 00:26:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJm+ZTUHVEQWsX28R0d/avfzoQVtKFsuR/2SlFLqvehnEt9GF/PM124b0OIbT67WFInrh0nlxr3NuvNbzFBLk= X-Received: by 2002:a05:6102:3136:: with SMTP id f22mr16133771vsh.17.1610958375098; Mon, 18 Jan 2021 00:26:15 -0800 (PST) MIME-Version: 1.0 References: <9843593ce51003ea5e372a8107a96acdc01e8958.1610712939.git.anatoly.burakov@intel.com> In-Reply-To: <9843593ce51003ea5e372a8107a96acdc01e8958.1610712939.git.anatoly.burakov@intel.com> From: David Marchand Date: Mon, 18 Jan 2021 09:26:04 +0100 Message-ID: To: Anatoly Burakov Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mem: improve parameter checking on memory hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 15, 2021 at 1:15 PM Anatoly Burakov wrote: > > Currently, we don't check anything that comes in through memory hotplug > subsystem using the IPC, because we always assume the data is correct. > This is okay as anyone having access to the IPC socket would also have > rights to crash the DPDK process through other means, but it's still a > good practice to do parameter checking, so fix the code to do that. Intel CI and GHA caught an issue on 32bits builds: https://github.com/ovsrobot/dpdk/runs/1708623050?check_suite_focus=true#step:14:558 -- David Marchand