From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC39E43DA3; Mon, 8 Apr 2024 12:12:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BA0C402E3; Mon, 8 Apr 2024 12:12:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D652C40041 for ; Mon, 8 Apr 2024 12:12:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712571144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tkXYyYJupAOzlDc4zd5SWFwJCcduhYO8bAZ51FLA0nI=; b=CXdbU548kUOIiKEtAw0TjacXZ7aXVUPDUlj37rG+Otn8QfrhpP7qCwzbP/EVimLD1KjbnU 9dlTU0hW0d0JmVre59bAmCpoZLtj0Sw8U+6V5ZKNJWlzzk2LrJGz8NQcVrtFLQSM76xK+g VYLrINDVJjgCJYe6q9qlRyAQ7rbr/f0= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-QlM-kuxENpW8zK4eTqVuKA-1; Mon, 08 Apr 2024 06:12:20 -0400 X-MC-Unique: QlM-kuxENpW8zK4eTqVuKA-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d85ac0ed6fso32063971fa.0 for ; Mon, 08 Apr 2024 03:12:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712571139; x=1713175939; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tkXYyYJupAOzlDc4zd5SWFwJCcduhYO8bAZ51FLA0nI=; b=OGfA7xGNwgxympSS7l3sJJX4QY5wnHtQUlZnosypROzFrIRcWjVVJi6R0baYWS7r2P dPhYxeqaiSfUW3uqUSC2zEzTjvaIq7NQQdzEgrMagP3PnlbRTU2NPURvX5tNlxm+ZakQ ys/g/JTIKarrtGv2Z5YYoQP06NY3+mMhhQByAEFLOPzmCybwsYvpkbiLRDSFcEqBBXmg Ff8QZ3DPFk7ZdW+s9PQ4Pq7OSHXKeAL2uv1Kg3OWlPpZfJPHH/PG14V8Y8YJ1xB02uSK j1w7Bs4eklnw2fwrPw/FpNndA7En2B/weUm4L5p4UEYy3NGfrRbWbL3TTS5Fu9o7bit7 MKmQ== X-Gm-Message-State: AOJu0YzZFJ4gHA0Js7BxLIpvVw4F327qaezIBdgzlOqqh/kWatNMGHoa KXeQXuSGpzUzyMsZBooMv7CQd38crqydk/7bvWrXZBQrB4y5oNNsqsLuz0Ux01MQl25GuE9BXyj ycdZMJJgnbnZ7aoJV7xCBUnXg1oB5D8Q3BS50mniKCxF1ncQ9xUfSzqgPaq0gsr157q+AGD8TmB Nxkvl/SGvkuLeskdA= X-Received: by 2002:a2e:8708:0:b0:2d4:5f50:1fa with SMTP id m8-20020a2e8708000000b002d45f5001famr5651828lji.41.1712571139496; Mon, 08 Apr 2024 03:12:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE71d8kHKyMbIQum03z3c+K9uS1bEVfdwu7XdM4eB1b3LxM9KIEO/25b9j8iOKp63BscGlhUt2fM3HWIvGvIiE= X-Received: by 2002:a2e:8708:0:b0:2d4:5f50:1fa with SMTP id m8-20020a2e8708000000b002d45f5001famr5651801lji.41.1712571139159; Mon, 08 Apr 2024 03:12:19 -0700 (PDT) MIME-Version: 1.0 References: <20240405125039.897933-1-david.marchand@redhat.com> <20240405144604.906695-1-david.marchand@redhat.com> <20240405144604.906695-4-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35E9F36C@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F36C@smartserver.smartshare.dk> From: David Marchand Date: Mon, 8 Apr 2024 12:12:06 +0200 Message-ID: Subject: Re: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org, stable@dpdk.org, Olivier Matz , Jijiang Liu , Andrew Rybchenko , konstantin.ananyev@huawei.com, Ferruh Yigit , Kaiwen Deng , qiming.yang@intel.com, yidingx.zhou@intel.com, Aman Singh , Yuying Zhang , Thomas Monjalon , Jerin Jacob X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 5, 2024 at 6:20=E2=80=AFPM Morten Br=C3=B8rup wrote: > > From: David Marchand [mailto:david.marchand@redhat.com] > > Sent: Friday, 5 April 2024 16.46 > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offload > > examples. > > I strongly disagree with this change! Ok, I will withdraw this patch! Revamping the checksum offload API is a larger work that I don't have time (nor expertise) to work on. If you want to come up with a common API, I can review. Thanks. --=20 David Marchand