From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C303445B38; Mon, 14 Oct 2024 16:15:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C8094027F; Mon, 14 Oct 2024 16:15:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7505940151 for ; Mon, 14 Oct 2024 16:15:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728915313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rvn3xgbP+0ZAtMgZd95Ys8SYrApQKmdLoCWMN684pg4=; b=YbRh3fU0PdHf3X01RlzEOSXcOMnAxhkh/pNL57xNJTKGnzIsMsM69wGpn38es2sQnI8TKN q4aq+jxkst8CahksJTFI157P/swL6VGnS/u1mfrY0crs+WMVdCfMVNmefAyIrmDwiIhbis l4aPpWDwT7Hpg1fDr2xe6RvPVcv1S88= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-WLpoJkt9ME2XcB3tuhjnGA-1; Mon, 14 Oct 2024 10:15:12 -0400 X-MC-Unique: WLpoJkt9ME2XcB3tuhjnGA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-539eaa055feso1225893e87.1 for ; Mon, 14 Oct 2024 07:15:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728915310; x=1729520110; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rvn3xgbP+0ZAtMgZd95Ys8SYrApQKmdLoCWMN684pg4=; b=oagbFL2g/qhEzbs5uQyz/vXDxk53nkdk+yvxEGwEvJoEsRe7ZYAizpGlpfEyI4RZHI HBIsQhkX3kcjkxOeGJN1c2h936BrINRSNxPnDkgvi4M12qhDTU/t2frIyn4A0uS2IPql tKIsd3Wnb2J3e8hHvGyRvwU7ybNJeSJOdFJaQ13U0c6pZ/kGvaaPaL2ZcPbccQzaWRkz kWzOmGuWKetaU1UG3Ln7SAhC9/XvrVuBDEJRlJfimyY4aKVo4xG8xsxRm+wj+qDHLSYw 69EdEsd53rVa5wOE909ByVO9mWDvgCoaOUJeCA6bmImGGhgabcbdeYBM10aTLawsCoIO /Qew== X-Gm-Message-State: AOJu0YwMGOYI8vwwziypCjdfiLWooEwLCKCTMZ6etz/b+yI2m6i+hVR+ g285x/DgqezD9SbPM3I++WqG/rDL1mSWhzk8KFsiDlZsEqWdwZY2yZOR3zY6yfaF2WdQybKaJyb 9tImXWoRyYEBv0q0PFo/40dxsMGEclMLHI6kfGUG6f4mypOBApTRV+PeMLzNgrYUhpVkVSyyZ0u emrLE4u+5pMOw00LM= X-Received: by 2002:a05:6512:e9c:b0:539:f807:ad93 with SMTP id 2adb3069b0e04-539f807caf1mr1531162e87.38.1728915310294; Mon, 14 Oct 2024 07:15:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkwxzqX8XSl7OWQOhX7Sba4strGNy/qT03B4l75swjTBwk/Om9F39wUBzDGP9+8rc7Cl+IGFvCdQtwINBG6Uw= X-Received: by 2002:a05:6512:e9c:b0:539:f807:ad93 with SMTP id 2adb3069b0e04-539f807caf1mr1531141e87.38.1728915309898; Mon, 14 Oct 2024 07:15:09 -0700 (PDT) MIME-Version: 1.0 References: <20241013115719.820853-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20241013115719.820853-1-mattias.ronnblom@ericsson.com> From: David Marchand Date: Mon, 14 Oct 2024 16:14:58 +0200 Message-ID: Subject: Re: [PATCH] bitops: fix issue in parallel atomic tests To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, hofors@lysator.liu.se, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Luka Jankovic , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Oct 13, 2024 at 2:06=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > The macros generating the parallel test for atomic test-and- > [set|clear|flip] functions used a 64-bit reference word when assuring > no neighbouring bits were modified, even when generating code for the > 32-bit version of the test. > > This issue causes spurious test failures on GCC 12.2.0 (the default > compiler on for example Debian 12 "bookworm"), when optimization level > 2 or higher are used. > > The test failures do not occur with GCC 11, 12.3 and 13.2. > > To the author, this looks like a promotion-related compiler bug in GCC > 12.2. > > Fixes: 35326b61aecb ("bitops: add atomic bit operations in new API") > > Signed-off-by: Mattias R=C3=B6nnblom > Reviewed-by: Morten Br=C3=B8rup Tested-by: David Marchand Applied to fix the CI, thanks. --=20 David Marchand