From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id B0D87A057B;
Wed, 1 Apr 2020 08:38:44 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 7F2B51BEAC;
Wed, 1 Apr 2020 08:38:44 +0200 (CEST)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 518951BEAA
for <dev@dpdk.org>; Wed, 1 Apr 2020 08:38:43 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1585723122;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=0UAH3APhE6xTavENIaefgmjIDWhjLcAX9lf2PDOU4mI=;
b=iHJLQrYlhV95It4tbfVQhOBNMSTti1dAxGGsGLmN4Le1Y7SUYi1EJWh2CjQAcMW+JIET9m
6VpMD+1LG/G4sUR3BSXbQ2R8POXmTPpNtc8gvvtt6lytfi1rCKC58v6QFbX7ay/hGCTtAc
TF2mmxaWhEzPEPncqljaC6g5L9RULHk=
Received: from mail-il1-f198.google.com (mail-il1-f198.google.com
[209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-275-YjwA-OZAPgS0UGWfQn6h9g-1; Wed, 01 Apr 2020 02:38:38 -0400
X-MC-Unique: YjwA-OZAPgS0UGWfQn6h9g-1
Received: by mail-il1-f198.google.com with SMTP id b14so22266166ilb.1
for <dev@dpdk.org>; Tue, 31 Mar 2020 23:38:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc:content-transfer-encoding;
bh=0UAH3APhE6xTavENIaefgmjIDWhjLcAX9lf2PDOU4mI=;
b=j/T8PHlGB43WURlVaW7dfjktAW5V6xU+rFAQj6p35jG7QFZn+ddY0uiHBUBMLfY97h
X9VBlNetS3ArhfyYsA3uga+wcSAJGOAqsasuZDz+yJ4Dwi92KqZyJa/ZRtNdfnoIgv9d
nn5fBnsURwmUxePemgOtbZEfJ+FKiBMb73T1IG7Y+QBqMg+EcDLfslkTR+L1pwz4tZZU
JEDt35Yj2X5Vw/xtVIdw2O7tdgxPAxHCg14SJvGvJd1l3RKi2qtaPW+IPLbUr0BG1ahN
ORs9n44u4nZhOpizyudRYoxbnbOZYk9g5AYEhnEN3MwWmVAnL8KcutJeEUGm/pp6JqN7
4Rmg==
X-Gm-Message-State: ANhLgQ1KzHDgFb5B1bU+QzLE2Yf/Gw8Ull0/57dzmhAkAc8pon0b9BKS
nLNks0O3xKlJHOI+kSFSq/XJkHhbSmCEOI0iFcK36WvX53WLTbt9iu568opREcjQra+C2fsePH8
5U9x8SvIK6pBpy9u3s24=
X-Received: by 2002:a6b:8ec2:: with SMTP id
q185mr18590453iod.180.1585723117414;
Tue, 31 Mar 2020 23:38:37 -0700 (PDT)
X-Google-Smtp-Source: ADFU+vvWC5HWzUsjCJ4vKjxt/KDOfNt8aqMRXwV+i026tVO0mQSaOIP7qSDB4cMiA21UbDCLH+V1n9D86ZQB/zXBrNw=
X-Received: by 2002:a6b:8ec2:: with SMTP id
q185mr18590438iod.180.1585723117017;
Tue, 31 Mar 2020 23:38:37 -0700 (PDT)
MIME-Version: 1.0
References: <SN6PR11MB2558241135DA9A3C218F49BD9AC80@SN6PR11MB2558.namprd11.prod.outlook.com>
In-Reply-To: <SN6PR11MB2558241135DA9A3C218F49BD9AC80@SN6PR11MB2558.namprd11.prod.outlook.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 1 Apr 2020 08:38:25 +0200
Message-ID: <CAJFAV8yDOcTmv1H71qXzC1-Y18uXvJhqqJEmT2UuWZHOvoyW8g@mail.gmail.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>, "Yigit,
Ferruh" <ferruh.yigit@intel.com>,
Dodji Seketeli <dodji@redhat.com>, Kevin Laatz <kevin.laatz@intel.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] /validate-abi.sh complains [PATCH v1 3/8] ring:
introduce RTS ring mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, Mar 31, 2020 at 7:05 PM Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
>
> Hi everyone,
>
> Have a question regarding validate-abi.sh.
> It complains on the following changes with that patch:
>
> @@ -111,11 +129,21 @@ struct rte_ring {
> char pad0 __rte_cache_aligned; /**< empty cache line */
>
> /** Ring producer status. */
> - struct rte_ring_headtail prod __rte_cache_aligned;
> + RTE_STD_C11
> + union {
> + struct rte_ring_headtail prod;
> + struct rte_ring_rts_headtail rts_prod;
> + } __rte_cache_aligned;
> +
> char pad1 __rte_cache_aligned; /**< empty cache line */
>
> /** Ring consumer status. */
> - struct rte_ring_headtail cons __rte_cache_aligned;
> + RTE_STD_C11
> + union {
> + struct rte_ring_headtail cons;
> + struct rte_ring_rts_headtail rts_cons;
> + } __rte_cache_aligned;
> +
>
> Complaints:
> rte_ring.h
> [=E2=88=92] struct rte_ring 2
>
> 1
> Change: Field cons has been removed from this type.
> Effect: Applications will access incorrect memory when attempting to a=
ccess this field.
> 2
> Change: Field prod has been removed from this type.
> Effect: Applications will access incorrect memory when attempting to a=
ccess this field.
>
> From my perspective it looks false-positive:
> *prod* and *cons* fields are still there,
> their format, size and offset within rte_ring remain the same.
> Is that some limitation with the tool, or am I missing something here?
- Side note, we have build failures with clang and ARM jobs:
https://travis-ci.com/github/ovsrobot/dpdk/builds/157277423
- We switched to libabigail called from devtools/check-abi.sh which
you can run locally
(https://doc.dpdk.org/guides/contributing/patches.html?highlight=3Dabi#chec=
king-abi-compatibility).
Or you can count on Aaron's robot to do this check in Travis.
It reported a warning on those fields:
https://travis-ci.com/github/ovsrobot/dpdk/jobs/310689008#L2380
I understand this as a false positive too.
It seems similar to the bz I opened about fields moved to anonymous
constructs: https://sourceware.org/bugzilla/show_bug.cgi?id=3D25661
Cc: Dodji.
For the time being, you can waive this by adding a rule in
devtools/libabigail.abignore.
--=20
David Marchand