From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BE23455DA; Tue, 9 Jul 2024 11:25:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43C11402E4; Tue, 9 Jul 2024 11:25:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C991B40156 for ; Tue, 9 Jul 2024 11:25:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720517109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EvkS8vDjcivuJLQrhxgl1HJxUrjO7naMhVV12LK+Feg=; b=dmjW7aJRYmICRpe8LT7rymX+cXZYieXkDp/+zI0uvQ/LdU7h7GwQQMau944R0klXSkDY7j bHt2GQDvD9/1j5pfhrXV6sY78QSJHZlIaYOtYHS6OWf0IZuouAcR4ZNBYBOilXTKDTlvp+ iUvOFIGjrUki7lxZsQFpgublwDOb1/0= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-wO6zDpwoP-24k-Fpx_HFGA-1; Tue, 09 Jul 2024 05:25:05 -0400 X-MC-Unique: wO6zDpwoP-24k-Fpx_HFGA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ee848b2fedso43939981fa.0 for ; Tue, 09 Jul 2024 02:25:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720517103; x=1721121903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EvkS8vDjcivuJLQrhxgl1HJxUrjO7naMhVV12LK+Feg=; b=ajXthMziKeFDDOJ27Q4YaNICkQS5+nVOYj6lqCJUCaGpg6tX4cDJl1+ibXny+kFXGa SpQtnsmmU+0W+jGe699MlhEqOoTP4pZLM+5N9oD59qPJSL0pVFISzi1LxwQmAEVt5u8k Bpl5c7JslsBx53UROL8zn+XjmnfUaB9O5MvDkysqLxcZ2yyIp7Z9tV+e/uA6E5ffeK3O FZbZ+qU2mwfWD1DB3vYS3XJun3pXVIBXL/PBQ83UhpcqLeLnVbDUun3QLOnqHpyfVh4V WMmA7gAm13jgveNkv0yOrNe+3m/qPRiU3JBIeuAm1YgD2IIIegxALH3bl/pBsqQDeYnK G44w== X-Forwarded-Encrypted: i=1; AJvYcCXMSZ20pmum1mn24QcqhIEv2m83mMuMlEk4p1polNCM3dKMoraXcHekMBeQ+NEp0UnCnEzemg3rbhbgJxM= X-Gm-Message-State: AOJu0YxCCpg/+Udj+OA+3r5BC5DyLXzEZADwrFn9+Bpi3oKDOlNtacIM 7SYMbSSpTiWddfO8ccsXT93q4LYN4gSkZxFsYVboG5rcNMwEJc+WsiNhF4nwnz1xV0G+umaIvFu aBoyy5RqLfDAxXrikHdfG8LcwM8xXW9D9QABQrPkxGbyqyTWHwcJcvgJCeryaaUjmVgKRz2beLe LdBwexwULGvv5r/RM= X-Received: by 2002:a2e:a367:0:b0:2ee:7bcd:a3f with SMTP id 38308e7fff4ca-2eeb30eb72amr12800181fa.22.1720517103649; Tue, 09 Jul 2024 02:25:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/m6JlUm38vev2M407A7qF9WURu6Yrgp42IBhOq2VoKv4H+2UnC0gD5CObbbdN9RHS149Mb+0UYnJQdU8tJew= X-Received: by 2002:a2e:a367:0:b0:2ee:7bcd:a3f with SMTP id 38308e7fff4ca-2eeb30eb72amr12799991fa.22.1720517103310; Tue, 09 Jul 2024 02:25:03 -0700 (PDT) MIME-Version: 1.0 References: <20240302234812.9137-1-mb@smartsharesystems.com> <20240530154100.25811-1-mb@smartsharesystems.com> <99e4a1ac2166451dab7033e2181a0821@huawei.com> In-Reply-To: <99e4a1ac2166451dab7033e2181a0821@huawei.com> From: David Marchand Date: Tue, 9 Jul 2024 11:24:51 +0200 Message-ID: Subject: Re: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Konstantin Ananyev , "bruce.richardson@intel.com" , "konstantin.v.ananyev@yandex.ru" , "stephen@networkplumber.org" , "roretzla@linux.microsoft.com" , "mattias.ronnblom@ericsson.com" , "aconole@redhat.com" , "dev@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 10, 2024 at 3:40=E2=80=AFPM Konstantin Ananyev wrote: > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > > In the case where the size is known to be 16 at build time, omit the > > duplicate copy. > > > > Reduced the amount of effectively copy-pasted code by using #ifdef > > inside functions instead of outside functions. > > > > Suggested-by: Stephen Hemminger > > Signed-off-by: Morten Br=C3=B8rup > > Acked-by: Bruce Richardson > Acked-by: Konstantin Ananyev Applied, thanks for the cleanup. --=20 David Marchand