From: David Marchand <david.marchand@redhat.com>
To: Stanislaw Kardach <kda@semihalf.com>
Cc: dev <dev@dpdk.org>,
upstream@semihalf.com, Aaron Conole <aconole@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion
Date: Wed, 15 Jun 2022 09:25:50 +0200 [thread overview]
Message-ID: <CAJFAV8yDTyLG8hGR+X2x0Yp9g=L91ZuaxaseNbg=CpUBm7FoAQ@mail.gmail.com> (raw)
In-Reply-To: <20220609121701.716299-1-kda@semihalf.com>
On Thu, Jun 9, 2022 at 2:17 PM Stanislaw Kardach <kda@semihalf.com> wrote:
>
> As David noticed in [1] there is an issue with C++ compilation of the
> rte_vect.h header in RISC-V. Upon closer inspection, the problem appears on
> all architectures due to the type conversion rules in C++.
> More precisely a union type rte_xmm_t requires a conversion constructor
> from xmm_t type.
> The most obvious fix is to use a structure initializer for such copies
> (since rte_xmm_t union contains xmm_t anyway). The generated assembly
> at -O2 is exactly the same, so there's no real impact.
>
> The bigger question is whether accessing bits of the architecture specific
> xmm_t type in an array fashion is always correct? All current architectures
> define rte_xmm_t in the same manner implying that.
Copying other arch maintainers.
>
> Additionally change RISC-V CI settings to use crossbuild-essential-riscv64
> package which provides tools that enable C++ checks.
>
> [1] http://mails.dpdk.org/archives/dev/2022-June/243683.html
>
> Stanislaw Kardach (3):
> eal/riscv: fix xmm_t casting for C++
> lpm: fix xmm_t casting for C++ in scalar version
> ci: use crossbuild-essential-riscv64 for compiling
In any case, this series looks good.
Series applied, thanks Stanislaw.
--
David Marchand
next prev parent reply other threads:[~2022-06-15 7:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 12:16 Stanislaw Kardach
2022-06-09 12:16 ` [PATCH 1/3] eal/riscv: fix xmm_t casting for C++ Stanislaw Kardach
2022-06-13 9:29 ` David Marchand
2022-06-09 12:17 ` [PATCH 2/3] lpm: fix xmm_t casting for C++ in scalar version Stanislaw Kardach
2022-06-13 9:29 ` David Marchand
2022-06-09 12:17 ` [PATCH 3/3] ci: use crossbuild-essential-riscv64 for compiling Stanislaw Kardach
2022-06-13 9:29 ` David Marchand
2022-06-14 12:31 ` Aaron Conole
2022-06-15 7:25 ` David Marchand [this message]
2022-06-20 22:54 ` [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion David Christensen
2022-06-21 9:30 ` Stanisław Kardach
2022-06-21 9:38 ` Bruce Richardson
2022-06-21 9:42 ` Stanisław Kardach
2022-06-21 9:49 ` Bruce Richardson
2022-06-21 10:22 ` Thomas Monjalon
2022-06-21 11:05 ` Stanisław Kardach
2022-06-21 11:53 ` Thomas Monjalon
2022-06-21 12:37 ` Stanisław Kardach
2022-06-21 14:20 ` Bruce Richardson
2022-06-21 19:48 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yDTyLG8hGR+X2x0Yp9g=L91ZuaxaseNbg=CpUBm7FoAQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=jerinj@marvell.com \
--cc=kda@semihalf.com \
--cc=konstantin.ananyev@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).