From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5161A0548; Wed, 15 Jun 2022 09:26:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B2E840221; Wed, 15 Jun 2022 09:26:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5091940220 for ; Wed, 15 Jun 2022 09:26:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655277964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9A+rfN70XGe6bbwowCDDmhLhWWt8yckgukb+WrzcRk=; b=CwJW0NOHkSTs3GsCCdgLCzhVa72kZpDL+LDlFFV5vPtKHapypXp4AwRtA0PYxSZIv0qZl6 yh+o29RdnOkWfmcnX1ierD178lyIeFkCJS3qM6By8/liAT1+1YSnyeKMJ5cryvXkw9rDZ2 SU/w4lbIvaEr3UuC2HvFNOsUWj6qt8E= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-VDOjqNHFMXGTaEuwamyTNw-1; Wed, 15 Jun 2022 03:26:03 -0400 X-MC-Unique: VDOjqNHFMXGTaEuwamyTNw-1 Received: by mail-lj1-f199.google.com with SMTP id b40-20020a05651c0b2800b002555cc8cef4so1557377ljr.16 for ; Wed, 15 Jun 2022 00:26:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v9A+rfN70XGe6bbwowCDDmhLhWWt8yckgukb+WrzcRk=; b=xLFO2GFctRXVKGrQYZGTGuaUj0JdeAU4oDVg84KJTXmwO0bJRGbf66Ydo3a1ODXVth PMVSkTdZ8y9u4OgN6ihwfaLFSWkIGsm2nONPkLC2K41W78pE5m7d0MNAxXLGmyTauIhs QBcuLIgtdYlcCS61/jaMgRs6Vh4PFUZdtLtLSL4iJcDd8SkVSBM5THkGTLLpVGvHHmQm rfFSVruNRisKQmQrCIGVM7w7ajTTQ/3w1IIcJVVoTw+4vjlC93TdSAyAsT9dfh1EXKIm ndTdRu7ov+fdYGvT7jlira/x4YsAIseZ5Z8K1gJjosvewD9410rdrSgSupzBarOxxOWx CgoA== X-Gm-Message-State: AJIora/vP6PsF7FxKykNCNKNglHVY4DYSLTahGKC6EyJ/NwljWUdWxy5 EGgj9V76M9J+RkfJC7PIoHc6ccdZV+dGysDU9F9ih2z9Ajwmvliu6Ke9ArrAu8Ppi41kbeVOQ4s KwoB/lOTNzPw6fxqTXls= X-Received: by 2002:a05:6512:b8b:b0:479:3e3b:9699 with SMTP id b11-20020a0565120b8b00b004793e3b9699mr5239669lfv.217.1655277962107; Wed, 15 Jun 2022 00:26:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s5bGgTLJ5YHf7BkndTM3Ru5ekyhe1d+uZf3oBHnpdaTi+CKc1/RugpyUUEqLsiB/+bMMgsC9LfyZDIO6kQPqE= X-Received: by 2002:a05:6512:b8b:b0:479:3e3b:9699 with SMTP id b11-20020a0565120b8b00b004793e3b9699mr5239659lfv.217.1655277961882; Wed, 15 Jun 2022 00:26:01 -0700 (PDT) MIME-Version: 1.0 References: <20220609121701.716299-1-kda@semihalf.com> In-Reply-To: <20220609121701.716299-1-kda@semihalf.com> From: David Marchand Date: Wed, 15 Jun 2022 09:25:50 +0200 Message-ID: Subject: Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion To: Stanislaw Kardach Cc: dev , upstream@semihalf.com, Aaron Conole , Bruce Richardson , "Ananyev, Konstantin" , "Ruifeng Wang (Arm Technology China)" , Jerin Jacob Kollanukkaran , David Christensen Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 9, 2022 at 2:17 PM Stanislaw Kardach wrote: > > As David noticed in [1] there is an issue with C++ compilation of the > rte_vect.h header in RISC-V. Upon closer inspection, the problem appears on > all architectures due to the type conversion rules in C++. > More precisely a union type rte_xmm_t requires a conversion constructor > from xmm_t type. > The most obvious fix is to use a structure initializer for such copies > (since rte_xmm_t union contains xmm_t anyway). The generated assembly > at -O2 is exactly the same, so there's no real impact. > > The bigger question is whether accessing bits of the architecture specific > xmm_t type in an array fashion is always correct? All current architectures > define rte_xmm_t in the same manner implying that. Copying other arch maintainers. > > Additionally change RISC-V CI settings to use crossbuild-essential-riscv64 > package which provides tools that enable C++ checks. > > [1] http://mails.dpdk.org/archives/dev/2022-June/243683.html > > Stanislaw Kardach (3): > eal/riscv: fix xmm_t casting for C++ > lpm: fix xmm_t casting for C++ in scalar version > ci: use crossbuild-essential-riscv64 for compiling In any case, this series looks good. Series applied, thanks Stanislaw. -- David Marchand