From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA0DAA0032; Wed, 11 May 2022 09:28:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B471C410F2; Wed, 11 May 2022 09:28:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1AE7C40042 for ; Wed, 11 May 2022 09:28:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652254092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LVGHZUgfmMkNaeuv0fI5sWhQzHai4dUkFSww2wazD9c=; b=aaMwLRZOEd91AnKLL8fAFxX8nfETC/KHEOvniQdr9YTztR4ZLuYmaGf3RUNEFfoWN0ka4U PkWPAbWIi0Syh2BJphVkNo1VXl7kRadiQn5b/yFhMY8gt6jyLOzZMFUjsySPkFRskT0eAO LDF7uCKyUcokMPyMpH6qToQ9dmb+jWA= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-Ex6yAAC-OGm34HnLwvxCKA-1; Wed, 11 May 2022 03:28:11 -0400 X-MC-Unique: Ex6yAAC-OGm34HnLwvxCKA-1 Received: by mail-lf1-f72.google.com with SMTP id l19-20020ac24313000000b004739dbba717so482034lfh.5 for ; Wed, 11 May 2022 00:28:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LVGHZUgfmMkNaeuv0fI5sWhQzHai4dUkFSww2wazD9c=; b=QLrSmXVNA7kVbiErmkieeSXMzsfNB+b969+Tij5Z9yvR1qrkpCtY9CNbg0cAm3A4JC hWC79uNCcHDhB/+gxzAdldj8WesyY6T178td9r+/2HAGtw/wntAyUFjD5pEyelC6Fhah y1jzb49ES3AcPHt17NqpwBfdzGrNAHEvUBDAYcUOWK4uB7DoSZUS1m6ATBcz9nR7ygdn bFpNXnHw2HkIRCKGzLr/meFcLGTgxv+5coCdxLvLcCPNUmUuzHYrLpwb/J4zPgaTr5ZU HZH6XytI7VpgPl010w+SxqTlA5zUidbmMOGjma+cAlg0gxMnYftSWMP2csRrDsXh1TPo clCA== X-Gm-Message-State: AOAM530vU9pnO1mics5dFXO8SyV2zcYzqFVN9TjmqJ3gF5DNG6JXooGU ZH+O4B2GpLGIooneFgbzzFXJlBVIU9lV3syhAihIoEUSzD9W5EtbYUfj+7UqbmmAlq1yfl08ufV 1bpzvIxz5SWpUQ9Fvl+4= X-Received: by 2002:a05:6512:baa:b0:472:5ec9:f625 with SMTP id b42-20020a0565120baa00b004725ec9f625mr18725667lfv.560.1652254089897; Wed, 11 May 2022 00:28:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB+RPYF7aDZ6HQrzIOR+6jgihNGhgumQNbCFVVYJDcSYSIw3LWclfMcWWWdHm6MuL7yPYPh9iE8qs7ulWTSFI= X-Received: by 2002:a05:6512:baa:b0:472:5ec9:f625 with SMTP id b42-20020a0565120baa00b004725ec9f625mr18725653lfv.560.1652254089693; Wed, 11 May 2022 00:28:09 -0700 (PDT) MIME-Version: 1.0 References: <20220511013705.24602-1-wenwux.ma@intel.com> In-Reply-To: <20220511013705.24602-1-wenwux.ma@intel.com> From: David Marchand Date: Wed, 11 May 2022 09:27:58 +0200 Message-ID: Subject: Re: [PATCH] app/testpmd: perform SW IP checksum for GRO packets To: Wenwu Ma Cc: Xiaoyun Li , "Singh, Aman Deep" , Yuying Zhang , dev , Jiayu Hu , "Wang, Yinan" , xingguang.he@intel.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 11, 2022 at 3:40 AM Wenwu Ma wrote: > > The GRO library doesn't re-calculate checksums for > merged packets. If users want the merged packets to > have correct IP checksums, they should select HW IP > checksum calculation for the port which the merged > packets are transmitted to. But if the port doesn't > support HW IP checksum, users may perform a SW IP > checksum. This patch add the code about it. It looks like a fix, please add a Fixes: line. Out of curiosity, would there be an issue too when using the gso library? > > Signed-off-by: Wenwu Ma -- David Marchand