From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5093B42D2E; Fri, 23 Jun 2023 11:35:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D794242C4D; Fri, 23 Jun 2023 11:35:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3380C40EE4 for ; Fri, 23 Jun 2023 11:35:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687512947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CNcwhww/AR4+qaYXdfFhSU8FpjI3sEco9um0DwDRRes=; b=K8MVcExzUZuDCufCMH7ejMV91DenCrmKtMZCs4sHpB7RrFlROFrSkynoNoJx8+ykEd81Pl InwxqZHHC7Wht6MS67yl2m5Pzu26naFJjA/3zIYpulwj4Cqhi7U2uAEGft9zYshn+eHiuH K/kyzCPDuNXqhfhGfw+zyaXC8TZevho= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-p5Haz8e8N9CIAnvfJUuCog-1; Fri, 23 Jun 2023 05:35:41 -0400 X-MC-Unique: p5Haz8e8N9CIAnvfJUuCog-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-25e803def73so348316a91.1 for ; Fri, 23 Jun 2023 02:35:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687512940; x=1690104940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CNcwhww/AR4+qaYXdfFhSU8FpjI3sEco9um0DwDRRes=; b=RgsVZogoi6s0qvd0O1TXNtYIe+eNoKqOpmehmQ1FcWaifJXBQsfMiSorkqBcNbd+Ly YJqZ67gT3WZoRanaOl2PqGKEPZyg2CHHDzAuCFZ6qXZdGB5ehFgCv4+HFw4H3ExOBwRP FiH/57Z9mHPh4HdmV2p0Ycl8NYvHUyP15tti7O7IJ9Mho5Uv4iAA6HtRKTUexVYPXOBC 33rHtMlcUv7+Neo5sSe1yYr3OhkSnMwPnf4SYDX7+y4XKb9dQh4RxhSAJb4Sv8nIc94x /xdcltDyiRUME6GqPkVkPpY7WxmmVAhs/GiHy6AM7ACgUeYtH7rDfavZ54pj1IDauYAh gWOQ== X-Gm-Message-State: AC+VfDzOpuySvEbuSEOnHK9SQPTEUFgorwFb2Oz2sNqD0H1bSWsR/vjy aYxoIzg3AUBjtOF+v+YguSUNN43GulTkds86vzaq4joGJ/9La5K9jjt9HAV+ag8yQu7yawGmTRj IRa1E0HOR6MB1FIpe/VM= X-Received: by 2002:a17:903:22cd:b0:1b6:6f12:502e with SMTP id y13-20020a17090322cd00b001b66f12502emr14240162plg.49.1687512940582; Fri, 23 Jun 2023 02:35:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Cs4Cbv/nl0x/HEDdeMGc9YQEOpppFOBYgK2/ObQiaHNWvhWPc/zCiXalmiUmbyz8gwrBIOI80plANj5R/V54= X-Received: by 2002:a17:903:22cd:b0:1b6:6f12:502e with SMTP id y13-20020a17090322cd00b001b66f12502emr14240155plg.49.1687512940348; Fri, 23 Jun 2023 02:35:40 -0700 (PDT) MIME-Version: 1.0 References: <20211117112847.7362-6-david.marchand@redhat.com> <20230621170058.2740340-1-david.marchand@redhat.com> <20230621170058.2740340-4-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 23 Jun 2023 11:35:29 +0200 Message-ID: Subject: Re: [PATCH v4 3/4] build: select deprecated libraries To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, bluca@debian.org, tredaelli@redhat.com, i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr, Aaron Conole , Michael Santana X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Bruce, On Thu, Jun 22, 2023 at 10:43=E2=80=AFAM Bruce Richardson wrote: > > On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > > Rework deprecated libraries selection by introducing a new configuratio= n > > option. > > > > This breaks existing configurations that were relying on disable_libs= =3D'' > > for enabling deprecated libraries. > > On the other hand, it will make enabling optional libraries more > > straightforward by taking the deprecated libraries out of the picture. > > > > Signed-off-by: David Marchand > > This gives us a single on/off value for the deprecated libs. So if you > wants to build only a single deprecated lib, you need to turn on this > option and then use "disable_libs/enable_libs" option to then selectively > pick which of the deprecated libs you actually want. Is that the expected > behaviour? Just checking that we don't want this to be a list too. Yes, I wanted a single unified filtering stage. But I think your suggestion is easier to use. - That would make it simpler for people who simply want to enable kni, as you mentionned before: $ meson setup plop -Denable_deprecated_libs=3Dkni But I would make this list not overlap with the disable/enable_libs options evaluation. Otherwise, in the case of a enable_libs user, the user would have to set kni in both lists, which is not that great: $ meson setup plop -Denable_deprecated_libs=3Dkni -Denable_libs=3Dkni,vhost Instead, I would make it so the config is done as: $ meson setup plop -Denable_deprecated_libs=3Dkni -Denable_libs=3Dvhost Is this what you had in mind? - I don't have a usage for this, but if we go with separating deprecated and "normal" optional libs filtering, should I introduce a disable_deprecated_libs too? --=20 David Marchand