From: David Marchand <david.marchand@redhat.com>
To: "Power, Ciara" <ciara.power@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"mb@smartsharesystems.com" <mb@smartsharesystems.com>
Subject: Re: [PATCH] telemetry: support boolean type
Date: Thu, 20 Oct 2022 13:48:26 +0200 [thread overview]
Message-ID: <CAJFAV8yEGL-57fRhr-pys28GN_D4711cuCRD24h3dsCVvP+XLA@mail.gmail.com> (raw)
In-Reply-To: <MN2PR11MB38219EC23535B8A303B6F749E62A9@MN2PR11MB3821.namprd11.prod.outlook.com>
Hello Ciara,
On Thu, Oct 20, 2022 at 11:54 AM Power, Ciara <ciara.power@intel.com> wrote:
> This is a nice addition to the library.
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Wednesday 19 October 2022 08:37
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>;
> > mb@smartsharesystems.com; Power, Ciara <ciara.power@intel.com>
> > Subject: [PATCH] telemetry: support boolean type
> >
> > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and dicts.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > app/test/test_telemetry_data.c | 88 +++++++++++++++++++++++++++++++++-
> > lib/telemetry/rte_telemetry.h | 36 ++++++++++++++
> > lib/telemetry/telemetry.c | 24 +++++++++-
> > lib/telemetry/telemetry_data.c | 44 +++++++++++++++--
> > lib/telemetry/telemetry_data.h | 5 ++ lib/telemetry/telemetry_json.h | 34
> <snip>
>
> Acked-by: Ciara Power <ciara.power@intel.com>
Thank you.
Fyi, I'll respin this patch to fix Bruce comments.
I will send it as preparation for the trace telemetry additions.
--
David Marchand
prev parent reply other threads:[~2022-10-20 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 7:37 David Marchand
2022-10-19 8:13 ` Morten Brørup
2022-10-19 13:47 ` Bruce Richardson
2022-10-19 14:18 ` Morten Brørup
2022-10-19 14:28 ` David Marchand
2022-10-19 16:47 ` Bruce Richardson
2022-10-19 18:08 ` Morten Brørup
2022-10-20 9:54 ` Power, Ciara
2022-10-20 11:48 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yEGL-57fRhr-pys28GN_D4711cuCRD24h3dsCVvP+XLA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).