From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F9FEA00C2; Wed, 30 Nov 2022 09:27:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE1E040A7F; Wed, 30 Nov 2022 09:27:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B202D40151 for ; Wed, 30 Nov 2022 09:27:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669796842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ijJb+uXl7N9Uar2c2IOq8FZ5XwH4KDx8JqngWF+XrBQ=; b=L+9EHdcI0GjsbUHyuKPrlD0VPQ9lQutEoWH2EZ8JCWUEfjIzaokDWt65wEq3897v80/aLv z9aMxUWwHRaFkt+tyW8o0hCu0l/N4hAQDVykZqgNz61i4gpEs6P+XRWZApQwEFGYR7XH+A nky7HG3lZO3GBMrIoz1smHnqJfjuEyA= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-199-jZsOau5lNmyPJLvtzavaCA-1; Wed, 30 Nov 2022 03:27:21 -0500 X-MC-Unique: jZsOau5lNmyPJLvtzavaCA-1 Received: by mail-pj1-f71.google.com with SMTP id m2-20020a17090a730200b0021020cce6adso1596228pjk.3 for ; Wed, 30 Nov 2022 00:27:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ijJb+uXl7N9Uar2c2IOq8FZ5XwH4KDx8JqngWF+XrBQ=; b=7F85vyUkBDmQvdyxZN2PEG0BnT3jsA1b38FBmglGPDZLIHWsgyIddht6YH78EK1BkU skWUPmwDrkueDIZqgrSd4Jx+9aLLKXTkhOAM8VR+wB7nrI/y1nzbA2I08E3O0Z9wP5rU xMsFibPQbug5zMkNYaQo3NFCkERKdMFJ9Hj8wtimH/1qWw/V2B3vDDJq3bJy4zoJtUvZ +CF4X8b+yKJnuq/ki8aB9HYBQQrcdPShcfChYt8Ji4a/8pNba17EI5GgjkmbCa3aeR8L 2oelSUz9k/W4S/pUi7aKSrYM+5+Dpwpbi7DAT+PdCe8BfoR3v/faa4rkbTAXJ9NHJeKm k4uQ== X-Gm-Message-State: ANoB5pkW+/0PfHJgVm1dSeB5zgvLaDuViKgvNSp678VE9FKM0AIqarVI jjYSMBDto5Owt64SMkndX5tStWy2YSMp/0hfmkBGbUVnEdNRDGSKz8mGqHCcUNNNSy/kdoIyux4 BBESVLzLIuZlv7t4ug1s= X-Received: by 2002:a05:6a00:24c1:b0:56e:a001:8cb0 with SMTP id d1-20020a056a0024c100b0056ea0018cb0mr42247096pfv.60.1669796840289; Wed, 30 Nov 2022 00:27:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf6cr1YN8pVYIP4ITV3kum2kaLr62kO6k1SliWbr0zCtWWmvIhGxPaRpcuqAO3iGT5iVBVaHLpLQ/CGMG0MCJsQ= X-Received: by 2002:a05:6a00:24c1:b0:56e:a001:8cb0 with SMTP id d1-20020a056a0024c100b0056ea0018cb0mr42247075pfv.60.1669796840005; Wed, 30 Nov 2022 00:27:20 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 30 Nov 2022 09:27:08 +0100 Message-ID: Subject: Re: [PATCH] drivers: fix symbol exports when map is omitted To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, Luca Boccassi , Bruce Richardson , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 30, 2022 at 8:13 AM David Marchand wrote: > > I assume this will cause warnings for ABI check scripts, how can we > > prevent the warnings? > > Indeed. > > Some options: > - add exhaustive suppression rules in devtools/libabigail.abignore, > - retag the v22.11 release with this fix, but we already announced it > and people started downloading the tarball, > - release a .1 version and compare ABI against it (either in the main > repo, or in the 22.11 stable branch, through for the ABI check in GHA, > it would be simpler to have the tag in the main repo..), (let's forget about my concern on GHA, we have the REF_GIT_REPO param, so we can point at the dpdk-stable repo, and go with a "normal" release in 22.11 stable branch) > > Do you have other ideas? > -- David Marchand