From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BEF9A0562; Tue, 31 Mar 2020 13:13:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32D422B8B; Tue, 31 Mar 2020 13:13:50 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 90AF03B5 for ; Tue, 31 Mar 2020 13:13:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585653229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ttdKVhcPRd957xfsNHxHsglaNCZOkgQz9hIcI9a2P8=; b=fdbhIelkegdcBt3iV+nOCFnbRIByXv2YTeT0YBtTK8qCYu8GJb4Ta1wk8I8DPmU2Hlqie6 VciDKZfWuOhg7axZYJ0d+hkqDsfUu7aNgPzjQF22ev15FUBw/4s8hnLmAs1M2WJ0ewzjlM 2rqQZ80QbotGQdTrF5MaOcSJUesuE2w= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-P4IZXj_oO_2HwsKQ3JTiyg-1; Tue, 31 Mar 2020 07:13:45 -0400 X-MC-Unique: P4IZXj_oO_2HwsKQ3JTiyg-1 Received: by mail-vs1-f69.google.com with SMTP id t27so5078720vsj.0 for ; Tue, 31 Mar 2020 04:13:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5aPa9lJ363ACrFuRLgZEPGQT5lgPkyQq6an2sLdPP3c=; b=WkzIu0Q0SqI2VvWhNI8ybqegw9L/F9tJJL9ax3Gyv6ipjD6OiWHBHcaAJvP6ErtHcw nmnl4teznIvQqBqOPxBWRThlfhZhoSD9iTwUSKuI0m8TM9MqCMqjLPetZIUCnkcTXj6v P2yIH2y+rCXvguRNqWF6MsiqqAROuJ3nkhbJ0V3WbrP84wz2cYG2kEXUK9kEeNUBU+Gq +hpJ8583Jq/CliI4h0qIHGlXrGSLLPA3ooJhcVzoKCns3va76qXcjIsUqFtePnDsJ/LQ jCiW5MQICxtGQYD8aeyoTFBCrqiripkmSMhKuwpmFZ1t8cKHGxCx++9iss9gUzd89keO v6nw== X-Gm-Message-State: AGi0PuYF8Cf5fmwQbyjH7TKNlydSzEuiFJTUHv2rmDkJDmrtVs+X7eoi XPZKiPtaCjKWzsjBVWH5f3kdNJ+JFHkiqD1IYXCoj9Zv9Wm/88Xr0/h8/75MdVLbCLUFs54h8oZ 2PtWrYr4aSEVhY3VAhk8= X-Received: by 2002:a67:69d8:: with SMTP id e207mr12106825vsc.141.1585653224671; Tue, 31 Mar 2020 04:13:44 -0700 (PDT) X-Google-Smtp-Source: APiQypItdBbswYTRhDUi6ZdbQ+aburK4acinA9YhyOy5pHGpMWEDDYKOloMvEj8oY6s0fptAH/QyJKPEm5NynLaeopc= X-Received: by 2002:a67:69d8:: with SMTP id e207mr12106807vsc.141.1585653224313; Tue, 31 Mar 2020 04:13:44 -0700 (PDT) MIME-Version: 1.0 References: <20200320001220.150235-1-thomas@monjalon.net> <20200327011540.954014-1-thomas@monjalon.net> In-Reply-To: From: David Marchand Date: Tue, 31 Mar 2020 13:13:33 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Stephen Hemminger , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 0/8] eal: reorganize directories layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 30, 2020 at 4:22 PM David Marchand wrote: > On Fri, Mar 27, 2020 at 2:16 AM Thomas Monjalon wro= te: > > > > Some clean-up is done in EAL sub-directories. > > The goal is to make organization easier to understand, > > and to prepare moving some files from common to Unix-only place. > > > > Since the kernel modules are moved to kernel/ directory, > > there is no need anymore for the sub-directory eal/ in > > linux/, freebsd/ and windows/. > > > > The EAL API (with doxygen documentation) is moved from > > common/include/ to include/, which makes more clear that > > it is the global API for all environments and architectures. > > Note that the arch-specific and OS-specific include files are not > > in this global include directory, but include/generic/ should > > cover the doxygen documentation for them. > > > > The arch-specific directories arm, ppc_64 and x86 in common/arch/ > > and in common/include/arch are moved at the same level as the > > OS-specific directories, adding an include/ sub-directory. > > It makes more clear that EAL is covering a matrix combining OS and arch= . > > Note that ppc_64 is renamed to ppc. > > > > These moves offer the opportunity to simplify the make and meson files. > > > > > > This change was proposed to the Technical Board in advance: > > http://mails.dpdk.org/archives/dev/2020-January/156732.html > > I caught an issue on patch 6 that breaks headers installation with > meson (caught this by compiling examples against an installed dpdk). > This issue is fixed by patch 7. > So it is only a matter of fixing compilation when bisecting. > I proposed a fix in reply to patch 6, which I intend to squash in when ap= plying. > > > I did not validate all patches individually with make, as I get build > errors on missing headers with parallel compilation quite easily. > But those errors are transient afaiu: with a clean build directory no pro= blem. > > > For the series: > Acked-by: David Marchand Series applied with change in patch 6. --=20 David Marchand