From: David Marchand <david.marchand@redhat.com>
To: Ariel Otilibili-Anieli <otilibil@eurecom.fr>
Cc: Robin Jarry <rjarry@redhat.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/1] buildtools: clear out regex syntax warnings
Date: Fri, 13 Dec 2024 15:15:38 +0100 [thread overview]
Message-ID: <CAJFAV8yEaWSX2kdiANWuKx7zsvTEnrVoVjnZAOQ_ocdzM8ZTAw@mail.gmail.com> (raw)
In-Reply-To: <2f7a87-675c4080-be09-141f3260@213168101>
On Fri, Dec 13, 2024 at 3:11 PM Ariel Otilibili-Anieli
<otilibil@eurecom.fr> wrote:
>
> On Friday, December 13, 2024 15:07 CET, "Robin Jarry" <rjarry@redhat.com> wrote:
>
> > Ariel Otilibili, Dec 08, 2024 at 03:25:
> > > * invalid escape sequences now generate SyntaxWarning
> > > * therefore changed syntax to raw string noration.
> > >
> > > Link: https://docs.python.org/3/library/re.html#module-re
> > > Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> >
> > Hi Ariel, thanks for the fix!
> >
> > Acked-by: Robin Jarry <rjarry@redhat.com>
>
> Awesome, Robin!
> >
> > If you have time, I there are other bits that would need the same fix:
> >
> > buildtools/get-numa-count.py:14: numa_nodes.sort(key=lambda l: int(re.findall('\d+', l)[0]))
> > devtools/check-meson.py:54: if re.match('^ *\t', code):
> > doc/api/generate_doxygen.py:8:pattern = re.compile('^Preprocessing (.*)...$')
> >
>
> Good, then; I'll push them in a subsequent series.
Those fixes are little one-liners worth backporting.
Please add a Fixes: tag identifying the commit introducing the issue,
then Cc: stable@dpdk.org.
If you need more details on what is expected, see
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
and https://doc.dpdk.org/guides/contributing/patches.html#patch-for-stable-releases
--
David Marchand
next prev parent reply other threads:[~2024-12-13 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 2:25 [PATCH 0/1] " Ariel Otilibili
2024-12-08 2:25 ` [PATCH 1/1] " Ariel Otilibili
2024-12-13 14:07 ` Robin Jarry
2024-12-13 14:11 ` Ariel Otilibili-Anieli
2024-12-13 14:15 ` David Marchand [this message]
2024-12-13 14:40 ` [PATCH v2 0/1] " Ariel Otilibili
2024-12-13 14:40 ` [PATCH v2 1/1] " Ariel Otilibili
2024-12-13 16:41 ` Robin Jarry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yEaWSX2kdiANWuKx7zsvTEnrVoVjnZAOQ_ocdzM8ZTAw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=otilibil@eurecom.fr \
--cc=rjarry@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).