From: David Marchand <david.marchand@redhat.com>
To: zhang.yong25@zte.com.cn
Cc: dev@dpdk.org
Subject: Re: raw/zxdh: introduce zxdh raw device driver
Date: Tue, 9 Jul 2024 09:52:57 +0200 [thread overview]
Message-ID: <CAJFAV8yF3T8dUkbnBOs8wfR3foXrFOD=+LZTt+DjGYVGOknUQQ@mail.gmail.com> (raw)
In-Reply-To: <202407091430583513KWtIU86wZpFC0Fh-sDB4@zte.com.cn>
Hello,
On Tue, Jul 9, 2024 at 8:31 AM <zhang.yong25@zte.com.cn> wrote:
>
> I have made some changes as suggested. Is there anything else that needs to be changed?
This new patch can't be tested by the CI, because it does not make
sense individually and there is no reference to the patch introducing
the new driver.
It does not make sense to apply a first patch with a vdev driver to
change it after as a pci driver.
Please rework this driver as a pci driver from the start.
Besides, this new driver code is a bit large, please split it into
parts that can be more easily reviewed, adding documentation in each
patch (when relevant) and update the release notes.
As to how to split, I suggest you look at the git history for existing
raw/cnxk* drivers.
To be franck, seeing how this driver comes so late in the release and
because we don't have reviews, this driver will certainly be deferred
to the next release.
Thanks.
--
David Marchand
prev parent reply other threads:[~2024-07-09 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 11:00 zhang.yong25
2024-06-12 11:28 ` David Marchand
2024-07-09 6:30 ` zhang.yong25
2024-07-09 7:52 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yF3T8dUkbnBOs8wfR3foXrFOD=+LZTt+DjGYVGOknUQQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=zhang.yong25@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).