From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96787A10DA for ; Thu, 1 Aug 2019 15:24:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 774C31C1ED; Thu, 1 Aug 2019 15:24:47 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id DA7181C1DB for ; Thu, 1 Aug 2019 15:24:45 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id k8so144311320iot.1 for ; Thu, 01 Aug 2019 06:24:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TtI6531ULjymYb3j3+dTWzMFHsIlAKjyZlLm5nWR4eI=; b=W8IUIJLIYHEXZ5H2mzkJYUfsRFaf6YSQih/UtH8VSPM7buAolNM8YLNBjGp2pz9YHt BBJNzPaYXaHPZZQHLk+zH4YQVL8sx9nBVIYh+ZSvI+vWnaRhN8+5MgC0nCESX8l0Fhdu eIZExs4aJzHY/uuEsr8fPmwMcWkAkpJbCxC2PXmRShQY7MC9uLYfpaaR9t8WcEHQ0pc8 mguo1MGa+sptjJVSpQ9thxz6KFnq0mu9JIhfeqZMKNLdxxz+bJDkFnOq6Ls1Cwg99dfX HB693O9jQny0HTj2600gBqxn3r4oRcLMfDmmI1cn2FSU/VW0S0SnWTQ8LpzadUqsDvB1 1QFA== X-Gm-Message-State: APjAAAWYFwelvRLG6NVMmuN8eFDrv+Anj/aWgLC7sq/cM9iJlRMSo5jb HR/frvk3QdvDjHwDia4F/sU9oLFDMNp0S0uyZGokosiM X-Google-Smtp-Source: APXvYqzmfNmWhqDbMBDU5ckxou+W1pdR6VIAzvfGd7kOVqbvbi6gVlOoXKFBFdHKYweOc0SoSxYzMAOhb0RKvTw+jio= X-Received: by 2002:a02:862b:: with SMTP id e40mr48862001jai.7.1564665885210; Thu, 01 Aug 2019 06:24:45 -0700 (PDT) MIME-Version: 1.0 References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> <20190801132201.ty75yrktxep6ei3k@bidouze.vm.6wind.com> In-Reply-To: <20190801132201.ty75yrktxep6ei3k@bidouze.vm.6wind.com> From: David Marchand Date: Thu, 1 Aug 2019 15:24:34 +0200 Message-ID: To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= Cc: dev , Aaron Conole , Michael Santana Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hey Ga=C3=ABtan, On Thu, Aug 1, 2019 at 3:22 PM Ga=C3=ABtan Rivet w= rote: > > On Thu, Aug 01, 2019 at 02:29:21PM +0200, David Marchand wrote: > > On Thu, Aug 1, 2019 at 2:28 PM David Marchand wrote: > > > > > > The memory tests currently check that, for normal mode (not legacy mo= de), > > > there is no memory left behind when exiting. > > > > > > The problem is that if a ethdev port is allocated when scanning pci > > > devices (even if the driver probe fails like when you have a virtio > > > management interface attached to the kernel), on exit, dpdk won't fre= e > > > the associated memory since ethdev never frees the ethdev memzone. > > > > > > Workaround this by disabling pci scan. > > > > Not entirely happy with this patch. > > I am open to suggestions :-) > > >> Why not cleanup on .fini the ethdev subsystem? I had this in mind, tried it quickly, but it still failed. So I suppose .fini is executed after rte_eal_cleanup (where the freeing of the hugepages happens). --=20 David Marchand