Re: [PATCH] lib: remove duplicate prefix in logs

[David Marchand <david.marchand@redhat.com>]

On Wed, Jan 24, 2024 at 1:17 PM Morten Brørup <mb@smartsharesystems.com> wrote:
> > diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
> > index 5953a77bd6..dbaa14f262 100644
> > --- a/lib/dmadev/rte_dmadev.c
> > +++ b/lib/dmadev/rte_dmadev.c
> > @@ -35,8 +35,7 @@ RTE_LOG_REGISTER_DEFAULT(rte_dma_logtype, INFO);
> >  #define RTE_LOGTYPE_DMA rte_dma_logtype
> >
> >  #define RTE_DMA_LOG(level, ...) \
> > -     RTE_LOG_LINE(level, DMA, RTE_FMT("dma: " RTE_FMT_HEAD(__VA_ARGS__
> > ,), \
> > -             RTE_FMT_TAIL(__VA_ARGS__ ,)))
> > +     RTE_LOG_LINE(level, DMA, "" __VA_ARGS__)
> >
> >  int
> >  rte_dma_dev_max(size_t dev_max)
> > diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c
> > index de8291151f..1c2011b856 100644
> > --- a/lib/gpudev/gpudev.c
> > +++ b/lib/gpudev/gpudev.c
> > @@ -20,8 +20,7 @@ RTE_LOG_REGISTER_DEFAULT(gpu_logtype, NOTICE);
> >  #define RTE_LOGTYPE_GPUDEV gpu_logtype
> >
> >  #define GPU_LOG(level, ...) \
> > -     RTE_LOG_LINE(level, GPUDEV, RTE_FMT("gpu: "
> > RTE_FMT_HEAD(__VA_ARGS__ ,), \
> > -             RTE_FMT_TAIL(__VA_ARGS__ ,)))
> > +     RTE_LOG_LINE(level, GPUDEV, "" __VA_ARGS__)
>
> Suggestion:
> GPUDEV -> GPU, like DMA, not DMADEV.

I had not checked before, but for consistency, I would go the other way around.

$ for dir in lib/*dev; do git grep RTE_LOG_LINE $dir; done
lib/bbdev/rte_bbdev.c:  RTE_LOG_LINE(level, BBDEV, "" __VA_ARGS__)
lib/compressdev/rte_compressdev_internal.h:     RTE_LOG_LINE(level,
COMPRESSDEV, "%s(): " fmt, __func__, ## args)
lib/cryptodev/rte_cryptodev.h:  RTE_LOG_LINE(ERR, CRYPTODEV, \
lib/cryptodev/rte_cryptodev.h:  RTE_LOG_LINE(INFO, CRYPTODEV, "" __VA_ARGS__)
lib/cryptodev/rte_cryptodev.h:  RTE_LOG_LINE(DEBUG, CRYPTODEV, \
lib/cryptodev/rte_cryptodev.h:  RTE_LOG_LINE(DEBUG, CRYPTODEV, \
lib/dmadev/rte_dmadev.c:        RTE_LOG_LINE(level, DMA, "" __VA_ARGS__)
lib/ethdev/rte_ethdev.h:        RTE_LOG_LINE(level, ETHDEV, "" __VA_ARGS__)
lib/eventdev/eventdev_pmd.h:    RTE_LOG_LINE(ERR, EVENTDEV, \
lib/eventdev/eventdev_pmd.h:    RTE_LOG_LINE(DEBUG, EVENTDEV, \
lib/eventdev/rte_event_timer_adapter.c: RTE_LOG_LINE(level, logtype, \
lib/gpudev/gpudev.c:    RTE_LOG_LINE(level, GPUDEV, "" __VA_ARGS__)
lib/mldev/rte_mldev.h:  RTE_LOG_LINE(level, MLDEV, "%s(): " fmt,
__func__, ##args)
lib/rawdev/rte_rawdev_pmd.h:    RTE_LOG_LINE(level, RAWDEV, "%s(): "
fmt, __func__, ##args)
lib/regexdev/rte_regexdev.h:    RTE_LOG_LINE(level, REGEXDEV, "" __VA_ARGS__)


-- 
David Marchand