From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F010E4240D; Wed, 18 Jan 2023 12:49:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AFAE4067E; Wed, 18 Jan 2023 12:49:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F22724003F for ; Wed, 18 Jan 2023 12:49:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674042584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ifCAuIfXhMIM5PF20Rp4CFWJE1lsl9oKXOiSzmOFuwI=; b=RPqrXUKw8FZQsvM6ZV59rXYk5lel/Go+U+PFVv2JrltqV4/0q0kGa7rWtJzbasQXf9+2tX JYvTYNS3TSnqlbuJ+BSYhwp8zTLZILa8ap1G+ALD+HQC+oU5ahE44cr3/lksA88dQow8Gf DczmdDz7r98QPN98/CfchDHlUabH5C4= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-154-8_Qc9ASOPYGno5QojaqHSA-1; Wed, 18 Jan 2023 06:49:42 -0500 X-MC-Unique: 8_Qc9ASOPYGno5QojaqHSA-1 Received: by mail-pl1-f197.google.com with SMTP id b9-20020a170903228900b00194a0110d7bso3889459plh.6 for ; Wed, 18 Jan 2023 03:49:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ifCAuIfXhMIM5PF20Rp4CFWJE1lsl9oKXOiSzmOFuwI=; b=HdwwBU5N5duDj8pMILQHVeoiM7AZ5UGex6yxQRQPRG4HOkLfpEE2yETF25ljefiOpa z9TLaa74zrmFflMlFooOLAkOp0Rq9p+DPyZk8stjsruBWtpb/8DV+zoE7c7my+Dt5BT2 +OX3qBzr1d8LuJocSj3O0vEtz0vGlg4GHd6udOxgZ9PZ8x81/Kz98tMXEGkenOmB1Q4h HplX+MVJnREZ74s2YAtRZ9u3wAj4zIRdM3rxd/5Q1qC65xQamiFBhjjnivdaDypizhSR 5/yZdUNAHUuEIbkRC8M03DZ+7eluKSuuk08gp1jmWF71K1QBZV0VVG1gLb9LvJaDYtj5 PW7Q== X-Gm-Message-State: AFqh2krL3zlFA0RP/BjOgKi+0jefoJzKVRkQ77eKcRCideKFj7xTfteu xDQgduEbeIXLPPvuQA+z/MIpK/cdXrHU2v5e5PvKbmEWeFSDt8PN8Yaz8bUmxSt95K5z62guS8/ xWijmN4EnaDF37lVjgYI= X-Received: by 2002:a17:902:d703:b0:193:102d:861f with SMTP id w3-20020a170902d70300b00193102d861fmr627474ply.51.1674042581571; Wed, 18 Jan 2023 03:49:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXusKRiPf+27ik9FLEzuQWqU4MGZUVrTiCIopwz8sSICr+YMjtihj7tX+WlcuhjlUS6hmD90N3zqWX2p63RINFM= X-Received: by 2002:a17:902:d703:b0:193:102d:861f with SMTP id w3-20020a170902d70300b00193102d861fmr627469ply.51.1674042581253; Wed, 18 Jan 2023 03:49:41 -0800 (PST) MIME-Version: 1.0 References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1673979709-8613-1-git-send-email-roretzla@linux.microsoft.com> <1673979709-8613-5-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1673979709-8613-5-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 18 Jan 2023 12:49:29 +0100 Message-ID: Subject: Re: [PATCH v5 4/4] eal: deprecate rte thread setname API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, mb@smartsharesystems.com, jerinjacobk@gmail.com, techboard@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 17, 2023 at 7:21 PM Tyler Retzlaff wrote: > > Notify deprecation of rte_thread_setname API, it is being removed as it > exposes platform-specific thread details. The functionality it provided > is now implicitly provided via the rte_lcore_set_name API if the > underlying platform supports it. > > Signed-off-by: Tyler Retzlaff I counted one ack from Morten. With mine (for the notice part, see comment below), that makes two. Acked-by: David Marchand We need one more ack (Cc: techboard, hoping that some kind member will ack). > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > lib/eal/include/rte_lcore.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index e18ac34..2990bb1 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -126,3 +126,7 @@ Deprecation Notices > Its removal has been postponed to let potential users report interest > in maintaining it. > In the absence of such interest, this library will be removed in DPDK 23.11. > + > +* eal: The function ``rte_thread_setname`` will be removed, continuing > + the effort to decouple EAL from platform-specific thread > + implementations. > diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h > index 9c78650..2fb3091 100644 > --- a/lib/eal/include/rte_lcore.h > +++ b/lib/eal/include/rte_lcore.h > @@ -13,6 +13,7 @@ > */ > #include > > +#include > #include > #include > #include > @@ -349,6 +350,7 @@ enum rte_lcore_role_t { > * @return > * On success, return 0; otherwise return a negative value. > */ > +__rte_deprecated > int rte_thread_setname(pthread_t id, const char *name); However, this part should be removed and postponed to when rte_thread_set_name is marked stable. As long as the set_name new symbol is experimental, we can't mark as deprecated as users would be left with no stable API. -- David Marchand