From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 576D4A0527; Wed, 25 Nov 2020 10:10:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24E11C952; Wed, 25 Nov 2020 10:10:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 02DD2C940 for ; Wed, 25 Nov 2020 10:10:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606295425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nqT0dQw4vbOuSuBzED4AFHTyUsPg4xmulpCTO/B8les=; b=PhX4cCt04o3mhifrrvT+CBn5Dj/QEoT/SIUNerZz3py3dlI3gqDH/Gz3lMQ/h11CRwVfhv J5KdzGGN0XLJyl1CzDgDEsmNHsYTDh3gw9Mcq3nS9+nK108Ct8B1Z6/+41K6gCDs/XGAch Ipxm0YwtWv8CHfd9wvzr7KIuoXGA1wQ= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-452-_US9B58mNZaAwv_p6kT8qw-1; Wed, 25 Nov 2020 04:10:22 -0500 X-MC-Unique: _US9B58mNZaAwv_p6kT8qw-1 Received: by mail-vk1-f198.google.com with SMTP id v3so199390vkn.19 for ; Wed, 25 Nov 2020 01:10:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nqT0dQw4vbOuSuBzED4AFHTyUsPg4xmulpCTO/B8les=; b=HN1ezQI2gMJ2OOO9nS4qsiF3hxrKhQrN9ZJwEyx5r9anwtEBWfA3IsKUjKHP/G8gcW YSlnZzsMFoobL2t+MOUqGTqPmeUQB7xo4p6ygs0GvYJMwDzCDsEuXF+0OVgOGvZb5fAD 7/kux3JphDU3F7taEwRursYUjzUCUtFEJ/LTT17FONzLyxBbRkVBTZB6QkDrIAqATrpy ATV+7z8F77bmnfcyizFbxUgRjd6nVNmM/QxSA7x4i9iPrgrnTC+Zf8b422IGc4QOb3be wn07eNCTjY5P2ey1sIQvG0OqhsCmIrbJssrYhZ1IS1v7tV8vOhPAuipqE4swfj58U1S2 66WQ== X-Gm-Message-State: AOAM532saUoq99EZdEnYCqfuYyTwvchg48mLftaDAJR+O82pwWbj9VFz IE+uerMlwwIrzwRUKCmQkBdW6ef3c39s3rryqiOte56e7xL/0DjznanFIjbqx8Jz5XhpBOOgZLJ VhAwhklBc/eeEyG05mEg= X-Received: by 2002:ab0:2e9:: with SMTP id 96mr1071969uah.87.1606295421984; Wed, 25 Nov 2020 01:10:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJymIyyx9De3whK0zdsFuo5ZiOeXUkoTU44jLhV+q25o7nNJHDLR84vyLFYKVqJoBLdXo/LVv112+KmP/4JJNTA= X-Received: by 2002:ab0:2e9:: with SMTP id 96mr1071963uah.87.1606295421773; Wed, 25 Nov 2020 01:10:21 -0800 (PST) MIME-Version: 1.0 References: <1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com> In-Reply-To: <1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com> From: David Marchand Date: Wed, 25 Nov 2020 10:10:10 +0100 Message-ID: To: Timothy Redaelli Cc: Anatoly Burakov , Bruce Richardson , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal: fix shared lib mode detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 24, 2020 at 4:15 PM Timothy Redaelli wrote: > > Commit 06c7871dde01 ("eal: restrict default plugin path to shared lib mode") > introduced a check that enabled shared lib mode when librte_eal.so can > be loaded, but it can't work, at least, on Fedora/CentOS/RHEL since .so > symlinks are not installed when you install dpdk package, but only when > you install dpdk-devel package. > > This commit uses librte_eal.so.ABI_VERSION to check for shared lib, > since it exists on any linux distributions. > > See Fedora Packaging Guidelines for more informations: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages > > Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode") > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli Same comment as Bruce on the != NULL location, but otherwise lgtm. Acked-by: David Marchand -- David Marchand