From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 123CCA04DD; Thu, 22 Oct 2020 22:06:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0FA15A9B; Thu, 22 Oct 2020 22:06:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 75D625A95 for ; Thu, 22 Oct 2020 22:06:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603397205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xU6x0qDXPLNNNAOB9lJNfT25gjfp/lVeUM3BhA0K9ao=; b=QemuCmVPAXw16pLmpQDHgOB9jWjRb0LAjJ3y1LE5sLXr0ogo9zndPJOSih/dHp1KpU5XUH kzqXkFYrUK2qiAA4Va65RhfNYVMx6OHJgUljUw6boHrJsoShLYqYBnwynMvIMb2TW6rGh7 RKc4qLW5u5xyjgRXvqFlOA15SPkqQzQ= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-EB9DSHVLM-2ihDQgDBXkIA-1; Thu, 22 Oct 2020 16:06:41 -0400 X-MC-Unique: EB9DSHVLM-2ihDQgDBXkIA-1 Received: by mail-ua1-f69.google.com with SMTP id k5so371030uag.1 for ; Thu, 22 Oct 2020 13:06:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xU6x0qDXPLNNNAOB9lJNfT25gjfp/lVeUM3BhA0K9ao=; b=kOPxQ2dLSGa/Az/AI5ldjtKwhLr6YyfsEY43/RnORhTZBijBEDJbgztZpeNaB/zYtT IFNONMAh4RIwwDVP9IZF2EnDlqElvJwqgNDtoNwV7sFI2V4SvagfyLRItxVqbhWdA3dI pYMcF6Ysq1BoaRx85+X4SkBer0laaqBrM0TWGyNKut/rxvYEE1babfnjc9XSqN6q2wCa lsiABBDfkKyAzaiR8N9OxEV9P8EcbgpUv2JKVbGTWCdW/0uVTZljaoTk6NdY/M5+OlUg qZheLFfJmSpihDEp4T6QRhHdRC5l1wHDb0tkLUj6u/fTeBfDVajjwHHYH4ZLuH3HzyNO zOqQ== X-Gm-Message-State: AOAM531jJeXgwdXiKnss9r84WwwTtlIPA1TwgvN3XgXY8Ve01yV3+GXS hcTUwxKe22K92QiSq385CAhkhtKPtTxYlzXveskXJYHcYAygHMKHjp8TZS6/LbXsusdpHO7s1+X FoZ2B8p0oLf9gRTX2xHE= X-Received: by 2002:ab0:784d:: with SMTP id y13mr1829532uaq.86.1603397201432; Thu, 22 Oct 2020 13:06:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJws6OJeUF2f21knNyZs/h/9ojSkXB+nVrJb20Lr30dkZ6uictqf7sVNMoWmg2NSWY/AQxQpvMXKPo0EJ/DcqCo= X-Received: by 2002:ab0:784d:: with SMTP id y13mr1829503uaq.86.1603397201169; Thu, 22 Oct 2020 13:06:41 -0700 (PDT) MIME-Version: 1.0 References: <49d4bdc58b81564788cfd31f16ef2e66c1673f6d.1601347917.git.wangyunjian@huawei.com> In-Reply-To: <49d4bdc58b81564788cfd31f16ef2e66c1673f6d.1601347917.git.wangyunjian@huawei.com> From: David Marchand Date: Thu, 22 Oct 2020 22:06:30 +0200 Message-ID: To: wangyunjian Cc: dev , Byron Marohn , "Wang, Yipeng1" , "Lilijun (Jerry)" , xudingke , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] efd: fix tailq entry leak in error path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 29, 2020 at 5:32 AM wangyunjian wrote: > > From: Yunjian Wang > > In rte_efd_create() allocated memory for tailq entry, we should > free it when error happens, otherwise it will lead to memory leak. > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Acked-by: Yipeng Wang Applied, thanks. -- David Marchand