From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BD7CA0A02; Wed, 24 Mar 2021 12:15:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A148D40683; Wed, 24 Mar 2021 12:15:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 01A0A4067B for ; Wed, 24 Mar 2021 12:15:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616584513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T+bELhbgMmgQQGGnq7nENJD7BupQOFdUOnTuRjOFkqs=; b=CSaK7pwxmQrNAqKG4jNrr7bAa2/mzFWUqz1NXQuw9ibZ0p1MjTMvpcM6gXonWJ2d0nFPt3 c4/ESn0BQRQDHGdjjxR+NqmFiMUo8wI0fQvNyTq+pWhxUdmsywp0FvG8Cw/KH504J4Yycs 4l43M8b5l1ReIiakrnMHtMbAStnnP7s= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-510-dBt2aaq-Ohu7ofZK2RnZPw-1; Wed, 24 Mar 2021 07:15:11 -0400 X-MC-Unique: dBt2aaq-Ohu7ofZK2RnZPw-1 Received: by mail-vs1-f70.google.com with SMTP id k12so507982vso.2 for ; Wed, 24 Mar 2021 04:15:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T+bELhbgMmgQQGGnq7nENJD7BupQOFdUOnTuRjOFkqs=; b=Pfi6u7dN2DI/LLY4XNpYIdLaXJtbH/+Ewsqlt1pFqhCpjsVYVK2Z1GMaYwagvn9000 H7kSxDAcRyOGWBq0zf/yWFvkycYf/XZVYFdI7jsITNsZ+9xuRrhiRej61zvGmoUi9NbO 8f6/vN3OZTPbXAWynz/0H3l6CCWlENst1mYkxSC88BqGeVEtJ+tWriBguadRsB49qGMn VVDnI6iS6fUel2oVms1I0ELJNleusKLGf7Bj16giA/QM4lrFEdHStSFhyHKk8K6LNy/W LENCxr0d6iYh9EbawLwVYC58mCxMxTboIK0MbuesEJ4s4fKbFWn26buiRCKxdNlKltC3 EFvQ== X-Gm-Message-State: AOAM530UJujG0A8BzBLU2GJ6PAwPX1PUjxh+fUtrIUxepZe1pfPFhsiT U91DLYYR+oepfUUvRoz5cGgEpMw1f2Nu3abR0hP2luklmP78Dla0kishK5M51ka9RU+FSg7+K4j RvM0HW3xLko241diTGlc= X-Received: by 2002:a05:6102:a84:: with SMTP id n4mr1108413vsg.18.1616584511183; Wed, 24 Mar 2021 04:15:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgYij/6cOs2j1/v6EjF/aeaThqScLaGZ6g+G7CH9uUuPN0lfLVP47oI18vW+ZAurvTXsU3RJnu9G7NcwfNfes= X-Received: by 2002:a05:6102:a84:: with SMTP id n4mr1108402vsg.18.1616584510995; Wed, 24 Mar 2021 04:15:10 -0700 (PDT) MIME-Version: 1.0 References: <20210225190112.2073-1-pbhagavatula@marvell.com> In-Reply-To: From: David Marchand Date: Wed, 24 Mar 2021 12:14:59 +0100 Message-ID: To: Jerin Jacob , Pavan Nikhilesh , Harman Kalra Cc: Thomas Monjalon , Jerin Jacob , Bruce Richardson , dpdk-dev , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 24, 2021 at 12:01 PM Jerin Jacob wrote: > > On Fri, Feb 26, 2021 at 12:31 AM wrote: > > > > From: Pavan Nikhilesh > > > > Make RTE_MAX_RXTX_INTR_VEC_ID configurable as MSI-X support a > > maximum of 2048 vectors. > > The default value is unchanged and set to 512. > > > IMO, We dont need to make it configurable and each platform sets its > value. That scheme won't work as generic distribution build will fail > to run. > Since PCIe specification defines this value and there is no > performance impact on increasing this, > IMO, We can change to 2048 as default. It probably breaks rte_intr_* ABI. struct rte_intr_handle { ... int efds[RTE_MAX_RXTX_INTR_VEC_ID]; /**< intr vectors/efds mapping */ struct rte_epoll_event elist[RTE_MAX_RXTX_INTR_VEC_ID]; /**< intr vector epoll event */ ... I see you need this for octeontx2, so wondering if you could handle this differently in octeontx2 drivers? -- David Marchand