From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8BC7A0C4C; Tue, 5 Oct 2021 16:31:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 917F2412D0; Tue, 5 Oct 2021 16:31:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D8066410DC for ; Tue, 5 Oct 2021 16:31:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633444299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dSes2t8NfSTSHfBug26adaRGMiwi4HaV0c0lGw9wW6Y=; b=TEwg2iiFQkqElsygD9G+ExfXejfhqs9h86VMX1wczIvyUQUgvHri5myCpMDFefkyybmDuZ myIpDBb/KhxPuynkIflYfRKvDZpphZ9plIkHmA3Du2idD3tvKRN8L8YM83U9msNnJRw4rn qjlfRL4xCgGSoOiXD891CSYVNLYpglY= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-wlbkW6gyOf6Sgd_OVm60fw-1; Tue, 05 Oct 2021 10:31:36 -0400 X-MC-Unique: wlbkW6gyOf6Sgd_OVm60fw-1 Received: by mail-lf1-f72.google.com with SMTP id j16-20020a056512399000b003fd4bec03beso675946lfu.17 for ; Tue, 05 Oct 2021 07:31:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dSes2t8NfSTSHfBug26adaRGMiwi4HaV0c0lGw9wW6Y=; b=Z76KRu7y78CYlMftsbq2x8l7iZaO/aiPTdT5g/I4X+vcydpbfEBbX+3EIUc7DK3RQJ xKE8z/OgnwicHcN+rzKm1vBurA9juO4tIGfhDdVPX0nyoHt9GbjXgnCffrXCHqA1X1yS vLGMHZ7gFrdw5oXHk5iew4huOPOV4Ev41YIfuNODBwoMhQh3kZsu3PP22kAjsucHGY3J NtHpUGCTgpuAZLpvas//5R/g0ZuwHavrqd3oRottMtuNcJ4fm2cFj5UVKLsb7/CWgs80 PfIUAM6k1/Iu+A1jISPO+5I0kW0YUlS2uDzO8taNJ/L9tADCdddbA2cZztF8kjEEL7y4 SKAg== X-Gm-Message-State: AOAM533MLahPi2jZJCLcaTZGYobtRE6tmtex5lC3Z6Tyq4Iu22dfmZbe yxF7BpziS0mC5sUo1QVwBorFO8s3hw2py1TUDaIDDrr8P25mz1edZ/zqtZ0ZGoBewFYfKM5/+oW pjMb44LY2TePb00vu6MU= X-Received: by 2002:a05:6512:3f16:: with SMTP id y22mr3807679lfa.499.1633444294935; Tue, 05 Oct 2021 07:31:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvgSCqw2z8zNVUn0+MNSLLTMCMyUsAOmX+YPbM8qsDXZjKAybeW+wyg3y//wXK2krcRB4ui/wTeP8TgVC1TK0= X-Received: by 2002:a05:6512:3f16:: with SMTP id y22mr3807659lfa.499.1633444294720; Tue, 05 Oct 2021 07:31:34 -0700 (PDT) MIME-Version: 1.0 References: <20211005091626.31885-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 5 Oct 2021 16:31:23 +0200 Message-ID: To: "Kinsella, Ray" Cc: dev , Thomas Monjalon , "Yigit, Ferruh" , Jasvinder Singh , Cristian Dumitrescu , Vladimir Medvedkin , Conor Walsh , Stephen Hemminger Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] sort symbols map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 5, 2021 at 4:17 PM Kinsella, Ray wrote: > On 05/10/2021 10:16, David Marchand wrote: > > Fixed with ./devtools/update-abi.sh $(cat ABI_VERSION) > > > > Fixes: e73a7ab22422 ("net/softnic: promote manage API") > > Fixes: 8f532a34c4f2 ("fib: promote API to stable") > > Fixes: 4aeb92396b85 ("rib: promote API to stable") > > > > Signed-off-by: David Marchand > > --- > > I added "./devtools/update-abi.sh $(cat ABI_VERSION)" to my checks. > > > > I should have caught it when merging fib and rib patches... > > But my eyes (or more likely brain) stopped at net/softnic bits. > > > > What do you think? > > Should I wait a bit more and send a global patch to catch any missed > > sorting just before rc1? > > > > In the meantime, if you merge .map updates, try to remember to run the > > command above. > > > > Thanks. > > --- > > drivers/net/softnic/version.map | 2 +- > > lib/fib/version.map | 21 ++++++++++----------- > > lib/rib/version.map | 33 ++++++++++++++++----------------- > > 3 files changed, 27 insertions(+), 29 deletions(-) > > > > Something to add to the Symbol Bot also, maybe? The committed maps should have no issue in the first place. The best place would probably be in checkpatches.sh so that developers get the warning before even posting and so that maintainers fix the issues before pushing. But it requires checked out sources. -- David Marchand