From: David Marchand <david.marchand@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "Wang, YuanX" <yuanx.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Ling, WeiX" <weix.ling@intel.com>,
jin.liu@corigine.com, louis.peens@corigine.com,
peng.zhang@corigine.com,
Heinrich Kuhn <heinrich.kuhn@corigine.com>
Subject: Re: [PATCH v2] examples/vhost: fix retry logic on eth rx path
Date: Mon, 20 Jun 2022 09:36:10 +0200 [thread overview]
Message-ID: <CAJFAV8yJ08F0uHFHjBCfq2NYWTVPdu5jWbcCQ1WHV1scRGcokA@mail.gmail.com> (raw)
In-Reply-To: <SN6PR11MB350476A5D97F8BBBBE1B90929CB09@SN6PR11MB3504.namprd11.prod.outlook.com>
On Mon, Jun 20, 2022 at 5:20 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> > drain_eth_rx() uses rte_vhost_avail_entries() to calculate
> > the available entries to determine if a retry is required.
> > However, this function only works with split rings, and
> > calculating packed rings will return the wrong value and cause
> > unnecessary retries resulting in a significant performance penalty.
> >
> > This patch fix that by using the difference between tx/rx burst
> > as the retry condition.
>
> Does it mean we don't need the API rte_vhost_avail_entries() anymore?
>
> Jiayu/Yuan/Maxime, what do you think?
FWIW, I still see a user:
virtio-forwarder/virtio_vhostuser.c: * This check ensures that we
do not call rte_vhost_avail_entries
virtio-forwarder/virtio_worker.c: try_rcv =
rte_vhost_avail_entries((int)relay->vio.vio_dev,
Cc'd a few Corigine guys.
--
David Marchand
next prev parent reply other threads:[~2022-06-20 7:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 16:25 [PATCH] examples/vhost: Fix retry logic on Rx Yuan Wang
2022-05-26 9:30 ` Ling, WeiX
2022-06-17 7:01 ` [PATCH v2] examples/vhost: fix retry logic on eth rx path Yuan Wang
2022-06-20 3:20 ` Xia, Chenbo
2022-06-20 7:36 ` David Marchand [this message]
2022-06-20 7:49 ` Xia, Chenbo
2022-06-20 8:59 ` Hu, Jiayu
2022-06-20 9:09 ` Xia, Chenbo
2022-06-20 9:19 ` Wang, YuanX
2022-06-20 9:33 ` Xia, Chenbo
2022-06-20 9:42 ` Hu, Jiayu
2022-06-21 13:34 ` Xia, Chenbo
2022-06-22 2:26 ` Wang, YuanX
2022-06-22 6:27 ` [PATCH v3] " Yuan Wang
2022-06-22 7:23 ` Maxime Coquelin
2022-06-22 8:50 ` Wang, YuanX
2022-06-22 9:25 ` [PATCH v4] " Yuan Wang
2022-06-23 2:57 ` Xia, Chenbo
2022-06-23 7:20 ` Ling, WeiX
2022-07-01 13:57 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yJ08F0uHFHjBCfq2NYWTVPdu5jWbcCQ1WHV1scRGcokA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=heinrich.kuhn@corigine.com \
--cc=jiayu.hu@intel.com \
--cc=jin.liu@corigine.com \
--cc=louis.peens@corigine.com \
--cc=maxime.coquelin@redhat.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
--cc=weix.ling@intel.com \
--cc=xingguang.he@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).