From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 891E7A00BE; Tue, 28 Apr 2020 10:52:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 627891D58C; Tue, 28 Apr 2020 10:52:20 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 262461D588 for ; Tue, 28 Apr 2020 10:52:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588063938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=//Rz/r5YcbzjQ/qsheosEFWXsiOoDrvcN8ZsfEl/6Ro=; b=KtmmgCG06IWHaokV9y9rtsrbvz9Ve+Jk85rr2g35CgX6KA2plIcIMguZuhL0gAPiOEIl5/ O+THOJN4LnrUV9IwDWWYJmYD/5nQkMFX2vZerp/znDk8sAd9kCXdW5ULbcQpUX5CcCGp19 LvkoFndSe7Pi9NwC+2LcKzq+gwYe5cU= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-GFH82V8kPvuO5pZ1Zb3qNw-1; Tue, 28 Apr 2020 04:52:14 -0400 X-MC-Unique: GFH82V8kPvuO5pZ1Zb3qNw-1 Received: by mail-vk1-f197.google.com with SMTP id 68so10554188vkx.22 for ; Tue, 28 Apr 2020 01:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=//Rz/r5YcbzjQ/qsheosEFWXsiOoDrvcN8ZsfEl/6Ro=; b=LCok630lrYqKYjU2HitSA24M30gUHesBhEICvp/7lMvIj+kh7F5XrTsfe5pUVRWY7x qTpg+fGjXPvT92SjsIN0Ndmi5tFF6ugm0qf7H4+8JPC7Og5HNOZ1p1FwXwoXzjEuTPRb NB0mbjQOE6ZTnIic2qZGQgvnqVsDhi/Ir4SKnBObp60m8fhzl61TZ/w0vxZnB20PyV3Q MZteNThD1I6MxMiMPPia3zkbVQ3eNtjyIDkcLR4WAxrm0f44o8fOxFSlIVD1mWKLOPZJ Y7G/4UUJ3/oeN4Er6hmG+Ro0xognT+f8zAo2RFxkY4uxf2omM6V/E4n4GuCopiW7C+3C obgw== X-Gm-Message-State: AGi0PuaMMJAI1rJDXHetsUlQd0tNgIC8f3ZtkEq9keiaZMlqCBFtlWtL tEu7qiY2mbFgkD9wfRmtf5Idoq+wMIg8BEcmwO1lbKdPw5Tm2sUxRoJ+lk00isAnldDQW6+R+aT 6mrw1KLTuP/UzCzjWeDc= X-Received: by 2002:a05:6102:114f:: with SMTP id j15mr20474968vsg.180.1588063934336; Tue, 28 Apr 2020 01:52:14 -0700 (PDT) X-Google-Smtp-Source: APiQypJwU9cfbvCKUdXwjALLwJP/noCotwGtc/VzJRSP6VkiLZmmBkx6eg/+YyYDBZNP8udwr1c+feR6YqwI9C/T9cA= X-Received: by 2002:a05:6102:114f:: with SMTP id j15mr20474953vsg.180.1588063934054; Tue, 28 Apr 2020 01:52:14 -0700 (PDT) MIME-Version: 1.0 References: <20200427215849.116064-1-thinhtr@linux.vnet.ibm.com> In-Reply-To: From: David Marchand Date: Tue, 28 Apr 2020 10:52:02 +0200 Message-ID: To: Jerin Jacob Cc: Thinh Tran , dpdk-dev , David Christensen X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 28, 2020 at 9:58 AM Jerin Jacob wrote: > > On Tue, Apr 28, 2020 at 3:29 AM Thinh Tran w= rote: > > > > The AltiVec header file breaks boolean type: > > > > In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0= , > > from ../lib/librte_mempool/rte_mempool.h:54, > > from ../lib/librte_mbuf/rte_mbuf.h:38, > > from ../lib/librte_net/rte_ether.h:23, > > from ../drivers/common/mlx5/mlx5_nl.h:10, > > from ../drivers/common/mlx5/mlx5_nl.c:23: > > ../lib/librte_eal/include/rte_trace_point.h: In function > > =E2=80=98__rte_trace_point_fp_is_enabled=E2=80=99: > > ../lib/librte_eal/include/rte_trace_point.h:226:9: error: incompatible > > types when returning type =E2=80=98int=E2=80=99 but =E2=80=98__vector _= _bool int {aka > > __vector(4) __bool int}=E2=80=99 was expected > > return false; > > > > This is the same as > > https://git.dpdk.org/dpdk/commit/?id=3D725f5dd > > > > and yet, there is no better solution for it > > > > Signed-off-by: Thinh Tran > > --- > > lib/librte_eal/include/rte_trace_point.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/= include/rte_trace_point.h > > index 4d956ec16..2ede9e3ba 100644 > > --- a/lib/librte_eal/include/rte_trace_point.h > > +++ b/lib/librte_eal/include/rte_trace_point.h > > @@ -26,6 +26,12 @@ extern "C" { > > #include > > #include > > > > +#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__) > > +#undef bool > > +/* redefine as in stdbool.h */ > > +#define bool _Bool > > +#endif > > NACK. > > Please move the fix to rte_common.h or similar as it not specific to trac= e. > if you do so, the following hack also not need. > https://git.dpdk.org/dpdk/commit/?id=3D725f5dd +1 --=20 David Marchand