From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id BF0D7A00E6
	for <public@inbox.dpdk.org>; Tue, 11 Jun 2019 10:45:46 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1EEB41C2BC;
	Tue, 11 Jun 2019 10:45:46 +0200 (CEST)
Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com
 [209.85.222.44]) by dpdk.org (Postfix) with ESMTP id EC8001C2BA
 for <dev@dpdk.org>; Tue, 11 Jun 2019 10:45:44 +0200 (CEST)
Received: by mail-ua1-f44.google.com with SMTP id 7so4225512uah.1
 for <dev@dpdk.org>; Tue, 11 Jun 2019 01:45:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
 bh=7e52BuyyGP/F0BR3EKwC1YqfC/il/PwfJGV6nBgnVio=;
 b=sOBCIENDWoEAq8ibYSlsQGvLKtvdPYKevhwG1bElRWM246Biat98NXd1Ldfx6XcAzY
 U4RbEAiKsZp7ctCyaHzbgC0qyMqfqSQLiWsblQX1AUyZnCsBRB/quJP1KevZ+lmjLCPa
 7nrc6FQnD8Di9LqT2eXLZEnIBZBMSNXZ/sFzgxVfzIjJkejHrJYY+GYUM8nmhryFhhP+
 4he0j4mNKR9N3tRHXgcAPWREVZpof40rQtvDYiSLPfX3ziHMJ9jp7SLIZT0bmnxCPxob
 C4gDTQH8mKQPLQ5/v9GCAsVxd6c9lMxYfWervkPY5czCifVC40G7qrJPPHjzpt816RDj
 xN0Q==
X-Gm-Message-State: APjAAAXFLerCs7mmHT93L6Z3VGPrBVZchEXijbDeDoMA2goLKn2LrCip
 2+gsWlEkLgcD7I72VM4LHujFiEwXnZkO1EshNKQVMg==
X-Google-Smtp-Source: APXvYqwT8u9+XB3MtsFEjK2dnCRiRuO0BF6SWN1WzR4sKSpDHd0/sXimCtOAnratoKbLORZQxZt9Z0gjWLgce7o1wlU=
X-Received: by 2002:ab0:168a:: with SMTP id e10mr24318716uaf.87.1560242744357; 
 Tue, 11 Jun 2019 01:45:44 -0700 (PDT)
MIME-Version: 1.0
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 11 Jun 2019 10:45:33 +0200
Message-ID: <CAJFAV8yJ_SAvSQ-gK4dAuQmFFuYRqzz8qswmtDHEM1NV1oahXQ@mail.gmail.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, 
 Ian Stokes <ian.stokes@intel.com>, Ilya Maximets <i.maximets@samsung.com>, 
 Aaron Conole <aconole@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] Forcing inlining for igb_uio and kni
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

I noticed that OVS CI [1] patches the dpdk sources to force some inlining
parameters and get kni and igb_uio to build fine.

Looking at it in dpdk, meson support dropped this.
In the makefiles, I can't find a reason in the git history (we go back to
1.3.0rX version).

[dmarchan@dmarchan dpdk]$ git grep max-inline-insns-single
kernel/linux/igb_uio/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=100
kernel/linux/kni/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=50
[dmarchan@dmarchan dpdk]$ git blame origin/master --
kernel/linux/igb_uio/Makefile |grep max-inline-insns-single
13dc56a6 lib/librte_eal/linuxapp/igb_uio/Makefile (Intel
 2012-12-20 00:00:00 +0100 15) MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=100
[dmarchan@dmarchan dpdk]$ git blame origin/master --
kernel/linux/kni/Makefile |grep max-inline-insns-single
3fc5ca2f lib/librte_eal/linuxapp/kni/Makefile (Intel            2012-12-20
00:00:00 +0100 14) MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=50

Is there a valid reason to keep this?
1: https://github.com/openvswitch/ovs/blob/master/.travis/linux-build.sh#L81


-- 
David Marchand