From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1BCC455CE; Tue, 9 Jul 2024 06:51:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB28542E02; Tue, 9 Jul 2024 06:51:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 20E4C427DA for ; Tue, 9 Jul 2024 06:51:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720500714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vaih6/29Ibq2/9OYFXROPPgLm3I7q8dDPV8/XY4Xxv4=; b=VC0PRzlvRmCL02D6sMQXPF+irMBtEkL+DzVnXolsTUpr8ray0at7GmKdQeEB/NfFJfQgB3 dqT9Dl+NAKvYx+sJ3ImOH4CS0Ue+r2Lsnp1NUX2ocZGcCryO2w4VQLN59QfQvwL79pvVMj zMw1M8qIS5MGyQCPyDbZ0TyncPViW3w= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-W_K7ENVqOM6nYRIcj2DzgA-1; Tue, 09 Jul 2024 00:51:51 -0400 X-MC-Unique: W_K7ENVqOM6nYRIcj2DzgA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ee92048377so46605421fa.2 for ; Mon, 08 Jul 2024 21:51:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720500710; x=1721105510; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vaih6/29Ibq2/9OYFXROPPgLm3I7q8dDPV8/XY4Xxv4=; b=Or90dUW4oCurUmb+10fWSqkEXX6UZAL+Nxv+EfXQ1AH3NLqPQtrKmIpp700O/ckcg5 MSmSiHFdXgjG1dswsmEl31JBCtwzz2q/chpKeWKeHyMFn3bICQ24NxnCqjiPzzUp5P7Z GBsgmOROey2rgVRO3ZoFD0NUn8EI1QOzCP80mKFZA6aRpmZMxcneMDuMg+G3AXGWMqGx VnxtSk+9N0TEWrY8LRdVecIvNPn1hsvKFr26TOyXShqa3xyCxZ8pzQiMwpyvtMSGP0Ff OklOptI9T6ckKFhfKhjOoIFhhjbnyjIMtl+JET+r4MWCLCbdpkX0vxA03lQaArR4MoCV jmyw== X-Gm-Message-State: AOJu0Yxm2R3YfVWiNQecukVgw63vFON8iwIXCdpMh0L6xeVQQu6cCq8i lCbc33lrNR4tXWoqcEbG/0lR+t4zg8HKsLLN3x3Ck0ibkLFPPv3dzniAA/Gi3DxPlbYvt1DAa9y wl7Lz71laUjJn2CzfLTgjhCROVvnhbfOOpJGrNGUz72P91N2vY+bwDMFbvRFjtdO9FYmeyNXKt6 MLRzkLnlAv9R6BCTMIyNYjHBH2BA== X-Received: by 2002:a2e:960f:0:b0:2ee:52d5:c4a3 with SMTP id 38308e7fff4ca-2eeb318241amr10611631fa.39.1720500710231; Mon, 08 Jul 2024 21:51:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVofII8Szs9WexHC0qogxheX+15kOIRBCNsItIyTaDjlBemYxBNivrOquVWAcH/w3h62+JJr5+zcklNcbDujs= X-Received: by 2002:a2e:960f:0:b0:2ee:52d5:c4a3 with SMTP id 38308e7fff4ca-2eeb318241amr10611491fa.39.1720500709874; Mon, 08 Jul 2024 21:51:49 -0700 (PDT) MIME-Version: 1.0 References: <20240417093236.3786106-1-huangdengdui@huawei.com> In-Reply-To: From: David Marchand Date: Tue, 9 Jul 2024 06:51:37 +0200 Message-ID: Subject: Re: [PATCH] devtools: fix version variable not initialized To: Dengdui Huang Cc: dev@dpdk.org, bruce.richardson@intel.com, fengchengwen@huawei.com, haijie1@huawei.com, lihuisong@huawei.com, liuyonglong@huawei.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 27, 2024 at 4:28=E2=80=AFPM David Marchand wrote: > On Wed, Apr 17, 2024 at 11:32=E2=80=AFAM Dengdui Huang wrote: > > > > The version variable is not initialized. Therefore, if the -V option > > is not specified, the value of $version is obtained from the context, > > which may cause the version map parsing failure. > > > > Fixes: 6edec7f202ac ("devtools: list symbols by version") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dengdui Huang > Reviewed-by: David Marchand Applied, thanks. --=20 David Marchand