From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BA7442FC4; Thu, 3 Aug 2023 13:49:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88BF240C35; Thu, 3 Aug 2023 13:49:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2940D406BA for ; Thu, 3 Aug 2023 13:49:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691063366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xo224C1p7WqZ1vHGXMlgrFV7yY/dr2ZDH7tRgVhLdUE=; b=UtP7tgQXq6QfJI1+2Iqx2gCcC8sao1+QpOAhE8SSR5FjFZ8HQ4nnRqdjADKZdJA6hGnlUS Jejsz0xTz0gT6NrgWamjCcLFb5VvMZsNee+Y/fBpkA2mOX8Pe6HF3wWIr8u26vduNQ8Ytp S4OOpCvSZRExnVY4+QE2NxnuCVxz6/0= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-WWBoebytN2S4rDGBkHwPBA-1; Thu, 03 Aug 2023 07:49:25 -0400 X-MC-Unique: WWBoebytN2S4rDGBkHwPBA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2b9dc1bfddcso5281011fa.0 for ; Thu, 03 Aug 2023 04:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063364; x=1691668164; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xo224C1p7WqZ1vHGXMlgrFV7yY/dr2ZDH7tRgVhLdUE=; b=axs3x8+TOCa6Yp//shhk+a+7KWMJfC8f0pmTD6IRTuhpBqrcWP66Gb/38+gsRsovmF OZoMiMLRXtvfeo7IKS+TMwJfQ5uGaBqoNlA0HMBOK91mduSXk84SpMnix85aLX6FTYJ1 23JrKEcT0oGNkv7PIwiK+jifj/0LC27aac4un8WSF4S6Aib86W8GIXh79T5SgfUbtk6d uYQNrM+03URNJPAYMiYGJxnMWK7mV/7RJWpYhu6nemt8yo0PW93FITP6WdaQt0brQGsb A9SP1XLGm/T4jDCvx0FCZlp1NOgvA6tlT091xoKq5tIIcaORe2fWZqY+H0ParUWuxqqd BiiQ== X-Gm-Message-State: ABy/qLad0K2T4+pkohfh1JwJOjVhQH92GYnLj9HXkgZVVLnlgiZxZ4EE rnbnxJKLZBbex7Sd6jrqZYN2IDtZHMYPX/n96/DRIZbhrLfG3R3DhQx7rERF0DgLazv2zbaytKc WPEefY4iE1roQobeVOtY= X-Received: by 2002:a2e:b7c7:0:b0:2b9:d0bf:a3c5 with SMTP id p7-20020a2eb7c7000000b002b9d0bfa3c5mr2768513ljo.14.1691063363943; Thu, 03 Aug 2023 04:49:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlEsYSxG7LGXe/xxEgU/ofFnC3F0T+Xe8FpgKswBPciGC7RRl+nFJZxO1s7eQXWdeDJr11SQJtpT/TQ6nX8RSyo= X-Received: by 2002:a2e:b7c7:0:b0:2b9:d0bf:a3c5 with SMTP id p7-20020a2eb7c7000000b002b9d0bfa3c5mr2768509ljo.14.1691063363652; Thu, 03 Aug 2023 04:49:23 -0700 (PDT) MIME-Version: 1.0 References: <20230803075038.307012-1-david.marchand@redhat.com> <20230803075038.307012-4-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 3 Aug 2023 13:49:11 +0200 Message-ID: Subject: Re: [PATCH 03/14] bus/pci: find PCI capability To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, chenbo.xia@intel.com, nipun.gupta@amd.com, Anatoly Burakov , Jay Zhou , Timothy McDaniel , Julien Aube , Rahul Lakkireddy , Junfeng Guo , Jeroen de Borst , Rushil Gupta , Joshua Washington , Dongdong Liu , Yisen Zhuang , Maxime Coquelin , Gaetan Rivet X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 3, 2023 at 11:53=E2=80=AFAM Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 10:49:54AM +0100, Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > > > Introduce two helpers so that drivers stop reinventing the wheel. > > > Use it in existing drivers. > > > > > > > Can you give a little more context on the new helpers and the changes i= n > > the patch? A lot of the changes are not that self-explanatory. > > > Reading through the patch a second time, I get a better idea of what is > happening, and it looks fine [though still think a little more detail is > needed in the log] > > Acked-by: Bruce Richardson Sure, I'll update in v2. --=20 David Marchand