From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AC3742534; Thu, 7 Sep 2023 10:54:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11805402AF; Thu, 7 Sep 2023 10:54:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 183544026C for ; Thu, 7 Sep 2023 10:54:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694076851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pe1xRuGlsW5TTHk7wtStE1MCYoMFV9dgtRsA3Dy5RZo=; b=fTOnAqEiDslz2rEjpPDzg/wR38EFmLCgOCA4sCz0ko6WDiddBsR71I6wPjoQPICRjn+2EO GVx5OUDOloNxg/DSPTgOcebckVg+XVpPru1jv+fQxoPX4yFzcrc7MQUZgbNHfXWYDyRgVC WftgexnVFNDv3zQomLoMMZHouutxo+o= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-3ZaZSxUBPxCbDWJVqQn-oQ-1; Thu, 07 Sep 2023 04:54:10 -0400 X-MC-Unique: 3ZaZSxUBPxCbDWJVqQn-oQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2bcc1e0dfe5so8102341fa.1 for ; Thu, 07 Sep 2023 01:54:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694076849; x=1694681649; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pe1xRuGlsW5TTHk7wtStE1MCYoMFV9dgtRsA3Dy5RZo=; b=VrGh70VhLv9iYWgTv6bnPi/VIuRDlSZ41Vm46pA2cZHdd6BJpW1tywxXriNa4IG8MU 9LyzNca20hQ3jg6aP0RmT4AIXLnlqwtvPnYz5uXeQTkYaDTaIcx3dim6APp8kubdUxzW lskGquDnkjo4fn2lC/m6g4w6Tk3UR2BrpHcyDU4+WL714d+fodrF/2oGxLeIe89ryXlV XPh3PKStm023VHrNuhAI6aU/iAhIzq3Jtq3KtNvr94usrYTS5P0/wTV0BvShm22wE7Xb i7fArS2wJey3aTQ59UPJCIjHAgBj5jgYQG23x/vJPecU0OF38sLocRT/yS7yPej592II H1CA== X-Gm-Message-State: AOJu0YzN52GE2soSJUkLhGCBKi089VAiNktlNhh3Gt7xgAmKDOpLpRIC k/2daV5uw2t6VFw8Ocjwc1DQncgptxVUVbF172KvQMRwrDlj3oZuWexK67kQegKLwADgVigQP9H Ohsv1cymXvA5X3YKEt+o= X-Received: by 2002:a2e:80cd:0:b0:2b6:e105:6174 with SMTP id r13-20020a2e80cd000000b002b6e1056174mr4156912ljg.47.1694076849091; Thu, 07 Sep 2023 01:54:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnMPJMstQ2y6MJpDv41+fSFSjNcYlZTDvr74IFu8NSepiwL0hKk5hTScnshytx8HA3hOvoQkKstkOruS3o8fI= X-Received: by 2002:a2e:80cd:0:b0:2b6:e105:6174 with SMTP id r13-20020a2e80cd000000b002b6e1056174mr4156907ljg.47.1694076848840; Thu, 07 Sep 2023 01:54:08 -0700 (PDT) MIME-Version: 1.0 References: <20230906162226.1618088-1-thomas@monjalon.net> <20230906162226.1618088-6-thomas@monjalon.net> <98CBD80474FA8B44BF855DF32C47DC35D87B82@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B82@smartserver.smartshare.dk> From: David Marchand Date: Thu, 7 Sep 2023 10:53:57 +0200 Message-ID: Subject: Re: [PATCH 05/11] eal: force prefix for internal threads To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Thomas Monjalon , dev@dpdk.org, Tyler Retzlaff , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 7, 2023 at 10:50=E2=80=AFAM Morten Br=C3=B8rup wrote: > > This 10 value in the comment is easy to miss if some change with the > > prefix is done. > > Mentionning RTE_THREAD_INTERNAL_NAME_SIZE is enough. > > I disagree with David's comment to this. > > The function documentation is easier to read if the actual number is also= mentioned. > > For the best of both worlds, you can add something like this nearby: > > _Static_assert(sizeof(RTE_THREAD_NAME_PREFIX) =3D=3D sizeof("dpdk-"), > "Length of RTE_THREAD_NAME_PREFIX has changed; " > "the documentation needs updating."); And how will it catch the comment about 10 characters ? --=20 David Marchand