Re: [RFC 5/6] build: install indirect headers to a dedicated directory

[David Marchand <david.marchand@redhat.com>]

On Wed, Nov 27, 2024 at 12:43 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build
> > index b36add17e3..809706fe3e 100644
> > --- a/buildtools/pkg-config/meson.build
> > +++ b/buildtools/pkg-config/meson.build
> > @@ -27,12 +27,18 @@ endif
> >  # are skipped in the case of static linkage thanks to the flag --as-needed.
> >
> >
> > +subdirs = [ '.', 'internal' ]
> > +if get_option('include_subdir_arch') != ''
> > +    subdirs = [ subdirs, get_option('include_subdir_arch') ]
> > +    subdirs = [ subdirs, join_paths(get_option('include_subdir_arch'), 'internal')]
>
> minor nit, I tend to prefer using "+=" rather than relying on flattening to
> extend the arrays.

Hum, yes, I also prefer +=.
I think I mixed this with a different warning I hit when playing with
other meson objects...

I'll update in next revision.


--
David Marchand