From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 744C445D91; Tue, 10 Dec 2024 14:36:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D75F4029B; Tue, 10 Dec 2024 14:36:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2196340270 for ; Tue, 10 Dec 2024 14:36:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733837812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BQkjsGvskYLedJeoQHvJzJ0Yd/lGZgGmme/RO7pJRAY=; b=IVNy2j+L40UdYG2OIV6y8juUfxkmG6+85uNXyd1bAgWcGkwueBPAOo+U9fAPnHg7bjtln8 PeI9jzCMoYt3KR8+KQ8eYMNcYOQjM3R2gw9d2HlhqwkE5VT+lg0U3QnNoEq5gip0u0YY71 8zIUUgq0L4gJ9QJn8pn/GDkOd2+7DLg= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-pGLjY_YQPxyKoBdQgAxBNQ-1; Tue, 10 Dec 2024 08:36:49 -0500 X-MC-Unique: pGLjY_YQPxyKoBdQgAxBNQ-1 X-Mimecast-MFC-AGG-ID: pGLjY_YQPxyKoBdQgAxBNQ Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-540078a0f1aso1568928e87.3 for ; Tue, 10 Dec 2024 05:36:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733837808; x=1734442608; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BQkjsGvskYLedJeoQHvJzJ0Yd/lGZgGmme/RO7pJRAY=; b=iu8eQj9CatsXMIPJuXgxClGBC+eSPQpfG32ccSfGebgL4A3Uk+eCmdgUv0O8mw7VC4 /7x6TcjFCBDy67qX/qy8bA0GDjuzNULlfNePZHwUk/xFkNTyY/vyY7CgDN01seQ4W4C3 BQ5qLfWKF8il2H432FCJZEx40UuhzNbNCjL4Q71O4Hy7hvvevzw0d5dXLQfGugL2WwWr B6NfW+i8jUASR9xFa1y4wBbmPgNXKjctGuzN4BnNV87AG02jG1jL6K5qqO6wAPe3IEL1 KWmg9El0afe0/RHin7WJualICBpK1h2Hdbjx8yo6Cf83GNDHJT8Car4+7tcSsEE+q7ON ft0w== X-Gm-Message-State: AOJu0Yz6eSCSNiQRfxXi+oXytUoubTlwXwU4yb9o3P5ig7DgK+Q8OckL XGW5h6K3dAe3At+ePjMD+obGA/apYqdJ2TfRTIbmAHhQMObHZuD5xAMplRwaNmhTT2VWI1DuWyj VQBcSIWwj4xkCg684rVih8YS0NwrxoIVToZTPmBp1+/6DiVacVy6wB+iMs1bsm5mv3AP7jFKnB8 IDbtxoQLBro0GdI6I= X-Gm-Gg: ASbGncsU1jdU72ytks96HDmQrPQ+OSh+EX0LHt3MWtacDkMFEC3cEmM6QFe5ziq/zq2 Oyec4TqTNViruxFHKkc0V+wRdxMbPsLU04ZjVDQ== X-Received: by 2002:a05:6512:3416:b0:540:2201:57d2 with SMTP id 2adb3069b0e04-54022015b7emr2551827e87.49.1733837807952; Tue, 10 Dec 2024 05:36:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGb0g1edEEh79J0QaxmLyafEMkovUuXq3FPP8qoYmoUk5iufbCGlAFTzsspgklTww8g0Suv1ImtP2dzPrIrMRU= X-Received: by 2002:a05:6512:3416:b0:540:2201:57d2 with SMTP id 2adb3069b0e04-54022015b7emr2551820e87.49.1733837807590; Tue, 10 Dec 2024 05:36:47 -0800 (PST) MIME-Version: 1.0 References: <20241127112617.1331125-1-david.marchand@redhat.com> <20241127112617.1331125-6-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 10 Dec 2024 14:36:36 +0100 Message-ID: Subject: Re: [RFC 5/6] build: install indirect headers to a dedicated directory To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hLbFe1MGhRRKmaUSOoKWAbcCbUoPKjdkH7YMKedvDlg_1733837808 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 27, 2024 at 12:43=E2=80=AFPM Bruce Richardson wrote: > > diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/= meson.build > > index b36add17e3..809706fe3e 100644 > > --- a/buildtools/pkg-config/meson.build > > +++ b/buildtools/pkg-config/meson.build > > @@ -27,12 +27,18 @@ endif > > # are skipped in the case of static linkage thanks to the flag --as-ne= eded. > > > > > > +subdirs =3D [ '.', 'internal' ] > > +if get_option('include_subdir_arch') !=3D '' > > + subdirs =3D [ subdirs, get_option('include_subdir_arch') ] > > + subdirs =3D [ subdirs, join_paths(get_option('include_subdir_arch'= ), 'internal')] > > minor nit, I tend to prefer using "+=3D" rather than relying on flattenin= g to > extend the arrays. Hum, yes, I also prefer +=3D. I think I mixed this with a different warning I hit when playing with other meson objects... I'll update in next revision. -- David Marchand